Errant
b692b6e33e
Antag Rolebans ( #35966 )
...
Co-authored-by: beck-thompson <beck314159@hotmail.com >
Co-authored-by: Hannah Giovanna Dawson <karakkaraz@gmail.com >
2025-09-17 23:59:07 +02:00
Pieter-Jan Briers
0c97520276
Fix usages of TryIndex() ( #39124 )
...
* Fix usages of TryIndex()
Most usages of TryIndex() were using it incorrectly. Checking whether prototype IDs specified in prototypes actually existed before using them. This is not appropriate as it's just hiding bugs that should be getting caught by the YAML linter and other tools. (#39115 )
This then resulted in TryIndex() getting modified to log errors (94f98073b0#39098 )
This commit goes through and checks every call site of TryIndex() to see whether they were correct. Most call sites were replaced with the new Resolve(), which is suitable for these "defensive programming" use cases.
Fixes #39115
Breaking change: while doing this I noticed IdCardComponent and related systems were erroneously using ProtoId<AccessLevelPrototype> for job prototypes. This has been corrected.
* fix tests
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com >
2025-09-09 18:17:56 +02:00
Kyle Tyo
a711912cba
Unused dependency cleanup. ( #36760 )
...
* take 2! fight!!!
* final touches
* reeeeeee
2025-04-20 15:56:39 +02:00
Milon
3fc9bcbbbe
remove Session from MindComponent ( #34753 )
...
* yummy
* fix tests
2025-04-19 00:23:01 +02:00
Errant
46d58bf22a
Role Types ( #33420 )
...
* mindcomponent namespace
* wip MindRole stuff
* admin player tab
* mindroletype comment
* mindRolePrototype redesign
* broken param
* wip RoleType implementation
* basic role type switching for antags
* traitor fix
* fix AdminPanel update
* the renameningTM
* cleanup
* feature uncreeping
* roletypes on mind roles
* update MindComponent.RoleType when MindRoles change
* ghostrole configuration
* ghostrole config improvements
* live update of roleType on the character window
* logging stuff and notes
* remove thing no one asked for
* weh
* Mind Role Entities wip
* headrev count fix
* silicon stuff, cleanup
* exclusive antag config, cleanup
* jobroleadd overwerite
* logging stuff
* MindHasRole cleanup, admin log stuff
* last second cleanup
* ocd
* move roletypeprototype to its own file, minor note stuff
* remove Roletype.Created
* log stuff
* roletype setup for ghostroles and autotraitor reinforcements
* ghostrole type configs
* adjustable admin overlay
* cleanup
* fix this in its own PR
* silicon antagonist
* borg stuff
* mmi roletype handling
* spawnable borg roletype handling
* weh
* ghost role cleanup
* weh
* RoleEvent update
* polish
* log stuff
* admin overlay config
* ghostrolecomponent cleanup
* weh
* admin overlay code cleanup
* minor cleanup
* Obsolete MindRoleAddedEvent
* comment
* minor code cleanup
* MindOnDoGreeting fix
* Role update message
* fix duplicate job greeting for cyborgs
* fix emag job message dupe
* nicer-looking role type update
* crew aligned
* syndicate assault borg role fix
* fix test fail
* fix a merge mistake
* fix LoneOp role type
* Update Content.Client/Administration/AdminNameOverlay.cs
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com >
* Update Content.Shared/Roles/SharedRoleSystem.cs
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com >
* comment formatting
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com >
* change logging category
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com >
* fix a space
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com >
* use MindAddRoles
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com >
* get MindComponent from TryGetMind
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com >
* move var declaration outside loop
* remove TryComp
* take RoleEnum behind the barn
* don't use ensurecomp unnecessarily
* cvar comments
* toggleableghostrolecomponent documentation
* skrek
* use EntProtoId
* mindrole config
* merge baserolecomponent into basemindrolecomponent
* ai and borg silicon role tweaks
* formatting
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com >
* I will end you (the color)
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com >
* use LocId type for a locale id
* update RoleEvent documentation
* update RoleEvent documentation
* remove obsolete MindRoleAddedEvent
* refine MindRolesUpdate()
* use dependency
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com >
* inject dependency
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com >
* roleType.Name no longer required
* reformatted draw code logic
* GhostRoleMarkerRoleComponent comment
* minor SharedRoleSystem cleanup
* StartingMindRoleComponent, unhardcode roundstart silicon
* Update Content.Shared/Roles/SharedRoleSystem.cs
* remove a whitespace
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com >
2025-01-11 22:17:26 +01:00
Errant
93c7bdc134
Mind Role Entities ( #31318 )
...
* Mind Role Entities wip
* headrev count fix
* silicon stuff, cleanup
* exclusive antag config, cleanup
* jobroleadd overwerite
* logging stuff
* MindHasRole cleanup, admin log stuff
* last second cleanup
* ocd
* minor cleanup
* remove createdTime datafield
* now actually using the event replacement I made for role time tracking
* weh
2024-10-10 10:48:56 +02:00
Ed
a95d2257c3
JobRequirement refactor ( #30347 )
...
* refactor JobRequirements
* add profile support
* fix
* Update quartermaster.yml
* sloth fixes
* inport 30208
* Update DepartmentPrototype.cs
* species restriction
* left tweak stick
* stringbuilder is cool!
2024-08-05 14:25:49 +10:00
Cojoke
b57174007c
Remove all Assigned Values that are Never Used ( #30110 )
...
Remove all Assigned Values that are never used
2024-07-18 20:22:23 -04:00
Leon Friedrich
b632a65385
Add JobRequirementOverride prototypes ( #28607 )
...
* Add JobRequirementOverride prototypes
* a
* invert if
* Add override that takes in prototypes directly
2024-06-07 09:43:02 -07:00
DrSmugleaf
19be94c9ea
Add job whitelist system ( #28085 )
...
* Add job whitelist system
* Address reviews
* Fix name
* Apply suggestions from code review
Co-authored-by: Pieter-Jan Briers <pieterjan.briers@gmail.com >
* cancinium
---------
Co-authored-by: Pieter-Jan Briers <pieterjan.briers@gmail.com >
2024-06-01 05:08:31 -07:00
Repo
17304068b4
Track Admin Game Time ( #24945 )
...
* AdminTime tracked
* Attempts to fix PR issues.
* Admin afk logic update
2024-05-01 23:23:22 -07:00
metalgearsloth
3b7679f9c9
Don't throw on player spawn for playtime failure ( #24148 )
...
Still gets logged but won't abort the entire startup process.
2024-01-16 01:01:41 -07:00
Leon Friedrich
e685cb626b
Un-revert IPlayerManager refactor ( #21244 )
2023-10-28 09:59:53 +11:00
metalgearsloth
a2bbda43cc
Revert "Update submodule to 172.0.0 ( #21222 )" ( #21225 )
2023-10-24 21:55:20 +11:00
Leon Friedrich
7ba0ea2926
IPlayerManager refactor ( #21215 )
2023-10-24 20:19:08 +11:00
metalgearsloth
e1a91466f1
Fix playtime tracker ( #20014 )
2023-09-11 17:42:25 +10:00
metalgearsloth
b77265314b
Make role timer tooltips pretty ( #19605 )
...
Co-authored-by: ElectroJr <leonsfriedrich@gmail.com >
2023-09-11 15:44:21 +10:00
DrSmugleaf
3f3ba6ac62
Move minds, roles, jobs and objectives to shared ( #19679 )
2023-08-30 21:46:11 -07:00
DrSmugleaf
9567ae3b7f
Fixed not tracking job playtime ( #19639 )
2023-08-29 13:39:16 -07:00
DrSmugleaf
15c0211fb2
Refactor minds to be entities with components, make roles components ( #19591 )
...
Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com >
Co-authored-by: DrSmugleaf <DrSmugleaf@users.noreply.github.com >
2023-08-28 16:53:24 -07:00
metalgearsloth
20748cc542
Hotfix round restart loops ( #16292 )
...
Co-authored-by: DrSmugleaf <DrSmugleaf@users.noreply.github.com >
2023-05-11 11:00:39 +10:00
Moony
5cc78c2c75
Revert "Oops, All Captains! ( #14943 )" ( #14994 )
...
This reverts commit 8128759ea8
2023-03-30 18:55:09 -05:00
Skye
8128759ea8
Oops, All Captains! ( #14943 )
2023-03-30 18:54:38 -05:00
Jezithyr
eeb5b17b34
Mobstate Refactor ( #13389 )
...
Refactors mobstate and moves mob health thresholds to their own component
Co-authored-by: DrSmugleaf <drsmugleaf@gmail.com >
2023-01-13 16:57:10 -08:00
metalgearsloth
4b48f7e1ef
Add missing break on RemoveDisallowedJobs ( #10511 )
2022-08-11 22:47:54 +10:00
Pieter-Jan Briers
e852ada6c8
Play time tracking: Job timers 3: more titles: when the ( #9978 )
...
Co-authored-by: Veritius <veritiusgaming@gmail.com >
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com >
2022-08-07 16:00:42 +10:00
