Commit Graph

21 Commits

Author SHA1 Message Date
Pieter-Jan Briers
68ce53ae17 Random spontaneous cleanup PR (#25131)
* Use new Subs.CVar helper

Removes manual config OnValueChanged calls, removes need to remember to manually unsubscribe.

This both reduces boilerplate and fixes many issues where subscriptions weren't removed on entity system shutdown.

* Fix a bunch of warnings

* More warning fixes

* Use new DateTime serializer to get rid of ISerializationHooks in changelog code.

* Get rid of some more ISerializationHooks for enums

* And a little more

* Apply suggestions from code review

Co-authored-by: 0x6273 <0x40@keemail.me>

---------

Co-authored-by: 0x6273 <0x40@keemail.me>
2024-02-13 16:48:39 -05:00
metalgearsloth
7ada1c6674 Update content to new ParallelManager (#21813) 2023-11-29 11:00:12 +11:00
metalgearsloth
fd60d39bc7 Remove instruments compref (#19560) 2023-09-12 14:43:06 +10:00
metalgearsloth
5a0fc68be2 Content update for NetEntities (#18935) 2023-09-11 09:42:41 +10:00
Vera Aguilera Puerto
a2893dd6c3 Instrument band support, submodule update to 138.0.0 (#17995) 2023-07-16 21:12:53 +02:00
metalgearsloth
a0332c2f2e Don't spawn midi timer for inactive instruments (#14300) 2023-03-24 13:47:38 +11:00
Visne
c6d3e4f3bd Fix warnings and code cleanup/fixes (#13570) 2023-01-19 13:56:45 +11:00
Leon Friedrich
94011ca2b1 Misc changes from replay branch (#12581) 2022-11-15 17:34:47 +11:00
Vera Aguilera Puerto
1bc599b683 MIDI bank is set after the MIDI program
Fixes bug regarding incorrect program for the first few notes of some MIDI tracks.
2022-04-09 15:32:25 +02:00
Vera Aguilera Puerto
6e73e94cc6 Fix instruments for engine changes, fixes program change bug. (#7365) 2022-04-08 16:22:05 +02:00
metalgearsloth
563d4f4cbd Don't log on midi resolve failure (#6819) 2022-02-20 21:38:42 -07:00
mirrorcult
ec4d4688c7 Seal/abstract/virtual everything (#6739) 2022-02-16 18:23:23 +11:00
Pieter-Jan Briers
a0af197259 Set outside prediction flags on system/inputs to work without prediction.
This needs to be gone through more thoroughly but it works somewhat.
2021-12-30 03:12:04 +01:00
Vera Aguilera Puerto
e9c812c29c Use Timer.Spawn instead of TimerComp timers when disposing MIDI Renderers.
- Fixes a bug where renderers are not disposed of correctly when the instrument entity is deleted.
2021-12-18 00:30:29 +01:00
metalgearsloth
8af335097f More (IComponent) shenanigans and also some contaminated IoCManager.Resolve<IEntityManager>() very long yes calls 2021-12-07 22:22:34 +11:00
Vera Aguilera Puerto
f386b57148 Inline OwnerUid 2021-12-03 16:30:34 +01:00
20kdc
b5c5871453 Fix a bunch of returns where they should not be (#5640) 2021-12-01 15:00:10 +01:00
Vera Aguilera Puerto
47a19f94d4 Make instruments ECS (#5516) 2021-11-28 01:47:36 +01:00
Vera Aguilera Puerto
0be5ff829b Gets rid of all ComponentManager usages. (#4707) 2021-09-28 13:35:29 +02:00
DrSmugleaf
f878f353e4 Move some files out of Content.Shared root because I forgot (#4182) 2021-06-13 22:52:40 +10:00
DrSmugleaf
ff1a2d97ea Re-organize all projects (#4166) 2021-06-09 22:19:39 +02:00