Files
tbd-station-14/Content.Client
ArtisticRoomba f874459092 Pressure Relief Valve (#36708)
* initial system (this math is probably WRONG)

* General code cleanup and OnExamined support
(holy moly this code sucks)

* UICode and related events foundation
TODO:
- Actually write the XAML UI and the underlying system
- Un-shitcode the entire thing
- Actually test everything...

* Working UI code
TODO: Make predicted, as this certainly isn't predicted. Even though I said it was. It isn't.

* Remove one TODO for unshitcoding the examine code

* Add reminder
yea

* Make predicted (defenitely isn't)
(also defenitely isn't a copypaste from pressure pump code)

* It's predicted!
TODO:
- Give it snazzy predicted visuals!
- Have a different field for pressure entry, lest it gets bulldozed every UI update.

* Improve gas pressure relief valve UI
TODO: Reminder to reduce amount of dirties using deltafields

* Implement DirtyField prediction

* Entity<T> cleanup
A lot of Entity<T> conversions and lukewarm cleanup.

Also got caught copy pasting code in 4K UHD but it's not like you couldn't tell.

* More cleanup and comments

* Remove TODO comment on bulldozing window title

* """refactoring"""
- Move appearance out of shared and finally fix it. Pointless to predict appearance in this instance.
- More Entity<T> conversions because I like them.
- Move UI creation handling over entirely to the ActivatableUI system.
- Fix a hardcoded locale string (why????).

* Add visuals

* Revert debugging variable replacememt
yea

* Revert skissue

* Remove unused using directives and remove TODO

* Localize, cleanup, document

* Fix adminlogging discrepancy

* Add ability to construct, add guidebook entry

* Clear up comment

* Add guidebook tooltip to valve

* Convert GasPressureReliefValveBoundUserInterface declaration into primary constructor

* Adds more input handling and adds autofill on open

* Un-deepfry input validator shitcode
Genuinely what was I smoking

* improve visuals logic

* Refactor again
- Update math to the correct implementation
- Moved code that could be re-used in the future into a helper method under AtmosphereSystem.Gases.cs

* I'm sorry but I hate warnings

* Remove unused using directive in AtmosphereSystem.Gases.cs

* Review and cleanup

* Lukewarm UI glossup

* Maintainer for the upstream project btw

* Remove redundant state sets and messy logic

* Unduplicate valve updater code

* Redo UI (im sorry Slarti)

* run tests

* Test refactored UI messaging

* Second round of UI improvements
- God please find a way to improve this system. Feels bad.

* Update loop implementation

* Further predict UI

* Clear up SetToCurrentThreshold

* cleanup

* Update to master + pipe layers and bug fixes
want to run tests

* fixes

* Deploy rename pipebomb

* Documentation and requested changes

* Rename the method that wiggled away

* Undo rounding changes

* Fix comment

* Rename and cleanup

* Apply suggestions from code review

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2025-07-03 18:00:34 +02:00
..
2025-06-21 20:59:37 +03:00
2024-07-26 10:30:49 -07:00
2025-07-03 18:00:34 +02:00
2025-06-17 02:08:08 +02:00
2025-04-19 16:20:40 +10:00
2025-04-21 12:24:44 +02:00
2025-04-19 16:20:40 +10:00
2025-06-01 11:24:13 -04:00
2025-05-02 18:18:08 +10:00
2025-05-17 13:20:11 -04:00
2025-06-23 13:32:56 +02:00
2024-09-24 19:02:51 +02:00
2025-04-10 22:19:48 -07:00
2025-02-12 23:46:02 -05:00
2025-06-21 11:23:19 -04:00
2024-07-21 17:17:59 +10:00
2025-07-03 00:36:06 -04:00
2024-08-25 22:18:42 +10:00
2025-06-21 20:59:37 +03:00
2024-08-23 11:14:38 +02:00
2025-06-04 12:52:59 +02:00
2025-07-03 00:36:06 -04:00
2024-08-25 22:18:42 +10:00
2025-05-17 15:22:40 +10:00
2025-06-25 15:13:03 +02:00
2024-12-17 20:18:15 +01:00
2025-02-08 17:17:55 +11:00
2024-09-26 18:55:59 +02:00
2025-02-23 18:23:00 +11:00