Commit Graph

3378 Commits

Author SHA1 Message Date
metalgearsloth
abed6fc15d More nullas as errors (#2611)
* More nullas as errors

* I thought I'd tried this but maybe I'm a dumbo

Co-authored-by: Metal Gear Sloth <metalgearsloth@gmail.com>
2020-12-09 23:28:24 +11:00
20kdc
58af9003e7 Canisters [ Continuation of clement-or #2544 ] (#2628)
* Added atmos sprites from CEV-Eris

* Moved canister sprites to appropriate dir

* Removed unnecessary sprites, edited canisters prototype

* Created Gas Canister UI and release pressure buttons

* Changed GasMixture's pressure calculation (convert liters to cube meters)

* Added relabeling Canisters

* Reverted changes on GasMixture

* Changed my name in the credits

* Added valve opening on canisters

* Change canister visual state when connected to a port

* Added nullable to SharedGasCanisterComponent

* Replaced nullable contexts

* Changed again nullable annotation context

* Moved name in the credits to correct alphabetical order

* Canisters: Fix the most blatant issues with this PR (the added project interdependencies for no reason whatsoever)

* Canisters: Stop crashes when canisters leave atmosphere

* Canisters: Gas released into no atmosphere gets transferred "into space" (deleted)

* Atmos: Nullability annotations on TileAtmosphere, explaination of the states of TileAtmosphere.Air

* Canisters: If in an airblocked tile, do NOT release gas

* Scrubbers: Fix typo leading to them not connecting properly.

* Revert manual changes to credits file (sorry!) (1/2)

This reverts commit 94f3b0e5df8d9c2fa189866a17a231920f99bdaf.

* Revert manual changes to credits file (sorry!) (2/2)

This reverts commit 1986fb094dfaa44060f08d280f36b755258d17a6.

* Canisters: Apply @Zumorica 's reviews

* Canisters: Add missing localization as suggested by PJB

Co-authored-by: Pieter-Jan Briers <pieterjan.briers@gmail.com>

* Canisters: Pressure lights!

* Canisters: Light is now unshaded.

* Canisters: Now using IActivate

* Gas canisters (& air canister), now with their numbers properly calibrated (hopefully)

* Canisters: Refactor how their layers are added to be more like ApcVisualizer

* Canisters: Clean up of the tile invalidation/air release logic

* Canisters: Some gas canister window improvements

* Canisters: Clean up release pressure change button label code

Co-authored-by: Clement-O <topy72.mine@gmail.com>
Co-authored-by: Clément <clement.orlandini@gmail.com>
Co-authored-by: Pieter-Jan Briers <pieterjan.briers@gmail.com>
2020-12-08 20:45:24 +01:00
Vera Aguilera Puerto
2b6964746c Adds Invalidate method to TileAtmosphere, clean up a bunch of tile invalidations 2020-12-08 17:36:59 +01:00
py01
656eb7dc2e ChemicalInjectionProjectileComponent (#2657)
Co-authored-by: py01 <pyronetics01@gmail.com>
2020-12-08 23:19:01 +11:00
py01
cc26218060 MeleeChemicalInjectorComponent (#2645)
* MeleeWeaponComponent OnHittingEntities event

* MeleeChemicalInjectorComponent

* Moves melee onhit action to EventBus

* serialization fix

* prototype fix

* redid chem transfer logic

* MeleeChemicalinjector uses ComponentMessages

* divide by 0 fix

* Update Resources/Prototypes/Entities/Objects/Weapons/Melee/spear.yml

Co-authored-by: py01 <pyronetics01@gmail.com>
Co-authored-by: Vera Aguilera Puerto <6766154+Zumorica@users.noreply.github.com>
2020-12-08 12:57:47 +01:00
DrSmugleaf
89e853d8e2 Make disposal units also flush air (#2686)
* Make disposal units also flush air

* Make disposals use tile.AssumeAir instead of tile.Air.Merge

Co-authored-by: Vera Aguilera Puerto <6766154+Zumorica@users.noreply.github.com>
2020-12-08 12:54:34 +01:00
metalgearsloth
fe93f2ac30 Fix thrown throwing (#2723)
Technically some stuff could be dependent upon the entity regardless if it's deleted but this is how ICollideBehavior does it (not by my design) so I figured we'd make it consistent.

If someone really needs the functionality even if it's deleted then they can refactor it.

Co-authored-by: Metal Gear Sloth <metalgearsloth@gmail.com>
2020-12-08 12:21:12 +01:00
Paul Ritter
5b561ae3e7 Rotatable Firelocks (#2429)
Co-authored-by: Paul <ritter.paul1+git@googlemail.com>
2020-12-08 12:19:16 +01:00
Vera Aguilera Puerto
54c70fbb95 Update submodule 2020-12-08 12:18:52 +01:00
DrSmugleaf
074db878bb Remove redundant null checks for atmos (#2703)
* Remove redundant null checks for atmos

* Remove unnecessary nullability parameter from AtmosphereSystem.GetGridAtmosphere

* Remove more nullability markers

* Bring back null checks for gas tanks

* Remove null checks from GasMixture.Merge and TileAtmosphere.AssumeAir

Co-authored-by: Vera Aguilera Puerto <6766154+Zumorica@users.noreply.github.com>
2020-12-08 12:17:13 +01:00
metalgearsloth
a78452c845 Fix disposals do_after (#2722)
* Fix disposals do_after

* DataField instead

* Update Content.Server/GameObjects/Components/Disposal/DisposalMailingUnitComponent.cs

Co-authored-by: Vera Aguilera Puerto <6766154+Zumorica@users.noreply.github.com>

* Update Content.Server/GameObjects/Components/Disposal/DisposalUnitComponent.cs

Co-authored-by: Metal Gear Sloth <metalgearsloth@gmail.com>
Co-authored-by: Vera Aguilera Puerto <6766154+Zumorica@users.noreply.github.com>
2020-12-08 12:17:00 +01:00
metalgearsloth
9788cf8ead Fix some string crimes (#2638)
* Fix some string crimes

* fuk

* stringbuilder score

Co-authored-by: Metal Gear Sloth <metalgearsloth@gmail.com>
2020-12-08 11:58:55 +01:00
20kdc
ae57355ce5 Antimatter Engine Crates (#2708)
* Remove the unused light bulb crate that explicitly says it needs to be removed

* Crates/Cargo: Add antimatter reactor crates

* Fix AME crate issues

* Descriptions and prices for AME crates.
2020-12-08 11:58:46 +01:00
DrSmugleaf
2dc05b2275 Add UsedImplicitly to visualizers and entity systems (#2592) 2020-12-08 11:56:10 +01:00
20kdc
d75c22d5e1 Add "Begin Deconstruction" verb, unfinished particle accelerator bits will tell you how to finish them (#2706)
* More Construction Pieces: Default construction targets

* More Construction Pieces: Unfinished particle accelerator will tell you how to finish it

* More Construction Pieces: Construction system actually pathfinds any-to-any

* More Construction Pieces: Verb to begin deconstruction of an object
2020-12-08 11:53:37 +01:00
Exp
f6d62ada65 Adds popups and sounds to the vending machine deny (#2715)
* -Vending machine deny sound
-And popup

* Comment this

* Change casing
2020-12-08 17:42:43 +11:00
Swept
ee474e6421 Removes Chaplain (#2699)
* Initial

* Removes PDA too

* Applied reviews
2020-12-08 00:23:24 +01:00
DrSmugleaf
02bca4c0d8 Damage rework (#2525)
* Make damage work through messages and events, make destructible not inherit ruinable or reference damageable

* Copy sound logic to destructible component for now

* Fix typo

* Fix prototype error

* Remove breakable component damageable reference

* Remove breakable construction reference

* Remove ruinable component

* Move thresholds to individual components and away from damageable

* Add threshold property to damageable component code

* Add thresholds to destructible component, add states to damageable, remove damage container, fix up mob states

* Being alive isn't normal

* Fix not reading the id

* Merge fixes

* YAML fixes

* Grammar moment

* Remove unnecessary dependency

* Update thresholds doc

* Change naming of thresholds to states in MobStateComponent

* Being alive is once again normal

* Make DamageState a byte

* Bring out classes structs and enums from DestructibleComponent

* Add test for destructible thresholds

* Merge fixes

* More merge fixes and fix rejuvenate test

* Remove IMobState.IsConscious

* More merge fixes someone please god review this shit already

* Fix rejuvenate test

* Update outdated destructible in YAML

* Fix repeatedly entering the current state

* Fix repeatedly entering the current state, add Threshold.TriggersOnce and expand test

* Update saltern
2020-12-07 14:52:55 +01:00
Vera Aguilera Puerto
9a187629ba Fix integration tests
One crate still had the smug plushie.
2020-12-06 21:13:23 +01:00
20kdc
684b942445 FlammableComponent: Fix bug where if an AI ends up on fire an exception occurs because it tries to update status (#2714) 2020-12-06 21:10:56 +01:00
DrSmugleaf
69924ab600 Fix a criminal if in breathing code 2020-12-06 13:27:11 +01:00
Swept
58bdc7790b Removes funny smug plushie (#2711)
* Removes smug plushie

* Prototype

* Removed from medical crate
2020-12-06 12:22:21 +01:00
DrSmugleaf
639cc86d91 Nanotransen > Nanotrasen
As decreed by PJB
https://discord.com/channels/310555209753690112/675078881425752124/784878237850402826
2020-12-05 21:48:11 +01:00
Manel Navola
7265c53391 Added master volume slider in audio options (#2642)
Co-authored-by: Manel Navola <ManelNavola@users.noreply.github.com>
2020-12-05 21:14:16 +01:00
Vera Aguilera Puerto
2b59159363 Actually fix NRE in atmos. 2020-12-05 20:09:22 +01:00
Vera Aguilera Puerto
74e1deba2f Better nullability for GridAtmosphereComponent 2020-12-05 19:10:07 +01:00
Vera Aguilera Puerto
f07bac2cc8 Remove unused machine board field 2020-12-05 19:09:20 +01:00
Vera Aguilera Puerto
da39d18637 Fix rare NRE in atmos 2020-12-05 18:57:04 +01:00
Swept
e1ba52c05b Crates - 3rd times a charm (#2669)
* Sprites

* Crates

* Moved cargo_console

* Cargo Catalogs No.1

* Added some Hydroponics crates

* More crates..

* Deletes an autogen file

* snivybus

* More

* Apply suggestions from code review

* Fix wrong prototype ID

* Fix another wrong prototype ID

* Fix... MANY, MANY wrong prototype IDs

Co-authored-by: Vera Aguilera Puerto <6766154+Zumorica@users.noreply.github.com>
Co-authored-by: Vera Aguilera Puerto <zddm@outlook.es>
2020-12-05 15:59:46 +01:00
Swept
e4fe98f433 Spawn aprons for botanist and chef (#2707) 2020-12-05 15:15:52 +01:00
DmitriyRubetskoy
0e72bcb4b8 Getmore Chocolate corp. Vendor working (#2704)
* GetmoreChocolate corp vendor working

* ChocoVendor Works now1

Co-authored-by: DmitriyRubetskoy <rubetskoy234@mail.ru>
2020-12-05 15:14:45 +01:00
Vera Aguilera Puerto
983aa9ed0f Fix tile equalization terrible mistake 2020-12-05 14:19:36 +01:00
Vera Aguilera Puerto
8dd59fe3d7 Trays now capable of being pulled (#2705)
Co-authored-by: DmitriyRubetskoy <rubetskoy234@mail.ru>
2020-12-04 19:15:55 +01:00
Vera Aguilera Puerto
14e9823354 Update Resources/Prototypes/Entities/Constructible/Specific/hydroponics.yml 2020-12-04 19:15:30 +01:00
DmitriyRubetskoy
594beb4acd Trays now capable of being pulled 2020-12-04 21:09:52 +03:00
R. Neuser
c4c4a1ca8c Use MousePositionScaled instead of absolute MousePosition to fix UI-scaling issues (#2568)
* Use MousePositionScaled instead of absolute MousePosition to fix UI-scaling issues

* Fix compiler warnings
2020-12-04 15:24:22 +01:00
Pieter-Jan Briers
0ed1191623 I am not sorry 2020-12-04 13:34:23 +01:00
DrSmugleaf
1b1d050ee7 Update components to use EnsureWarn (#2676)
Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com>
2020-12-04 13:26:54 +01:00
DrSmugleaf
1eaad7e5d7 Fix removehand command when you have no hands (#2685)
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
2020-12-04 13:17:40 +01:00
Swept
af28de36ee Updates all vests meta.jsons (#2700) 2020-12-04 13:15:33 +01:00
Pieter-Jan Briers
7e56c240de Update da submodule 2020-12-04 13:05:48 +01:00
DrSmugleaf
de0975c228 Add InvalidateTileAir Transform extension method (#2687)
* Add InvalidateTileAir Transform extension method

* Add extension method for EntityCoordinates as well
2020-12-04 12:21:57 +01:00
Vera Aguilera Puerto
b0d1d31ccc Makes protolathe use machine parts 2020-12-04 12:05:15 +01:00
ColdAutumnRain
266d2909d7 Added enum types (#2701) 2020-12-04 11:57:33 +01:00
ColdAutumnRain
216a47dddc Updated serializer data fields (#2702) 2020-12-04 11:06:53 +01:00
Pieter-Jan Briers
87149e18b5 Fix parallax.debug defaulting to true. 2020-12-04 11:04:43 +01:00
Pieter-Jan Briers
1112afe700 Remove log spam from EFCore. 2020-12-04 00:35:53 +01:00
Pieter-Jan Briers
8f8345ef7d Fix admin logout messages for non-admin players.
Fixes #2616
2020-12-04 00:25:57 +01:00
Pieter-Jan Briers
f7c8e62cee Make warning about non-storeables in storage less bad. 2020-12-04 00:15:21 +01:00
Vera Aguilera Puerto
c3341132c5 Upgradeable machines. (#2675)
* Start work on upgradeable machines.

* Upgradeable machines work

* Component requirements for upgradeable machines

* Better container handling

* Remember to not push submodule updates in your PRs, kids!

* Refresh parts after building a machine.

* NetSync false

* Address some reviews, fix some bugs

* Nullable stackhelpers dependencies

* Use container helper method to delete all entities in containers

* Nullable string in AddContainer

* Better examine for machine frame and construction in general

* Machine breakage

* Nullable node

* nullable GraphPrototype

* Re-save saltern for autolathe parts

* Fix SaveLoadSave
2020-12-03 22:49:00 +01:00