tommy/tbd-station-14
2
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

log error when trying to set invalid solution ratio and clamp it (#13675)

Browse Source
This commit is contained in:
Rane
2023-01-23 19:33:11 -05:00
committed by GitHub
parent bda3a1047f
commit fb3df96654
1 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
Content.Client/Chemistry/Visualizers/SolutionContainerVisualsSystem.cs
View File

@@ -18,6 +18,15 @@ public sealed class SolutionContainerVisualsSystem : VisualizerSystem<SolutionCo
if (!args.Sprite.LayerMapTryGet(component.Layer, out var fillLayer)) if (!args.Sprite.LayerMapTryGet(component.Layer, out var fillLayer))
return; return;
// Currently some solution methods such as overflowing will try to update appearance with a
// volume greater than the max volume. We'll clamp it so players don't see
// a giant error sign and error for debug.
if (fraction > 1f)
{
Logger.Error("Attempted to set solution container visuals volume ratio on " + ToPrettyString(uid) + " to a value greater than 1. Volume should never be greater than max volume!");
fraction = 1f;
}
var closestFillSprite = (int) Math.Round(fraction * component.MaxFillLevels); var closestFillSprite = (int) Math.Round(fraction * component.MaxFillLevels);
if (closestFillSprite > 0) if (closestFillSprite > 0)