tommy/tbd-station-14
2
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix alerts mispredict + log spam (#36004)

Browse Source 
tstalker alerted me to it and noticed the classic case of shallow copies.
This commit is contained in:
metalgearsloth
2025-03-22 22:41:16 +11:00
committed by GitHub
parent c2963d47a0
commit a9a6b98f99
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Content.Client/Alerts/ClientAlertsSystem.cs
View File

@@ -52,7 +52,7 @@ public sealed class ClientAlertsSystem : AlertsSystem
if (args.Current is not AlertComponentState cast)
return;
alerts.Comp.Alerts = cast.Alerts;
alerts.Comp.Alerts = new(cast.Alerts);
UpdateHud(alerts);
}

3
Content.Server/Alert/ServerAlertsSystem.cs
View File

@@ -14,6 +14,7 @@ internal sealed class ServerAlertsSystem : AlertsSystem
private void OnGetState(Entity<AlertsComponent> alerts, ref ComponentGetState args)
{
args.State = new AlertComponentState(alerts.Comp.Alerts);
// TODO: Use sourcegen when clone-state bug fixed.
args.State = new AlertComponentState(new(alerts.Comp.Alerts));
}
}