Serialization v3 content PR (#3491)

* serv3 in shared pt 1

* beginning of deepclone api

* progress in implementing ideepclone & serv3 in content

* adds target

* its cant hurt you it cant hurt you

* more changes to content.server

* adds dataclasses

* almost there

* renamed & edited entry

* finishes refactoring content to use serv3

* gasmixture runtimes, next: reagentunit

* fucin hell that was an annoying one

* adds flags

* fixes some yaml errors

* removes comment

* fixes generic components for now

* removes todo
actually clones values my god paul
fixes bug involving resolving custom data classes from other proj
renames dataclass
fixes spritecomp
adds WithFormat.Constants support

* adds deepclone to ResistanceSet

* adds a bunch of deepclone implementations
adds a deepclone analyzer (TODO)
adds a deep clone fallback for classes & structs

* fixes a bunch of runtimes

* adds deepclone to entityuid

* adds generator to sln

* gets rid of warnings

* fixes

* argh

* componentdata refactors

* more deepclone impl

* heck me i reworked all of content deepclone

* renames custom dataclasstarget

* misc

* reworks prototypes

* deepclone nuke

* renamed customdataclass attribute

* fixes everything

* misc fixed

* the killcommit

* getting there

* changed yamlfieldattribute namespace

* adds back iselfserialize

* renames everything to data(field/definition)

* ouch

* Fix most errors on content

* Fix more errors in content

* Fix some components

* work on tests

* fixes some customdataclasses

* fuggin shit

* yes

* yeas

* Remove data classes

* Data field naming fixes

* arg

* Git resetti RobustToolbox

* Merge fixes

* General fixes

* Fix startup serialization errors

* Fix DamageContainerPrototype when supported classes or types are null

* Implement construction graph step type serializer

* Fix up construction serialization

* Fix up construction serialization part 2

* Fix null list in technology database component

* Fix body serialization

* Fix entity storage serialization

* Fix actions serialization

* Fix AI serialization

* Fix reaction serialization

* Fix body serialization

* Fix grid atmosphere serialization

* Rename IServ3Manager to ISerializationManager

* Convert every non generic serializer to the new format, general fixes

* Serialization and body system fix

* pushinheritance fix

* Update all prototypes to have a parent and have consistent id/parent properties

* Merge fixes

* smh my head

* cuddling slaps

* Content commit for engine PR

* stuff

* more fixes

* argh

* yes even you are fixed

* changelog fixes

* fixes seeds

* argh

* Test fixes

* Add writing for alert order prototype

* Fix alert order writing

* FIX

* its been alot ok

* Fix the rest of the visualizers

* Fix server alerts component tests

* Fix alert prototype tests not using the read value

* Fix alert prototype tests initializing serialization multiple times

* THIS IS AN AMERICAN CODEBASE GOD BLESS THE USA

* Add ImplicitDataDefinitionForInheritors to IMechanismBehavior
Fixes the behaviors not being found

* Fix NRE in strap component
Good night to the 1 buckle optimization

* Fix clothing component slot flags serialization tag

* Fix body component in all components test

* Merge fixes

* ffs

* Make construction graph prototype use serialization hooks

* human yaml linted

* a

* Do the thing for construction

* stuff

* a

* monke see yaml linter

* LINT HARDER

* Remove redundant todo

* yes

* Add skip hook argument to readers and copiers

* we gamin

* test/datafield fixes

* adds more verbose validation

* moves linter to action

* Improve construction graph step type serializer error message

* Fix ammo box component NRE

* gamin

* some updates to the linter

* yes

* removes that test

* misc fixes

* array fix
priority fix
misc fixes

* adds proper info the validation

* adds alwaysrelevant usa

* Make yaml linter take half as long to run (~50% less)

* Make yaml linter 5 times faster (~80% less execution time)

* based vera being based

* fixes mapsaving

* warning cleanup & moves surpressor

* removes old msbuild targets

* Revert "Make yaml linter 5 times faster (~80% less execution time)"

This reverts commit 3e6091359a26252c3e98828199553de668031c63.

* Add -nowarn to yaml linter run configuration

* Improve yaml linter message feedback

* Make dependencies an argument instead of a property on the serialization manager

* yamllinting slaps

* Clean up type serializers

* Move yaml linter code to its own method

* Fix yaml errors

* Change yaml linter action name and remove -nowarn

* yaml linter please shut

* Git resetti robust toolbox

Co-authored-by: Paul <ritter.paul1+git@googlemail.com>
Co-authored-by: DrSmugleaf <DrSmugleaf@users.noreply.github.com>

Content.Shared/Alert/AlertPrototype.cs

@@ -1,14 +1,13 @@
 #nullable enable
 using System;
 using System.Globalization;
-using Content.Shared.Interfaces;
-using Robust.Shared.IoC;
 using Robust.Shared.Log;
 using Robust.Shared.Prototypes;
 using Robust.Shared.Serialization;
+using Robust.Shared.Serialization.Manager;
+using Robust.Shared.Serialization.Manager.Attributes;
 using Robust.Shared.Utility;
 using Robust.Shared.ViewVariables;
-using YamlDotNet.RepresentationModel;
 
 namespace Content.Shared.Alert
 {
@@ -16,13 +15,19 @@ namespace Content.Shared.Alert
     /// An alert popup with associated icon, tooltip, and other data.
     /// </summary>
     [Prototype("alert")]
-    public class AlertPrototype : IPrototype
+    public class AlertPrototype : IPrototype, ISerializationHooks
     {
-        public string ID { get; private set; } = string.Empty;
+        [ViewVariables]
+        string IPrototype.ID => AlertType.ToString();
+
+        [ViewVariables]
+        [field: DataField("parent")]
+        public string? Parent { get; }
 
         /// <summary>
         /// Type of alert, no 2 alert prototypes should have the same one.
         /// </summary>
+        [DataField("alertType")]
         public AlertType AlertType { get; private set; }
 
         /// <summary>
@@ -32,16 +37,19 @@ namespace Content.Shared.Alert
         /// to get the correct icon path for a particular severity level.
         /// </summary>
         [ViewVariables]
+        [DataField("icon")]
         public SpriteSpecifier Icon { get; private set; } = SpriteSpecifier.Invalid;
 
         /// <summary>
         /// Name to show in tooltip window. Accepts formatting.
         /// </summary>
+        [DataField("name")]
         public FormattedMessage Name { get; private set; } = new();
 
         /// <summary>
         /// Description to show in tooltip window. Accepts formatting.
         /// </summary>
+        [DataField("description")]
         public FormattedMessage Description { get; private set; } = new();
 
         /// <summary>
@@ -51,6 +59,7 @@ namespace Content.Shared.Alert
         /// replace each other and are mutually exclusive, for example lowpressure / highpressure,
         /// hot / cold. If left unspecified, the alert will not replace or be replaced by any other alerts.
         /// </summary>
+        [DataField("category")]
         public AlertCategory? Category { get; private set; }
 
         /// <summary>
@@ -64,13 +73,14 @@ namespace Content.Shared.Alert
         /// </summary>
         public short MinSeverity => MaxSeverity == -1 ? (short) -1 : _minSeverity;
 
-        private short _minSeverity;
+        [DataField("minSeverity")] private short _minSeverity = 1;
 
         /// <summary>
         /// Maximum severity level supported by this state. -1 (default) indicates
         /// no severity levels are supported by the state.
         /// </summary>
-        public short MaxSeverity { get; private set; }
+        [DataField("maxSeverity")]
+        public short MaxSeverity = -1;
 
         /// <summary>
         /// Indicates whether this state support severity levels
@@ -80,48 +90,23 @@ namespace Content.Shared.Alert
         /// <summary>
         /// Whether this alert is clickable. This is valid clientside.
         /// </summary>
-        public bool HasOnClick { get; private set; }
+        public bool HasOnClick => OnClick != null;
 
         /// <summary>
         /// Defines what to do when the alert is clicked.
         /// This will always be null on clientside.
         /// </summary>
+        [DataField("onClick", serverOnly: true)]
         public IAlertClick? OnClick { get; private set; }
 
-        public void LoadFrom(YamlMappingNode mapping)
+        void ISerializationHooks.AfterDeserialization()
         {
-            var serializer = YamlObjectSerializer.NewReader(mapping);
-
-            serializer.DataField(this, x => x.Icon, "icon", SpriteSpecifier.Invalid);
-            serializer.DataField(this, x => x.MaxSeverity, "maxSeverity", (short) -1);
-            serializer.DataField(ref _minSeverity, "minSeverity", (short) 1);
-
-            serializer.DataReadFunction("name", string.Empty,
-                s =>
-                {
-                    ID = s;
-                    Name = FormattedMessage.FromMarkup(s);
-                });
-            serializer.DataReadFunction("description", string.Empty,
-                s => Description = FormattedMessage.FromMarkup(s));
-
-            serializer.DataField(this, x => x.AlertType, "alertType", AlertType.Error);
             if (AlertType == AlertType.Error)
             {
                 Logger.ErrorS("alert", "missing or invalid alertType for alert with name {0}", Name);
             }
 
-            if (serializer.TryReadDataField("category", out AlertCategory alertCategory))
-            {
-                Category = alertCategory;
-            }
-
             AlertKey = new AlertKey(AlertType, Category);
-
-            HasOnClick = serializer.TryReadDataField("onClick", out string _);
-
-            if (IoCManager.Resolve<IModuleManager>().IsClientModule) return;
-            serializer.DataField(this, x => x.OnClick, "onClick", null);
         }
 
         /// <param name="severity">severity level, if supported by this alert</param>
@@ -174,9 +159,9 @@ namespace Content.Shared.Alert
     /// falls back to the id.
     /// </summary>
     [Serializable, NetSerializable]
-    public struct AlertKey
+    public struct AlertKey : ISerializationHooks, IPopulateDefaultValues
     {
-        public readonly AlertType? AlertType;
+        public AlertType? AlertType { get; private set; }
         public readonly AlertCategory? AlertCategory;
 
         /// NOTE: if the alert has a category you must pass the category for this to work
@@ -211,6 +196,11 @@ namespace Content.Shared.Alert
             return AlertType.GetHashCode();
         }
 
+        public void PopulateDefaultValues()
+        {
+            AlertType = Alert.AlertType.Error;
+        }
+
         /// <param name="category">alert category, must not be null</param>
         /// <returns>An alert key for the provided alert category. This must only be used for
         /// queries and never storage, as it is lacking an alert type.</returns>