Simplify DoAfterArgs behavior for movement and distance checks (#25226)

* Merge BreakOnWeightlessMove and BreakOnMove. Provide different theshold for weightless movement.

* Adjust WeightlessMovementThresholds. Put a thing I forgot to put in the doafterargs.

* Make DoAfterArgs only use OnMove to determine whether to check for
movement and MoveThreshold to determine the threshold regardless of
weightlessness. Gave DistanceThreshold a default value which will always
be checked now.

* Fix issue introduced by merge.

* Use interaction system for determining whether a distance is within range

* Fix incorrect doafter args introduced by previous merge.
Forgor to commit these.

* Exorcise ghost.

The execution system should have been deleted when I merged previously.
For a reason I cannot comprehend it came back, but only the execution
system.

* Exorcise ghost Pt. 2

* Allow for movement check to be overriden in zero g and adjust doafter args where needed.

You can now override checking for movement in zero g with the BreakOnWeightlessMove bool. By default it will check.
The following doafters were made to ignore the movement check in zero g:
- Healing yourself with healing items,
- Removing embedded projectiles,
- Using tools like welders and crowbars

* Adjust distance for cuffing/uncuffing to work. Make injections not break on weightless movement.

* Fix evil incorrect and uneeded comments
This commit is contained in:
nikthechampiongr
2024-03-19 12:09:00 +02:00
committed by GitHub
parent 06b3f273ea
commit 362d56981f
75 changed files with 158 additions and 229 deletions

View File

@@ -55,8 +55,7 @@ public sealed class AccessOverriderSystem : SharedAccessOverriderSystem
var doAfterEventArgs = new DoAfterArgs(EntityManager, args.User, component.DoAfter, new AccessOverriderDoAfterEvent(), uid, target: args.Target, used: uid)
{
BreakOnTargetMove = true,
BreakOnUserMove = true,
BreakOnMove = true,
BreakOnDamage = true,
NeedHand = true,
};

View File

@@ -15,7 +15,7 @@ using Robust.Shared.Timing;
namespace Content.Server.Animals.Systems;
/// <summary>
/// Gives ability to produce milkable reagents, produces endless if the
/// Gives ability to produce milkable reagents, produces endless if the
/// owner has no HungerComponent
/// </summary>
internal sealed class UdderSystem : EntitySystem
@@ -76,9 +76,8 @@ internal sealed class UdderSystem : EntitySystem
var doargs = new DoAfterArgs(EntityManager, userUid, 5, new MilkingDoAfterEvent(), udder, udder, used: containerUid)
{
BreakOnUserMove = true,
BreakOnMove = true,
BreakOnDamage = true,
BreakOnTargetMove = true,
MovementThreshold = 1.0f,
};

View File

@@ -109,9 +109,8 @@ public sealed class InternalsSystem : EntitySystem
_doAfter.TryStartDoAfter(new DoAfterArgs(EntityManager, user, delay, new InternalsDoAfterEvent(), target, target: target)
{
BreakOnUserMove = true,
BreakOnDamage = true,
BreakOnTargetMove = true,
BreakOnMove = true,
MovementThreshold = 0.1f,
});
}

View File

@@ -47,8 +47,7 @@ public sealed class BotanySwabSystem : EntitySystem
_doAfterSystem.TryStartDoAfter(new DoAfterArgs(EntityManager, args.User, swab.SwabDelay, new BotanySwabDoAfterEvent(), uid, target: args.Target, used: uid)
{
Broadcast = true,
BreakOnTargetMove = true,
BreakOnUserMove = true,
BreakOnMove = true,
NeedHand = true
});
}

View File

@@ -205,9 +205,9 @@ public sealed class InjectorSystem : SharedInjectorSystem
DoAfter.TryStartDoAfter(new DoAfterArgs(EntityManager, user, actualDelay, new InjectorDoAfterEvent(), injector.Owner, target: target, used: injector.Owner)
{
BreakOnUserMove = true,
BreakOnMove = true,
BreakOnWeightlessMove = false,
BreakOnDamage = true,
BreakOnTargetMove = true,
NeedHand = true,
BreakOnHandChange = true,
MovementThreshold = 0.1f,

View File

@@ -45,7 +45,7 @@ public sealed class CommsHackerSystem : SharedCommsHackerSystem
var doAfterArgs = new DoAfterArgs(EntityManager, uid, comp.Delay, new TerrorDoAfterEvent(), target: target, used: uid, eventTarget: uid)
{
BreakOnDamage = true,
BreakOnUserMove = true,
BreakOnMove = true,
MovementThreshold = 0.5f,
CancelDuplicate = false
};

View File

@@ -250,8 +250,7 @@ namespace Content.Server.Construction
var doAfterArgs = new DoAfterArgs(EntityManager, user, doAfterTime, new AwaitedDoAfterEvent(), null)
{
BreakOnDamage = true,
BreakOnTargetMove = false,
BreakOnUserMove = true,
BreakOnMove = true,
NeedHand = false,
// allow simultaneously starting several construction jobs using the same stack of materials.
CancelDuplicate = false,

View File

@@ -288,8 +288,7 @@ namespace Content.Server.Construction
var doAfterEventArgs = new DoAfterArgs(EntityManager, interactUsing.User, step.DoAfter, doAfterEv, uid, uid, interactUsing.Used)
{
BreakOnDamage = false,
BreakOnTargetMove = true,
BreakOnUserMove = true,
BreakOnMove = true,
NeedHand = true
};

View File

@@ -174,7 +174,7 @@ public sealed class PartExchangerSystem : EntitySystem
_doAfter.TryStartDoAfter(new DoAfterArgs(EntityManager, args.User, component.ExchangeDuration, new ExchangerDoAfterEvent(), uid, target: args.Target, used: uid)
{
BreakOnDamage = true,
BreakOnUserMove = true
BreakOnMove = true
});
}
}

View File

@@ -512,8 +512,7 @@ public sealed class DisposalUnitSystem : SharedDisposalUnitSystem
var doAfterArgs = new DoAfterArgs(EntityManager, userId.Value, delay, new DisposalDoAfterEvent(), unitId, target: toInsertId, used: unitId)
{
BreakOnDamage = true,
BreakOnTargetMove = true,
BreakOnUserMove = true,
BreakOnMove = true,
NeedHand = false
};

View File

@@ -45,7 +45,7 @@ namespace Content.Server.Engineering.EntitySystems
{
var doAfterArgs = new DoAfterArgs(EntityManager, user, component.DoAfterTime, new AwaitedDoAfterEvent(), null)
{
BreakOnUserMove = true,
BreakOnMove = true,
};
var result = await doAfterSystem.WaitDoAfter(doAfterArgs);

View File

@@ -47,7 +47,7 @@ namespace Content.Server.Engineering.EntitySystems
{
var doAfterArgs = new DoAfterArgs(EntityManager, args.User, component.DoAfterTime, new AwaitedDoAfterEvent(), null)
{
BreakOnUserMove = true,
BreakOnMove = true,
};
var result = await _doAfterSystem.WaitDoAfter(doAfterArgs);

View File

@@ -118,8 +118,7 @@ public sealed partial class EnsnareableSystem
var doAfterEventArgs = new DoAfterArgs(EntityManager, user, freeTime, new EnsnareableDoAfterEvent(), target, target: target, used: ensnare)
{
BreakOnUserMove = breakOnMove,
BreakOnTargetMove = breakOnMove,
BreakOnMove = breakOnMove,
BreakOnDamage = false,
NeedHand = true,
BlockDuplicate = true,

View File

@@ -239,9 +239,8 @@ public sealed class DrainSystem : SharedDrainSystem
var doAfterArgs = new DoAfterArgs(EntityManager, args.User, entity.Comp.UnclogDuration, new DrainDoAfterEvent(), entity, args.Target, args.Used)
{
BreakOnTargetMove = true,
BreakOnUserMove = true,
BreakOnDamage = true,
BreakOnMove = true,
BreakOnHandChange = true
};

View File

@@ -203,9 +203,8 @@ public sealed partial class PuddleSystem
{
_doAfterSystem.TryStartDoAfter(new DoAfterArgs(EntityManager, user, entity.Comp.SpillDelay ?? 0, new SpillDoAfterEvent(), entity.Owner, target: entity.Owner)
{
BreakOnTargetMove = true,
BreakOnUserMove = true,
BreakOnDamage = true,
BreakOnMove = true,
NeedHand = true,
});
};

View File

@@ -83,9 +83,8 @@ namespace Content.Server.Forensics
var doAfterEventArgs = new DoAfterArgs(EntityManager, user, pad.ScanDelay, ev, used, target: target, used: used)
{
BreakOnTargetMove = true,
BreakOnUserMove = true,
NeedHand = true
NeedHand = true,
BreakOnMove = true,
};
_doAfterSystem.TryStartDoAfter(doAfterEventArgs);

View File

@@ -95,8 +95,7 @@ namespace Content.Server.Forensics
{
_doAfterSystem.TryStartDoAfter(new DoAfterArgs(EntityManager, user, component.ScanDelay, new ForensicScannerDoAfterEvent(), uid, target: target, used: uid)
{
BreakOnTargetMove = true,
BreakOnUserMove = true,
BreakOnMove = true,
NeedHand = true
});
}

View File

@@ -116,7 +116,7 @@ namespace Content.Server.Forensics
BreakOnHandChange = true,
NeedHand = true,
BreakOnDamage = true,
BreakOnTargetMove = true,
BreakOnMove = true,
MovementThreshold = 0.01f,
DistanceThreshold = forensicsComp.CleanDistance,
};

View File

@@ -193,11 +193,7 @@ namespace Content.Server.Guardian
return;
}
_doAfterSystem.TryStartDoAfter(new DoAfterArgs(EntityManager, user, component.InjectionDelay, new GuardianCreatorDoAfterEvent(), injector, target: target, used: injector)
{
BreakOnTargetMove = true,
BreakOnUserMove = true
});
_doAfterSystem.TryStartDoAfter(new DoAfterArgs(EntityManager, user, component.InjectionDelay, new GuardianCreatorDoAfterEvent(), injector, target: target, used: injector){BreakOnMove = true});
}
private void OnDoAfter(EntityUid uid, GuardianCreatorComponent component, DoAfterEvent args)

View File

@@ -78,9 +78,8 @@ public sealed partial class ImplanterSystem : SharedImplanterSystem
{
var args = new DoAfterArgs(EntityManager, user, component.ImplantTime, new ImplantEvent(), implanter, target: target, used: implanter)
{
BreakOnUserMove = true,
BreakOnTargetMove = true,
BreakOnDamage = true,
BreakOnMove = true,
NeedHand = true,
};
@@ -105,9 +104,8 @@ public sealed partial class ImplanterSystem : SharedImplanterSystem
{
var args = new DoAfterArgs(EntityManager, user, component.DrawTime, new DrawEvent(), implanter, target: target, used: implanter)
{
BreakOnUserMove = true,
BreakOnTargetMove = true,
BreakOnDamage = true,
BreakOnMove = true,
NeedHand = true,
};

View File

@@ -257,9 +257,8 @@ namespace Content.Server.Kitchen.EntitySystems
var doAfterArgs = new DoAfterArgs(EntityManager, userUid, component.SpikeDelay + butcherable.ButcherDelay, new SpikeDoAfterEvent(), uid, target: victimUid, used: uid)
{
BreakOnTargetMove = true,
BreakOnUserMove = true,
BreakOnDamage = true,
BreakOnMove = true,
NeedHand = true
};

View File

@@ -75,9 +75,8 @@ public sealed class SharpSystem : EntitySystem
var doAfter =
new DoAfterArgs(EntityManager, user, sharp.ButcherDelayModifier * butcher.ButcherDelay, new SharpDoAfterEvent(), knife, target: target, used: knife)
{
BreakOnTargetMove = true,
BreakOnUserMove = true,
BreakOnDamage = true,
BreakOnMove = true,
NeedHand = true
};
_doAfterSystem.TryStartDoAfter(doAfter);

View File

@@ -150,7 +150,7 @@ namespace Content.Server.Light.EntitySystems
// removing a working bulb, so require a delay
_doAfterSystem.TryStartDoAfter(new DoAfterArgs(EntityManager, userUid, light.EjectBulbDelay, new PoweredLightDoAfterEvent(), uid, target: uid)
{
BreakOnUserMove = true,
BreakOnMove = true,
BreakOnDamage = true,
});

View File

@@ -118,9 +118,8 @@ public sealed class MagicSystem : EntitySystem
{
var doAfterEventArgs = new DoAfterArgs(EntityManager, args.User, component.LearnTime, new SpellbookDoAfterEvent(), uid, target: uid)
{
BreakOnTargetMove = true,
BreakOnUserMove = true,
BreakOnDamage = true,
BreakOnMove = true,
NeedHand = true //What, are you going to read with your eyes only??
};

View File

@@ -95,11 +95,9 @@ public sealed class MagicMirrorSystem : EntitySystem
_doAfterSystem.TryStartDoAfter(new DoAfterArgs(EntityManager, user, component.SelectSlotTime, doAfter, uid, target: target, used: uid)
{
DistanceThreshold = SharedInteractionSystem.InteractionRange,
BreakOnTargetMove = true,
BreakOnDamage = true,
BreakOnMove = true,
BreakOnHandChange = false,
BreakOnUserMove = true,
BreakOnWeightlessMove = false,
NeedHand = true
}, out var doAfterId);
@@ -151,11 +149,9 @@ public sealed class MagicMirrorSystem : EntitySystem
_doAfterSystem.TryStartDoAfter(new DoAfterArgs(EntityManager, user, component.ChangeSlotTime, doAfter, uid, target: target, used: uid)
{
BreakOnTargetMove = true,
BreakOnDamage = true,
BreakOnMove = true,
BreakOnHandChange = false,
BreakOnUserMove = true,
BreakOnWeightlessMove = false,
NeedHand = true
}, out var doAfterId);
@@ -206,11 +202,8 @@ public sealed class MagicMirrorSystem : EntitySystem
_doAfterSystem.TryStartDoAfter(new DoAfterArgs(EntityManager, user, component.RemoveSlotTime, doAfter, uid, target: target, used: uid)
{
DistanceThreshold = SharedInteractionSystem.InteractionRange,
BreakOnTargetMove = true,
BreakOnDamage = true,
BreakOnHandChange = false,
BreakOnUserMove = true,
BreakOnWeightlessMove = false,
NeedHand = true
}, out var doAfterId);
@@ -263,11 +256,9 @@ public sealed class MagicMirrorSystem : EntitySystem
_doAfterSystem.TryStartDoAfter(new DoAfterArgs(EntityManager, message.Session.AttachedEntity.Value, component.AddSlotTime, doAfter, uid, target: component.Target.Value, used: uid)
{
BreakOnTargetMove = true,
BreakOnDamage = true,
BreakOnMove = true,
BreakOnHandChange = false,
BreakOnUserMove = true,
BreakOnWeightlessMove = false,
NeedHand = true
}, out var doAfterId);

View File

@@ -157,8 +157,7 @@ public sealed class MechGrabberSystem : EntitySystem
component.AudioStream = _audio.PlayPvs(component.GrabSound, uid).Value.Entity;
var doAfterArgs = new DoAfterArgs(EntityManager, args.User, component.GrabDelay, new GrabberDoAfterEvent(), uid, target: target, used: uid)
{
BreakOnTargetMove = true,
BreakOnUserMove = true
BreakOnMove = true
};
_doAfter.TryStartDoAfter(doAfterArgs, out component.DoAfter);

View File

@@ -47,8 +47,7 @@ public sealed class MechEquipmentSystem : EntitySystem
var doAfterEventArgs = new DoAfterArgs(EntityManager, args.User, component.InstallDuration, new InsertEquipmentEvent(), uid, target: mech, used: uid)
{
BreakOnTargetMove = true,
BreakOnUserMove = true
BreakOnMove = true,
};
_doAfter.TryStartDoAfter(doAfterEventArgs);

View File

@@ -92,10 +92,10 @@ public sealed partial class MechSystem : SharedMechSystem
if (TryComp<ToolComponent>(args.Used, out var tool) && tool.Qualities.Contains("Prying") && component.BatterySlot.ContainedEntity != null)
{
var doAfterEventArgs = new DoAfterArgs(EntityManager, args.User, component.BatteryRemovalDelay, new RemoveBatteryEvent(), uid, target: uid, used: args.Target)
var doAfterEventArgs = new DoAfterArgs(EntityManager, args.User, component.BatteryRemovalDelay,
new RemoveBatteryEvent(), uid, target: uid, used: args.Target)
{
BreakOnTargetMove = true,
BreakOnUserMove = true,
BreakOnMove = true
};
_doAfter.TryStartDoAfter(doAfterEventArgs);
@@ -182,7 +182,7 @@ public sealed partial class MechSystem : SharedMechSystem
{
var doAfterEventArgs = new DoAfterArgs(EntityManager, args.User, component.EntryDelay, new MechEntryEvent(), uid, target: uid)
{
BreakOnUserMove = true,
BreakOnMove = true,
};
_doAfter.TryStartDoAfter(doAfterEventArgs);
@@ -210,11 +210,8 @@ public sealed partial class MechSystem : SharedMechSystem
return;
}
var doAfterEventArgs = new DoAfterArgs(EntityManager, args.User, component.ExitDelay, new MechExitEvent(), uid, target: uid)
{
BreakOnUserMove = true,
BreakOnTargetMove = true,
};
var doAfterEventArgs = new DoAfterArgs(EntityManager, args.User, component.ExitDelay,
new MechExitEvent(), uid, target: uid);
_doAfter.TryStartDoAfter(doAfterEventArgs);
}

View File

@@ -165,9 +165,8 @@ namespace Content.Server.Medical.BiomassReclaimer
var delay = reclaimer.Comp.BaseInsertionDelay * physics.FixturesMass;
_doAfterSystem.TryStartDoAfter(new DoAfterArgs(EntityManager, args.User, delay, new ReclaimerDoAfterEvent(), reclaimer, target: args.Target, used: args.Used)
{
BreakOnTargetMove = true,
BreakOnUserMove = true,
NeedHand = true
NeedHand = true,
BreakOnMove = true
});
}

View File

@@ -142,8 +142,7 @@ public sealed partial class CryoPodSystem : SharedCryoPodSystem
var doAfterArgs = new DoAfterArgs(EntityManager, args.User, entity.Comp.EntryDelay, new CryoPodDragFinished(), entity, target: args.Dragged, used: entity)
{
BreakOnDamage = true,
BreakOnTargetMove = true,
BreakOnUserMove = true,
BreakOnMove = true,
NeedHand = false,
};
_doAfterSystem.TryStartDoAfter(doAfterArgs);

View File

@@ -178,8 +178,6 @@ public sealed class DefibrillatorSystem : EntitySystem
uid, target, uid)
{
BlockDuplicate = true,
BreakOnUserMove = true,
BreakOnTargetMove = true,
BreakOnHandChange = true,
NeedHand = true
});

View File

@@ -196,12 +196,11 @@ public sealed class HealingSystem : EntitySystem
var doAfterEventArgs =
new DoAfterArgs(EntityManager, user, delay, new HealingDoAfterEvent(), target, target: target, used: uid)
{
//Raise the event on the target if it's not self, otherwise raise it on self.
BreakOnUserMove = true,
BreakOnTargetMove = true,
// Didn't break on damage as they may be trying to prevent it and
// not being able to heal your own ticking damage would be frustrating.
NeedHand = true,
BreakOnMove = true,
BreakOnWeightlessMove = false,
};
_doAfter.TryStartDoAfter(doAfterEventArgs);

View File

@@ -76,9 +76,8 @@ public sealed class HealthAnalyzerSystem : EntitySystem
_doAfterSystem.TryStartDoAfter(new DoAfterArgs(EntityManager, args.User, uid.Comp.ScanDelay, new HealthAnalyzerDoAfterEvent(), uid, target: args.Target, used: uid)
{
BreakOnTargetMove = true,
BreakOnUserMove = true,
NeedHand = true
NeedHand = true,
BreakOnMove = true
});
}

View File

@@ -107,9 +107,8 @@ namespace Content.Server.Medical.Stethoscope
{
_doAfterSystem.TryStartDoAfter(new DoAfterArgs(EntityManager, user, comp.Delay, new StethoscopeDoAfterEvent(), scope, target: target, used: scope)
{
BreakOnTargetMove = true,
BreakOnUserMove = true,
NeedHand = true
NeedHand = true,
BreakOnMove = true,
});
}

View File

@@ -50,9 +50,8 @@ public sealed class BatteryDrainerSystem : SharedBatteryDrainerSystem
var doAfterArgs = new DoAfterArgs(EntityManager, uid, comp.DrainTime, new DrainDoAfterEvent(), target: target, eventTarget: uid)
{
BreakOnUserMove = true,
BreakOnWeightlessMove = true, // prevent a ninja on a pod remotely draining it
MovementThreshold = 0.5f,
BreakOnMove = true,
CancelDuplicate = false,
AttemptFrequency = AttemptFrequency.StartAndEnd
};

View File

@@ -591,8 +591,7 @@ public sealed class NukeSystem : EntitySystem
var doAfter = new DoAfterArgs(EntityManager, user, nuke.DisarmDoafterLength, new NukeDisarmDoAfterEvent(), uid, target: uid)
{
BreakOnDamage = true,
BreakOnTargetMove = true,
BreakOnUserMove = true,
BreakOnMove = true,
NeedHand = true
};

View File

@@ -283,9 +283,8 @@ public sealed class DrinkSystem : EntitySystem
target: target,
used: item)
{
BreakOnUserMove = forceDrink,
BreakOnMove = forceDrink,
BreakOnDamage = true,
BreakOnTargetMove = forceDrink,
MovementThreshold = 0.01f,
DistanceThreshold = 1.0f,
// Mice and the like can eat without hands.

View File

@@ -180,9 +180,8 @@ public sealed class FoodSystem : EntitySystem
target: target,
used: food)
{
BreakOnUserMove = forceFeed,
BreakOnMove = forceFeed,
BreakOnDamage = true,
BreakOnTargetMove = forceFeed,
MovementThreshold = 0.01f,
DistanceThreshold = MaxFeedDistance,
// Mice and the like can eat without hands.

View File

@@ -113,8 +113,7 @@ namespace Content.Server.Nutrition.EntitySystems
var vapeDoAfterEvent = new VapeDoAfterEvent(solution, forced);
_doAfterSystem.TryStartDoAfter(new DoAfterArgs(EntityManager, args.User, delay, vapeDoAfterEvent, entity.Owner, target: args.Target, used: entity.Owner)
{
BreakOnTargetMove = true,
BreakOnUserMove = false,
BreakOnMove = false,
BreakOnDamage = true
});
}

View File

@@ -84,7 +84,7 @@ public sealed class PortableGeneratorSystem : SharedPortableGeneratorSystem
_doAfter.TryStartDoAfter(new DoAfterArgs(EntityManager, user, component.StartTime, new GeneratorStartedEvent(), uid, uid)
{
BreakOnDamage = true, BreakOnTargetMove = true, BreakOnUserMove = true, RequireCanInteract = true,
BreakOnDamage = true, BreakOnMove = true, RequireCanInteract = true,
NeedHand = true
});
}

View File

@@ -63,8 +63,7 @@ public sealed class EscapeInventorySystem : EntitySystem
var doAfterEventArgs = new DoAfterArgs(EntityManager, user, component.BaseResistTime * multiplier, new EscapeInventoryEvent(), user, target: container)
{
BreakOnTargetMove = false,
BreakOnUserMove = true,
BreakOnMove = true,
BreakOnDamage = true,
NeedHand = false
};

View File

@@ -47,8 +47,7 @@ public sealed class ResistLockerSystem : EntitySystem
var doAfterEventArgs = new DoAfterArgs(EntityManager, user, resistLockerComponent.ResistTime, new ResistLockerDoAfterEvent(), target, target: target)
{
BreakOnTargetMove = false,
BreakOnUserMove = true,
BreakOnMove = true,
BreakOnDamage = true,
NeedHand = false //No hands 'cause we be kickin'
};

View File

@@ -85,7 +85,7 @@ public sealed partial class RevenantSystem
{
var searchDoAfter = new DoAfterArgs(EntityManager, uid, revenant.SoulSearchDuration, new SoulEvent(), uid, target: target)
{
BreakOnUserMove = true,
BreakOnMove = true,
BreakOnDamage = true,
DistanceThreshold = 2
};
@@ -140,7 +140,7 @@ public sealed partial class RevenantSystem
var doAfter = new DoAfterArgs(EntityManager, uid, revenant.HarvestDebuffs.X, new HarvestEvent(), uid, target: target)
{
DistanceThreshold = 2,
BreakOnUserMove = true,
BreakOnMove = true,
BreakOnDamage = true,
RequireCanInteract = false, // stuns itself
};

View File

@@ -55,8 +55,7 @@ public sealed class SprayPainterSystem : SharedSprayPainterSystem
var doAfterEventArgs = new DoAfterArgs(EntityManager, args.User, painter.PipeSprayTime, new SprayPainterPipeDoAfterEvent(color), args.Used, target: ent, used: args.Used)
{
BreakOnTargetMove = true,
BreakOnUserMove = true,
BreakOnMove = true,
BreakOnDamage = true,
CancelDuplicate = true,
// multiple pipes can be sprayed at once just not the same one

View File

@@ -93,8 +93,7 @@ public sealed class StickySystem : EntitySystem
// start sticking object to target
_doAfterSystem.TryStartDoAfter(new DoAfterArgs(EntityManager, user, delay, new StickyDoAfterEvent(), uid, target: target, used: uid)
{
BreakOnTargetMove = true,
BreakOnUserMove = true,
BreakOnMove = true,
NeedHand = true
});
}
@@ -148,8 +147,7 @@ public sealed class StickySystem : EntitySystem
// start unsticking object
_doAfterSystem.TryStartDoAfter(new DoAfterArgs(EntityManager, user, delay, new StickyDoAfterEvent(), uid, target: uid)
{
BreakOnTargetMove = true,
BreakOnUserMove = true,
BreakOnMove = true,
NeedHand = true
});
}

View File

@@ -262,8 +262,7 @@ namespace Content.Server.Strip
Hidden = stealth,
AttemptFrequency = AttemptFrequency.EveryTick,
BreakOnDamage = true,
BreakOnTargetMove = true,
BreakOnUserMove = true,
BreakOnMove = true,
NeedHand = true,
DuplicateCondition = DuplicateConditions.SameTool
};
@@ -356,8 +355,7 @@ namespace Content.Server.Strip
Hidden = stealth,
AttemptFrequency = AttemptFrequency.EveryTick,
BreakOnDamage = true,
BreakOnTargetMove = true,
BreakOnUserMove = true,
BreakOnMove = true,
NeedHand = true,
BreakOnHandChange = false, // Allow simultaneously removing multiple items.
DuplicateCondition = DuplicateConditions.SameTool
@@ -454,8 +452,7 @@ namespace Content.Server.Strip
Hidden = stealth,
AttemptFrequency = AttemptFrequency.EveryTick,
BreakOnDamage = true,
BreakOnTargetMove = true,
BreakOnUserMove = true,
BreakOnMove = true,
NeedHand = true,
DuplicateCondition = DuplicateConditions.SameTool
};
@@ -554,8 +551,7 @@ namespace Content.Server.Strip
Hidden = stealth,
AttemptFrequency = AttemptFrequency.EveryTick,
BreakOnDamage = true,
BreakOnTargetMove = true,
BreakOnUserMove = true,
BreakOnMove = true,
NeedHand = true,
BreakOnHandChange = false, // Allow simultaneously removing multiple items.
DuplicateCondition = DuplicateConditions.SameTool

View File

@@ -58,7 +58,7 @@ public sealed class HandTeleporterSystem : EntitySystem
var doafterArgs = new DoAfterArgs(EntityManager, args.User, component.PortalCreationDelay, new TeleporterDoAfterEvent(), uid, used: uid)
{
BreakOnDamage = true,
BreakOnUserMove = true,
BreakOnMove = true,
MovementThreshold = 0.5f,
};

View File

@@ -701,7 +701,7 @@ public sealed class WiresSystem : SharedWiresSystem
{
NeedHand = true,
BreakOnDamage = true,
BreakOnUserMove = true
BreakOnMove = true
};
_doAfter.TryStartDoAfter(args);

View File

@@ -45,8 +45,7 @@ public sealed class BurialSystem : EntitySystem
{
var doAfterEventArgs = new DoAfterArgs(EntityManager, args.User, component.DigDelay / shovel.SpeedModifier, new GraveDiggingDoAfterEvent(), uid, target: args.Target, used: uid)
{
BreakOnTargetMove = true,
BreakOnUserMove = true,
BreakOnMove = true,
BreakOnDamage = true,
NeedHand = true,
BreakOnHandChange = true
@@ -159,8 +158,7 @@ public sealed class BurialSystem : EntitySystem
var doAfterEventArgs = new DoAfterArgs(EntityManager, args.Entity, component.DigDelay / component.DigOutByHandModifier, new GraveDiggingDoAfterEvent(), uid, target: uid)
{
NeedHand = false,
BreakOnUserMove = true,
BreakOnTargetMove = false,
BreakOnMove = true,
BreakOnHandChange = false,
BreakOnDamage = false
};

View File

@@ -82,8 +82,7 @@ public sealed partial class BonkSystem : EntitySystem
var doAfterArgs = new DoAfterArgs(EntityManager, args.Dragged, component.BonkDelay, new BonkDoAfterEvent(), uid, target: uid)
{
BreakOnTargetMove = true,
BreakOnUserMove = true,
BreakOnMove = true,
BreakOnDamage = true
};

View File

@@ -211,8 +211,7 @@ public sealed partial class ClimbSystem : VirtualController
target: climbable,
used: entityToMove)
{
BreakOnTargetMove = true,
BreakOnUserMove = true,
BreakOnMove = true,
BreakOnDamage = true
};

View File

@@ -100,7 +100,7 @@ public sealed class ToggleableClothingSystem : EntitySystem
var args = new DoAfterArgs(EntityManager, user, time, new ToggleClothingDoAfterEvent(), item, wearer, item)
{
BreakOnDamage = true,
BreakOnTargetMove = true,
BreakOnMove = true,
// This should just re-use the BUI range checks & cancel the do after if the BUI closes. But that is all
// server-side at the moment.
// TODO BUI REFACTOR.

View File

@@ -479,10 +479,11 @@ namespace Content.Shared.Cuffs
var doAfterEventArgs = new DoAfterArgs(EntityManager, user, cuffTime, new AddCuffDoAfterEvent(), handcuff, target, handcuff)
{
BreakOnTargetMove = true,
BreakOnUserMove = true,
BreakOnMove = true,
BreakOnWeightlessMove = false,
BreakOnDamage = true,
NeedHand = true
NeedHand = true,
DistanceThreshold = 0.3f
};
if (!_doAfter.TryStartDoAfter(doAfterEventArgs))
@@ -574,11 +575,12 @@ namespace Content.Shared.Cuffs
var doAfterEventArgs = new DoAfterArgs(EntityManager, user, uncuffTime, new UnCuffDoAfterEvent(), target, target, cuffsToRemove)
{
BreakOnUserMove = true,
BreakOnTargetMove = true,
BreakOnMove = true,
BreakOnWeightlessMove = false,
BreakOnDamage = true,
NeedHand = true,
RequireCanInteract = false, // Trust in UncuffAttemptEvent
DistanceThreshold = 0.3f
};
if (!_doAfter.TryStartDoAfter(doAfterEventArgs))

View File

@@ -57,8 +57,7 @@ public abstract class SharedDevourSystem : EntitySystem
_doAfterSystem.TryStartDoAfter(new DoAfterArgs(EntityManager, uid, component.DevourTime, new DevourDoAfterEvent(), uid, target: target, used: uid)
{
BreakOnTargetMove = true,
BreakOnUserMove = true,
BreakOnMove = true,
});
break;
default:
@@ -76,8 +75,7 @@ public abstract class SharedDevourSystem : EntitySystem
_doAfterSystem.TryStartDoAfter(new DoAfterArgs(EntityManager, uid, component.StructureDevourTime, new DevourDoAfterEvent(), uid, target: target, used: uid)
{
BreakOnTargetMove = true,
BreakOnUserMove = true,
BreakOnMove = true,
});
}
}

View File

@@ -82,12 +82,6 @@ public sealed partial class DoAfter
{
Index = index;
if (args.Target == null)
{
DebugTools.Assert(!args.BreakOnTargetMove);
args.BreakOnTargetMove = false;
}
Args = args;
StartTime = startTime;
}

View File

@@ -92,29 +92,23 @@ public sealed partial class DoAfterArgs
public bool BreakOnHandChange = true;
/// <summary>
/// If do_after stops when the user moves
/// If do_after stops when the user or target moves
/// </summary>
[DataField("breakOnUserMove")]
public bool BreakOnUserMove;
[DataField]
public bool BreakOnMove;
/// <summary>
/// If this is true then any movement, even when weightless, will break the doafter.
/// When there is no gravity, BreakOnUserMove is ignored. If it is false to begin with nothing will change.
/// Whether to break on movement when the user is weightless.
/// This does nothing if <see cref="BreakOnMove"/> is false.
/// </summary>
[DataField("breakOnWeightlessMove")]
public bool BreakOnWeightlessMove;
/// <summary>
/// If do_after stops when the target moves (if there is a target)
/// </summary>
[DataField("breakOnTargetMove")]
public bool BreakOnTargetMove;
[DataField]
public bool BreakOnWeightlessMove = true;
/// <summary>
/// Threshold for user and target movement
/// </summary>
[DataField("movementThreshold")]
public float MovementThreshold = 0.1f;
public float MovementThreshold = 0.3f;
/// <summary>
/// Threshold for distance user from the used OR target entities.
@@ -250,9 +244,8 @@ public sealed partial class DoAfterArgs
Broadcast = other.Broadcast;
NeedHand = other.NeedHand;
BreakOnHandChange = other.BreakOnHandChange;
BreakOnUserMove = other.BreakOnUserMove;
BreakOnMove = other.BreakOnMove;
BreakOnWeightlessMove = other.BreakOnWeightlessMove;
BreakOnTargetMove = other.BreakOnTargetMove;
MovementThreshold = other.MovementThreshold;
DistanceThreshold = other.DistanceThreshold;
BreakOnDamage = other.BreakOnDamage;

View File

@@ -1,5 +1,7 @@
using Content.Shared.Gravity;
using Content.Shared.Hands.Components;
using Content.Shared.Interaction;
using Content.Shared.Physics;
using Robust.Shared.Utility;
namespace Content.Shared.DoAfter;
@@ -8,6 +10,7 @@ public abstract partial class SharedDoAfterSystem : EntitySystem
{
[Dependency] private readonly IDynamicTypeFactory _factory = default!;
[Dependency] private readonly SharedGravitySystem _gravity = default!;
[Dependency] private readonly SharedInteractionSystem _interaction = default!;
private DoAfter[] _doAfters = Array.Empty<DoAfter>();
@@ -163,24 +166,53 @@ public abstract partial class SharedDoAfterSystem : EntitySystem
return true;
// TODO: Re-use existing xform query for these calculations.
// when there is no gravity you will be drifting 99% of the time making many doafters impossible
// so this just ignores your movement if you are weightless (unless the doafter sets BreakOnWeightlessMove then moving will still break it)
if (args.BreakOnUserMove
&& !userXform.Coordinates.InRange(EntityManager, _transform, doAfter.UserPosition, args.MovementThreshold)
&& (args.BreakOnWeightlessMove || !_gravity.IsWeightless(args.User, xform: userXform)))
return true;
if (args.BreakOnTargetMove)
if (args.BreakOnMove && !(!args.BreakOnWeightlessMove && _gravity.IsWeightless(args.User, xform: userXform)))
{
DebugTools.Assert(targetXform != null, "Break on move is true, but no target specified?");
if (targetXform != null && targetXform.Coordinates.TryDistance(EntityManager, userXform.Coordinates, out var distance))
// Whether the user has moved too much from their original position.
if (!userXform.Coordinates.InRange(EntityManager, _transform, doAfter.UserPosition, args.MovementThreshold))
return true;
// Whether the distance between the user and target(if any) has changed too much.
if (targetXform != null &&
targetXform.Coordinates.TryDistance(EntityManager, userXform.Coordinates, out var distance))
{
// once the target moves too far from you the do after breaks
if (Math.Abs(distance - doAfter.TargetDistance) > args.MovementThreshold)
return true;
}
}
// Whether the user and the target are too far apart.
if (args.Target != null)
{
if (args.DistanceThreshold != null)
{
if (!_interaction.InRangeUnobstructed(args.User, args.Target.Value, args.DistanceThreshold.Value))
return true;
}
else
{
if (!_interaction.InRangeUnobstructed(args.User, args.Target.Value))
return true;
}
}
// Whether the distance between the tool and the user has grown too much.
if (args.Used != null)
{
if (args.DistanceThreshold != null)
{
if (!_interaction.InRangeUnobstructed(args.User,
args.Used.Value,
args.DistanceThreshold.Value))
return true;
}
else
{
if (!_interaction.InRangeUnobstructed(args.User,args.Used.Value))
return true;
}
}
if (args.AttemptFrequency == AttemptFrequency.EveryTick && !TryAttemptEvent(doAfter))
return true;
@@ -199,23 +231,6 @@ public abstract partial class SharedDoAfterSystem : EntitySystem
if (args.RequireCanInteract && !_actionBlocker.CanInteract(args.User, args.Target))
return true;
if (args.DistanceThreshold != null)
{
if (targetXform != null
&& !args.User.Equals(args.Target)
&& !userXform.Coordinates.InRange(EntityManager, _transform, targetXform.Coordinates,
args.DistanceThreshold.Value))
{
return true;
}
if (usedXform != null
&& !userXform.Coordinates.InRange(EntityManager, _transform, usedXform.Coordinates,
args.DistanceThreshold.Value))
{
return true;
}
}
return false;
}

View File

@@ -214,12 +214,11 @@ public abstract partial class SharedDoAfterSystem : EntitySystem
args.NetUser = GetNetEntity(args.User);
args.NetEventTarget = GetNetEntity(args.EventTarget);
if (args.BreakOnUserMove || args.BreakOnTargetMove)
if (args.BreakOnMove)
doAfter.UserPosition = Transform(args.User).Coordinates;
if (args.Target != null && args.BreakOnTargetMove)
if (args.Target != null && args.BreakOnMove)
{
// Target should never be null if the bool is set.
var targetPosition = Transform(args.Target.Value).Coordinates;
doAfter.UserPosition.TryDistance(EntityManager, targetPosition, out doAfter.TargetDistance);
}

View File

@@ -168,8 +168,7 @@ public abstract partial class InventorySystem
{
BlockDuplicate = true,
BreakOnHandChange = true,
BreakOnUserMove = true,
BreakOnTargetMove = true,
BreakOnMove = true,
CancelDuplicate = true,
RequireCanInteract = true,
NeedHand = true
@@ -414,8 +413,7 @@ public abstract partial class InventorySystem
{
BlockDuplicate = true,
BreakOnHandChange = true,
BreakOnUserMove = true,
BreakOnTargetMove = true,
BreakOnMove = true,
CancelDuplicate = true,
RequireCanInteract = true,
NeedHand = true

View File

@@ -111,7 +111,7 @@ public sealed class LockSystem : EntitySystem
return _doAfter.TryStartDoAfter(
new DoAfterArgs(EntityManager, user, lockComp.LockTime, new LockDoAfter(), uid, uid)
{
BreakOnDamage = true, BreakOnTargetMove = true, BreakOnUserMove = true, RequireCanInteract = true,
BreakOnDamage = true, BreakOnMove = true, RequireCanInteract = true,
NeedHand = true
});
}
@@ -187,7 +187,7 @@ public sealed class LockSystem : EntitySystem
return _doAfter.TryStartDoAfter(
new DoAfterArgs(EntityManager, user, lockComp.LockTime, new UnlockDoAfter(), uid, uid)
{
BreakOnDamage = true, BreakOnTargetMove = true, BreakOnUserMove = true, RequireCanInteract = true,
BreakOnDamage = true, BreakOnMove = true, RequireCanInteract = true,
NeedHand = true
});
}

View File

@@ -434,7 +434,7 @@ public abstract class SharedMechSystem : EntitySystem
var doAfterEventArgs = new DoAfterArgs(EntityManager, args.Dragged, component.EntryDelay, new MechEntryEvent(), uid, target: uid)
{
BreakOnUserMove = true,
BreakOnMove = true,
};
_doAfter.TryStartDoAfter(doAfterEventArgs);

View File

@@ -53,10 +53,7 @@ public abstract partial class SharedProjectileSystem : EntitySystem
args.Handled = true;
_doAfter.TryStartDoAfter(new DoAfterArgs(EntityManager, args.User, component.RemovalTime.Value,
new RemoveEmbeddedProjectileEvent(), eventTarget: uid, target: uid)
{
DistanceThreshold = SharedInteractionSystem.InteractionRange,
});
new RemoveEmbeddedProjectileEvent(), eventTarget: uid, target: uid));
}
private void OnEmbedRemove(EntityUid uid, EmbeddableProjectileComponent component, RemoveEmbeddedProjectileEvent args)

View File

@@ -136,8 +136,7 @@ public sealed class PryingSystem : EntitySystem
var doAfterArgs = new DoAfterArgs(EntityManager, user, TimeSpan.FromSeconds(modEv.BaseTime * modEv.PryTimeModifier / toolModifier), new DoorPryDoAfterEvent(), target, target, tool)
{
BreakOnDamage = true,
BreakOnUserMove = true,
BreakOnWeightlessMove = true,
BreakOnMove = true,
};
if (tool != null)

View File

@@ -104,8 +104,7 @@ public sealed class RCDSystem : EntitySystem
BreakOnDamage = true,
NeedHand = true,
BreakOnHandChange = true,
BreakOnUserMove = true,
BreakOnTargetMove = args.Target != null,
BreakOnMove = true,
AttemptFrequency = AttemptFrequency.EveryTick
};

View File

@@ -119,7 +119,7 @@ public abstract class SharedRatKingSystem : EntitySystem
{
BlockDuplicate = true,
BreakOnDamage = true,
BreakOnUserMove = true,
BreakOnMove = true,
DistanceThreshold = 2f
});
}

View File

@@ -46,8 +46,8 @@ public abstract class SharedResearchStealerSystem : EntitySystem
var doAfterArgs = new DoAfterArgs(EntityManager, uid, comp.Delay, new ResearchStealDoAfterEvent(), target: target, used: uid, eventTarget: uid)
{
BreakOnDamage = true,
BreakOnUserMove = true,
MovementThreshold = 0.5f
BreakOnMove = true,
MovementThreshold = 0.5f,
};
_doAfter.TryStartDoAfter(doAfterArgs);

View File

@@ -153,8 +153,7 @@ public abstract partial class SharedFultonSystem : EntitySystem
{
CancelDuplicate = true,
MovementThreshold = 0.5f,
BreakOnUserMove = true,
BreakOnTargetMove = true,
BreakOnMove = true,
Broadcast = true,
NeedHand = true,
});

View File

@@ -61,7 +61,7 @@ public abstract partial class SharedSericultureSystem : EntitySystem
var doAfter = new DoAfterArgs(EntityManager, uid, comp.ProductionLength, new SericultureDoAfterEvent(), uid)
{ // I'm not sure if more things should be put here, but imo ideally it should probably be set in the component/YAML. Not sure if this is currently possible.
BreakOnUserMove = true,
BreakOnMove = true,
BlockDuplicate = true,
BreakOnDamage = true,
CancelDuplicate = true,

View File

@@ -69,7 +69,7 @@ public sealed partial class ReformSystem : EntitySystem
// Create a doafter & start it
var doAfter = new DoAfterArgs(EntityManager, uid, comp.ReformTime, new ReformDoAfterEvent(), uid)
{
BreakOnUserMove = true,
BreakOnMove = true,
BlockDuplicate = true,
BreakOnDamage = true,
CancelDuplicate = true,
@@ -89,7 +89,7 @@ public sealed partial class ReformSystem : EntitySystem
return;
// Spawn a new entity
// This is, to an extent, taken from polymorph. I don't use polymorph for various reasons- most notably that this is permanent.
// This is, to an extent, taken from polymorph. I don't use polymorph for various reasons- most notably that this is permanent.
var child = Spawn(comp.ReformPrototype, Transform(uid).Coordinates);
// This transfers the mind to the new entity
@@ -105,7 +105,7 @@ public sealed partial class ReformSystem : EntitySystem
_actionsSystem.RemoveAction(uid, comp.ActionEntity); // Zombies can't reform
}
public sealed partial class ReformEvent : InstantActionEvent { }
public sealed partial class ReformEvent : InstantActionEvent { }
[Serializable, NetSerializable]
public sealed partial class ReformDoAfterEvent : SimpleDoAfterEvent { }

View File

@@ -134,8 +134,7 @@ public abstract class SharedSprayPainterSystem : EntitySystem
var doAfterEventArgs = new DoAfterArgs(EntityManager, args.User, painter.AirlockSprayTime, new SprayPainterDoorDoAfterEvent(sprite, style.Department), args.Used, target: ent, used: args.Used)
{
BreakOnTargetMove = true,
BreakOnUserMove = true,
BreakOnMove = true,
BreakOnDamage = true,
NeedHand = true
};

View File

@@ -133,8 +133,7 @@ public sealed class DumpableSystem : EntitySystem
_doAfterSystem.TryStartDoAfter(new DoAfterArgs(EntityManager, userUid, delay, new DumpableDoAfterEvent(), storageUid, target: targetUid, used: storageUid)
{
BreakOnTargetMove = true,
BreakOnUserMove = true,
BreakOnMove = true,
NeedHand = true
});
}

View File

@@ -289,7 +289,7 @@ public abstract class SharedStorageSystem : EntitySystem
var doAfterArgs = new DoAfterArgs(EntityManager, args.User, delay, new AreaPickupDoAfterEvent(GetNetEntityList(validStorables)), uid, target: uid)
{
BreakOnDamage = true,
BreakOnUserMove = true,
BreakOnMove = true,
NeedHand = true
};

View File

@@ -124,8 +124,8 @@ public abstract partial class SharedToolSystem : EntitySystem
var doAfterArgs = new DoAfterArgs(EntityManager, user, delay / toolComponent.SpeedModifier, toolEvent, tool, target: target, used: tool)
{
BreakOnDamage = true,
BreakOnTargetMove = true,
BreakOnUserMove = true,
BreakOnMove = true,
BreakOnWeightlessMove = false,
NeedHand = tool != user,
AttemptFrequency = IsWelder(tool) ? AttemptFrequency.EveryTick : AttemptFrequency.Never
};

View File

@@ -70,8 +70,7 @@ public abstract partial class SharedVendingMachineSystem
var doAfterArgs = new DoAfterArgs(EntityManager, args.User, (float) component.RestockDelay.TotalSeconds, new RestockDoAfterEvent(), target,
target: target, used: uid)
{
BreakOnTargetMove = true,
BreakOnUserMove = true,
BreakOnMove = true,
BreakOnDamage = true,
NeedHand = true
};

View File

@@ -74,8 +74,7 @@ public abstract partial class SharedGunSystem
_doAfter.TryStartDoAfter(new DoAfterArgs(EntityManager, args.User, component.FillDelay, new AmmoFillDoAfterEvent(), used: uid, target: args.Target, eventTarget: uid)
{
BreakOnTargetMove = true,
BreakOnUserMove = true,
BreakOnMove = true,
BreakOnDamage = false,
NeedHand = true
});