* fixing access levels and removed strings from data defs * Fixing proximity detector performance - Re-added component filtering for the close entity search. - Changed criteria functionality to only allow for searching for entities with all specified comps (matching any would be too unperformant)
222 lines
8.4 KiB
C#
222 lines
8.4 KiB
C#
using Content.Shared.ProximityDetection.Components;
|
|
using Content.Shared.Tag;
|
|
using Robust.Shared.Network;
|
|
|
|
namespace Content.Shared.ProximityDetection.Systems;
|
|
|
|
|
|
//This handles generic proximity detector logic
|
|
public sealed class ProximityDetectionSystem : EntitySystem
|
|
{
|
|
[Dependency] private readonly EntityLookupSystem _entityLookup = default!;
|
|
[Dependency] private readonly SharedTransformSystem _transform = default!;
|
|
[Dependency] private readonly TagSystem _tagSystem = default!;
|
|
[Dependency] private readonly INetManager _net = default!;
|
|
|
|
//update is only run on the server
|
|
|
|
public override void Initialize()
|
|
{
|
|
SubscribeLocalEvent<ProximityDetectorComponent, EntityPausedEvent>(OnPaused);
|
|
SubscribeLocalEvent<ProximityDetectorComponent, EntityUnpausedEvent>(OnUnpaused);
|
|
SubscribeLocalEvent<ProximityDetectorComponent, ComponentInit>(OnCompInit);
|
|
|
|
}
|
|
|
|
private void OnCompInit(EntityUid uid, ProximityDetectorComponent component, ComponentInit args)
|
|
{
|
|
if (component.Criteria.RequireAll)
|
|
return;
|
|
Log.Debug("DetectorComponent only supports requireAll = false for tags. All components are required for a match!");
|
|
}
|
|
|
|
private void OnPaused(EntityUid owner, ProximityDetectorComponent component, EntityPausedEvent args)
|
|
{
|
|
SetEnable_Internal(owner,component,false);
|
|
}
|
|
|
|
private void OnUnpaused(EntityUid owner, ProximityDetectorComponent detector, ref EntityUnpausedEvent args)
|
|
{
|
|
SetEnable_Internal(owner, detector,true);
|
|
}
|
|
public void SetEnable(EntityUid owner, bool enabled, ProximityDetectorComponent? detector = null)
|
|
{
|
|
if (!Resolve(owner, ref detector) || detector.Enabled == enabled)
|
|
return;
|
|
SetEnable_Internal(owner ,detector, enabled);
|
|
}
|
|
|
|
public override void Update(float frameTime)
|
|
{
|
|
if (_net.IsClient)
|
|
return;
|
|
var query = EntityQueryEnumerator<ProximityDetectorComponent>();
|
|
while (query.MoveNext(out var owner, out var detector))
|
|
{
|
|
if (!detector.Enabled)
|
|
continue;
|
|
detector.AccumulatedFrameTime += frameTime;
|
|
if (detector.AccumulatedFrameTime < detector.UpdateRate)
|
|
continue;
|
|
detector.AccumulatedFrameTime -= detector.UpdateRate;
|
|
RunUpdate_Internal(owner, detector);
|
|
}
|
|
}
|
|
|
|
public bool GetEnable(EntityUid owner, ProximityDetectorComponent? detector = null)
|
|
{
|
|
return Resolve(owner, ref detector, false) && detector.Enabled;
|
|
}
|
|
|
|
private void SetEnable_Internal(EntityUid owner,ProximityDetectorComponent detector, bool enabled)
|
|
{
|
|
detector.Enabled = enabled;
|
|
var noDetectEvent = new ProximityTargetUpdatedEvent(detector, detector.TargetEnt, detector.Distance);
|
|
RaiseLocalEvent(owner, ref noDetectEvent);
|
|
if (!enabled)
|
|
{
|
|
detector.AccumulatedFrameTime = 0;
|
|
RunUpdate_Internal(owner, detector);
|
|
Dirty(owner, detector);
|
|
return;
|
|
}
|
|
RunUpdate_Internal(owner, detector);
|
|
}
|
|
|
|
public void ForceUpdate(EntityUid owner, ProximityDetectorComponent? detector = null)
|
|
{
|
|
if (!Resolve(owner, ref detector))
|
|
return;
|
|
RunUpdate_Internal(owner, detector);
|
|
}
|
|
|
|
|
|
private void RunUpdate_Internal(EntityUid owner,ProximityDetectorComponent detector)
|
|
{
|
|
if (!_net.IsServer) //only run detection checks on the server!
|
|
return;
|
|
var xformQuery = GetEntityQuery<TransformComponent>();
|
|
var xform = xformQuery.GetComponent(owner);
|
|
List<(EntityUid TargetEnt, float Distance)> detections = new();
|
|
|
|
if (detector.Criteria.Components == null)
|
|
{
|
|
Log.Error($"ProximityDetectorComponent on {ToPrettyString(owner)} must use at least 1 component as a filter in criteria!");
|
|
throw new ArgumentException($"ProximityDetectorComponent on {ToPrettyString(owner)} must use at least 1 component as a filter in criteria!");
|
|
}
|
|
var firstCompType = EntityManager.ComponentFactory.GetRegistration(detector.Criteria.Components[0]).Type;
|
|
var foundEnts = _entityLookup.GetEntitiesInRange(firstCompType,_transform.GetMapCoordinates(owner, xform), detector.Range.Float());
|
|
|
|
var tagSearchEnabled = detector.Criteria.Tags is {Count: > 0};
|
|
|
|
CheckForAllComponentsPresent(detector, ref foundEnts, tagSearchEnabled);
|
|
|
|
if (foundEnts.Count == 0)
|
|
{
|
|
UpdateTargetFromClosest(owner, detector, detections);
|
|
return;
|
|
}
|
|
|
|
foreach (var ent in foundEnts)
|
|
{
|
|
if (tagSearchEnabled && ent.Comp is TagComponent tags && (detector.Criteria.RequireAll
|
|
? _tagSystem.HasAllTags(tags, detector.Criteria.Tags!)
|
|
: _tagSystem.HasAnyTag(tags, detector.Criteria.Tags!)))
|
|
continue;
|
|
var distance = (_transform.GetWorldPosition(xform, xformQuery) - _transform.GetWorldPosition(ent, xformQuery)).Length();
|
|
if (CheckDetectConditions(ent, distance, owner, detector))
|
|
{
|
|
detections.Add((ent, distance));
|
|
}
|
|
}
|
|
UpdateTargetFromClosest(owner, detector, detections);
|
|
}
|
|
|
|
private void CheckForAllComponentsPresent(ProximityDetectorComponent detector, ref HashSet<Entity<IComponent>> foundEnts, bool tagSearchEnabled)
|
|
{
|
|
var validEnts = new HashSet<Entity<IComponent>>(foundEnts.Count);
|
|
for (var i = 1; i < detector.Criteria.Components!.Length; i++)
|
|
{
|
|
validEnts.Clear();
|
|
var compType = EntityManager.ComponentFactory.GetRegistration(detector.Criteria.Components[i]).Type;
|
|
foreach (var ent in foundEnts)
|
|
{
|
|
if (!HasComp(ent, compType))
|
|
continue;
|
|
validEnts.Add(ent);
|
|
}
|
|
(foundEnts, validEnts) = (validEnts, foundEnts);
|
|
}
|
|
validEnts.Clear();
|
|
if (tagSearchEnabled)
|
|
{
|
|
foreach (var ent in foundEnts)
|
|
{
|
|
if (!HasComp<TagComponent>(ent))
|
|
continue;
|
|
validEnts.Add(ent);
|
|
}
|
|
(foundEnts, validEnts) = (validEnts, foundEnts);
|
|
validEnts.Clear();
|
|
}
|
|
}
|
|
|
|
|
|
private bool CheckDetectConditions(EntityUid targetEntity, float dist, EntityUid owner, ProximityDetectorComponent detector)
|
|
{
|
|
var detectAttempt = new ProximityDetectionAttemptEvent(false, dist, (owner, detector));
|
|
RaiseLocalEvent(targetEntity, ref detectAttempt);
|
|
return !detectAttempt.Cancel;
|
|
}
|
|
|
|
private void UpdateTargetFromClosest(EntityUid owner, ProximityDetectorComponent detector, List<(EntityUid TargetEnt, float Distance)> detections)
|
|
{
|
|
if (detections.Count == 0)
|
|
{
|
|
if (detector.TargetEnt == null)
|
|
return;
|
|
detector.Distance = -1;
|
|
detector.TargetEnt = null;
|
|
var noDetectEvent = new ProximityTargetUpdatedEvent(detector, null, -1);
|
|
RaiseLocalEvent(owner, ref noDetectEvent);
|
|
var newTargetEvent = new NewProximityTargetEvent(detector, null);
|
|
RaiseLocalEvent(owner, ref newTargetEvent);
|
|
Dirty(owner, detector);
|
|
return;
|
|
}
|
|
var closestDistance = detections[0].Distance;
|
|
EntityUid closestEnt = default!;
|
|
foreach (var (ent,dist) in detections)
|
|
{
|
|
if (dist >= closestDistance)
|
|
continue;
|
|
closestEnt = ent;
|
|
closestDistance = dist;
|
|
}
|
|
|
|
var newTarget = detector.TargetEnt != closestEnt;
|
|
var newData = newTarget || detector.Distance != closestDistance;
|
|
detector.TargetEnt = closestEnt;
|
|
detector.Distance = closestDistance;
|
|
if (newTarget)
|
|
{
|
|
var newTargetEvent = new NewProximityTargetEvent(detector, closestEnt);
|
|
RaiseLocalEvent(owner, ref newTargetEvent);
|
|
}
|
|
|
|
if (!newData)
|
|
return;
|
|
var targetUpdatedEvent = new ProximityTargetUpdatedEvent(detector, closestEnt, closestDistance);
|
|
RaiseLocalEvent(owner, ref targetUpdatedEvent);
|
|
Dirty(owner, detector);
|
|
}
|
|
|
|
public void SetRange(EntityUid owner, float newRange, ProximityDetectorComponent? detector = null)
|
|
{
|
|
if (!Resolve(owner, ref detector))
|
|
return;
|
|
detector.Range = newRange;
|
|
Dirty(owner, detector);
|
|
}
|
|
}
|