0c97520276
* Fix usages of TryIndex()
Most usages of TryIndex() were using it incorrectly. Checking whether prototype IDs specified in prototypes actually existed before using them. This is not appropriate as it's just hiding bugs that should be getting caught by the YAML linter and other tools. (#39115)
This then resulted in TryIndex() getting modified to log errors (94f98073b0), which is incorrect as it causes false-positive errors in proper uses of the API: external data validation. (#39098)
This commit goes through and checks every call site of TryIndex() to see whether they were correct. Most call sites were replaced with the new Resolve(), which is suitable for these "defensive programming" use cases.
Fixes #39115
Breaking change: while doing this I noticed IdCardComponent and related systems were erroneously using ProtoId<AccessLevelPrototype> for job prototypes. This has been corrected.
* fix tests
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
102 lines
2.9 KiB
C#
102 lines
2.9 KiB
C#
using Content.Shared.Audio.Jukebox;
|
|
using Robust.Client.Audio;
|
|
using Robust.Client.UserInterface;
|
|
using Robust.Shared.Audio.Components;
|
|
using Robust.Shared.Prototypes;
|
|
|
|
namespace Content.Client.Audio.Jukebox;
|
|
|
|
public sealed class JukeboxBoundUserInterface : BoundUserInterface
|
|
{
|
|
[Dependency] private readonly IPrototypeManager _protoManager = default!;
|
|
|
|
[ViewVariables]
|
|
private JukeboxMenu? _menu;
|
|
|
|
public JukeboxBoundUserInterface(EntityUid owner, Enum uiKey) : base(owner, uiKey)
|
|
{
|
|
IoCManager.InjectDependencies(this);
|
|
}
|
|
|
|
protected override void Open()
|
|
{
|
|
base.Open();
|
|
|
|
_menu = this.CreateWindow<JukeboxMenu>();
|
|
|
|
_menu.OnPlayPressed += args =>
|
|
{
|
|
if (args)
|
|
{
|
|
SendMessage(new JukeboxPlayingMessage());
|
|
}
|
|
else
|
|
{
|
|
SendMessage(new JukeboxPauseMessage());
|
|
}
|
|
};
|
|
|
|
_menu.OnStopPressed += () =>
|
|
{
|
|
SendMessage(new JukeboxStopMessage());
|
|
};
|
|
|
|
_menu.OnSongSelected += SelectSong;
|
|
|
|
_menu.SetTime += SetTime;
|
|
PopulateMusic();
|
|
Reload();
|
|
}
|
|
|
|
/// <summary>
|
|
/// Reloads the attached menu if it exists.
|
|
/// </summary>
|
|
public void Reload()
|
|
{
|
|
if (_menu == null || !EntMan.TryGetComponent(Owner, out JukeboxComponent? jukebox))
|
|
return;
|
|
|
|
_menu.SetAudioStream(jukebox.AudioStream);
|
|
|
|
if (_protoManager.Resolve(jukebox.SelectedSongId, out var songProto))
|
|
{
|
|
var length = EntMan.System<AudioSystem>().GetAudioLength(songProto.Path.Path.ToString());
|
|
_menu.SetSelectedSong(songProto.Name, (float) length.TotalSeconds);
|
|
}
|
|
else
|
|
{
|
|
_menu.SetSelectedSong(string.Empty, 0f);
|
|
}
|
|
}
|
|
|
|
public void PopulateMusic()
|
|
{
|
|
_menu?.Populate(_protoManager.EnumeratePrototypes<JukeboxPrototype>());
|
|
}
|
|
|
|
public void SelectSong(ProtoId<JukeboxPrototype> songid)
|
|
{
|
|
SendMessage(new JukeboxSelectedMessage(songid));
|
|
}
|
|
|
|
public void SetTime(float time)
|
|
{
|
|
var sentTime = time;
|
|
|
|
// You may be wondering, what the fuck is this
|
|
// Well we want to be able to predict the playback slider change, of which there are many ways to do it
|
|
// We can't just use SendPredictedMessage because it will reset every tick and audio updates every frame
|
|
// so it will go BRRRRT
|
|
// Using ping gets us close enough that it SHOULD, MOST OF THE TIME, fall within the 0.1 second tolerance
|
|
// that's still on engine so our playback position never gets corrected.
|
|
if (EntMan.TryGetComponent(Owner, out JukeboxComponent? jukebox) &&
|
|
EntMan.TryGetComponent(jukebox.AudioStream, out AudioComponent? audioComp))
|
|
{
|
|
audioComp.PlaybackPosition = time;
|
|
}
|
|
|
|
SendMessage(new JukeboxSetTimeMessage(sentTime));
|
|
}
|
|
}
|
|
|