0c97520276
* Fix usages of TryIndex()
Most usages of TryIndex() were using it incorrectly. Checking whether prototype IDs specified in prototypes actually existed before using them. This is not appropriate as it's just hiding bugs that should be getting caught by the YAML linter and other tools. (#39115)
This then resulted in TryIndex() getting modified to log errors (94f98073b0), which is incorrect as it causes false-positive errors in proper uses of the API: external data validation. (#39098)
This commit goes through and checks every call site of TryIndex() to see whether they were correct. Most call sites were replaced with the new Resolve(), which is suitable for these "defensive programming" use cases.
Fixes #39115
Breaking change: while doing this I noticed IdCardComponent and related systems were erroneously using ProtoId<AccessLevelPrototype> for job prototypes. This has been corrected.
* fix tests
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
40 lines
1.2 KiB
C#
40 lines
1.2 KiB
C#
using System.Linq;
|
|
using Content.Server.Administration;
|
|
using Content.Server.Polymorph.Systems;
|
|
using Content.Shared.Administration;
|
|
using Content.Shared.Polymorph;
|
|
using Robust.Shared.Prototypes;
|
|
using Robust.Shared.Toolshed;
|
|
|
|
namespace Content.Server.Polymorph.Toolshed;
|
|
|
|
/// <summary>
|
|
/// Polymorphs the given entity(s) into the target morph.
|
|
/// </summary>
|
|
[ToolshedCommand, AdminCommand(AdminFlags.Fun)]
|
|
public sealed class PolymorphCommand : ToolshedCommand
|
|
{
|
|
private PolymorphSystem? _system;
|
|
[Dependency] private IPrototypeManager _proto = default!;
|
|
|
|
[CommandImplementation]
|
|
public EntityUid? Polymorph(
|
|
[PipedArgument] EntityUid input,
|
|
ProtoId<PolymorphPrototype> protoId
|
|
)
|
|
{
|
|
_system ??= GetSys<PolymorphSystem>();
|
|
|
|
var prototype = _proto.Index(protoId);
|
|
|
|
return _system.PolymorphEntity(input, prototype.Configuration);
|
|
}
|
|
|
|
[CommandImplementation]
|
|
public IEnumerable<EntityUid> Polymorph(
|
|
[PipedArgument] IEnumerable<EntityUid> input,
|
|
ProtoId<PolymorphPrototype> protoId
|
|
)
|
|
=> input.Select(x => Polymorph(x, protoId)).Where(x => x is not null).Select(x => (EntityUid)x!);
|
|
}
|