One of these was going to have to be folded into the other for it to work.
I am starting to really hate this refactor.
Note that this might still leave smokable tampering broken if it was already broken, but it shouldn't break it if it wasn't.
TESTED: Grown apples, carrots, something I forgot, bananas, *client crash due to slipping*
* Work on DeviceNetworkSystem
* Implement device networking as ecs
Remove mailing unit code for now
Remove device network metadata
* Implement integration tests for device networking
* Remove manual updating DeviceNetworkSystem and use WaitRunTicks
* Fix wrong component name in ignored components
* Apply suggestions from code review
Co-authored-by: mirrorcult <notzombiedude@gmail.com>
* Rename NetworkUtils to DeviceNetworkConstants
Change connection type constants to enum
Remove create function from network payload class
* Change broken nodegroup check in wirenet to grid check
* Change ComponentManager to entity manager in DeviceNetworkSystem
* Fix smaller mistakes
* Wtf random test fail pls run them again smh
* Fix DataField in DeviceNetworkComponent
* Fix yaml in DeviceNetworkTest
* Fix DeviceNetworkComponent DeviceNetId property
Co-authored-by: Julian Giebel <j.giebel@netrocks.info>
Co-authored-by: mirrorcult <notzombiedude@gmail.com>
* Graft from https://github.com/space-wizards/space-station-14/pull/3049
* 'openahelp' command
* Add AHelp into escape menu
* Add a way to ahelp a player from the kick window
* bwoink: XAMLify, bugfix, etc.
* Rename the kick/bwoink window the Player Actions Panel
* Add the bwoink sound y'all know and love
adminhelp.ogg taken from d775e1ac80/sound/effects/adminhelp.ogg
(available in master, therefore see master license: "All assets including icons and sound are under a Creative Commons 3.0 BY-SA license unless otherwise indicated.")
"Changed the adminhelpsound to some creative commons sound I pinched. Until somebody can get a better one. I'm sick of MAAAAAAAAOOOOOOW."
Actual source is https://freesound.org/people/martian/sounds/19261/ (CC0)
The sound had been reversed and the volume altered.
* Actually play the bwoink sound on receiving an ahelp that you didn't send
* Migrate lots of pulling logic out of the components and clean it up
* It's buggy, but move more code out of the pullable component
* Pulling system now throws less errors than it did before the refactor
* Finally finish the big parts of refactoring pullability
* Pulling: Handle disconnect properly if the pull joint has been removed by physics shutdown
* Port 2b68449328 to this branch
* Changes as per PR reviews
* Port e801ffac45 (SharedJointSystem) and fix issues encountered during testing
SharedJointSystem.
Also, MinLength and Stiffness appear to have suddenly gained enough meaning that pulling is broken unless they're set.
* Update UI when the AME node group is changed (fixes core count indicator being wrong)
* Fix connection issues between AME controller and cores
* Fix#4365 by properly propagating and clearing AME core injection state
* Fixes#4364
* temp
* #3898 some progress on DrinkCanVisualizer
* Fixed implementation
* Moved drink can sprite layer definition to abstract parent
* Added open drink can sprites
* #3898 - fixes for drink cans' sprite field after merge + moved UpdateAppeareance from DrinkComponent to DrinkSystem
* Update Content.Server/Nutrition/EntitySystems/DrinkSystem.cs
* #3898 removed obsolete comment
Co-authored-by: Javier Guardia Fernández <DrSmugleaf@users.noreply.github.com>
