tommy/tbd-station-14
2
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
23,806 Commits 3 Branches 5 Tags
c35ff87e146f0cda7c10782f4ab80b784b51e5fe
Commit Graph

74 Commits

Author SHA1 Message Date
Pieter-Jan Briers
68ce53ae17 Random spontaneous cleanup PR (#25131) 
* Use new Subs.CVar helper

Removes manual config OnValueChanged calls, removes need to remember to manually unsubscribe.

This both reduces boilerplate and fixes many issues where subscriptions weren't removed on entity system shutdown.

* Fix a bunch of warnings

* More warning fixes

* Use new DateTime serializer to get rid of ISerializationHooks in changelog code.

* Get rid of some more ISerializationHooks for enums

* And a little more

* Apply suggestions from code review

Co-authored-by: 0x6273 <0x40@keemail.me>

---------

Co-authored-by: 0x6273 <0x40@keemail.me>
 2024-02-13 16:48:39 -05:00
Hannah Giovanna Dawson
1defdebd7b Fix MIDI Loading Failing Whilst a MIDI is playing (#23339) 
SS14-1148 Fix MIDI Loading Failing Whilst a MIDI is playing

The behaviour of the button event handling did some wonky
async handling that got PJB swearing repeatedly in the contributor
VC.

Improve switching MIDI songs by:

0. Add a bool that tracks if we're currently waiting for the MIDI file
browser to terminate. Use this bool to short-circuit the
MidiFileButtonOnPressed function, ensuring you don't have to close
a morbillion file windows if you spam-clicked the  button or forgot
you'd opened the window.
1. Remove a four-year-old hack involving waiting 100ms to load a MIDI
after trying to stop the last MIDI, because _the rot consumes_ or some shit
 2024-01-04 13:19:22 +11:00
metalgearsloth
7ada1c6674 Update content to new ParallelManager (#21813) 2023-11-29 11:00:12 +11:00
Kara
dbb7c7065a Kill ContainerHelpers (#20908) 2023-10-11 20:18:49 +11:00
metalgearsloth
fd60d39bc7 Remove instruments compref (#19560) 2023-09-12 14:43:06 +10:00
metalgearsloth
5a0fc68be2 Content update for NetEntities (#18935) 2023-09-11 09:42:41 +10:00
DrSmugleaf
35107f7c2b Fix component generic usages where IComponent would not be valid (#19482) 2023-08-24 20:10:55 +10:00
DrSmugleaf
a88e747a0b Refactor serialization copying to use source generators (#19412) 2023-08-22 18:14:33 -07:00
Vera Aguilera Puerto
a2893dd6c3 Instrument band support, submodule update to 138.0.0 (#17995) 2023-07-16 21:12:53 +02:00
TemporalOroboros
3ac4cf85db Cleaner BoundUserInterfaces (#17736) 2023-07-09 02:02:17 +10:00
metalgearsloth
68480af109 Update content vectors to numerics (#17759) 2023-07-08 14:08:32 +10:00
metalgearsloth
a0332c2f2e Don't spawn midi timer for inactive instruments (#14300) 2023-03-24 13:47:38 +11:00
Visne
c6d3e4f3bd Fix warnings and code cleanup/fixes (#13570) 2023-01-19 13:56:45 +11:00
DrSmugleaf
7fbc2608e8 Remove redundant read-only VV from datafields (#12626) 2022-11-16 20:22:11 +01:00
Leon Friedrich
94011ca2b1 Misc changes from replay branch (#12581) 2022-11-15 17:34:47 +11:00
Morb
d1ff0687e4 Localize MIDI menu (#11819) 2022-10-15 13:40:07 -07:00
Leon Friedrich
921e2ee57d BUI changes required for Engine PR (#10608) 2022-08-21 03:38:30 +10:00
metalgearsloth
45bd1edd5b Revert "Update submodule to 0.34.0.0 (#10356)" (#10359) 2022-08-06 16:48:21 +10:00
Leon Friedrich
e06ea56eb2 Content BUI changes for engine PR (#10308) 2022-08-06 14:59:02 +10:00
Andreas Kämper
5a6cc0933b Allow pAIs to play MIDI again (#9921) 2022-07-20 18:08:33 +02:00
Leon Friedrich
6b4c2e9b40 Add more instrument interaction checks (#9223) 2022-06-27 18:09:21 +10:00
Vera Aguilera Puerto
1bc599b683 MIDI bank is set after the MIDI program 
Fixes bug regarding incorrect program for the first few notes of some MIDI tracks.
 2022-04-09 15:32:25 +02:00
Vera Aguilera Puerto
6e73e94cc6 Fix instruments for engine changes, fixes program change bug. (#7365) 2022-04-08 16:22:05 +02:00
metalgearsloth
563d4f4cbd Don't log on midi resolve failure (#6819) 2022-02-20 21:38:42 -07:00
Leon Friedrich
4a00d01ced Remove ignore-inside-blocker (#6692) 
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
 2022-02-16 19:40:03 -07:00
mirrorcult
ec4d4688c7 Seal/abstract/virtual everything (#6739) 2022-02-16 18:23:23 +11:00
wrexbe
cea1b21832 Fixing some warnings (#6250) 
Co-authored-by: Paul Ritter <ritter.paul1@googlemail.com>
 2022-01-21 10:38:35 +01:00
Pieter-Jan Briers
a0af197259 Set outside prediction flags on system/inputs to work without prediction. 
This needs to be gone through more thoroughly but it works somewhat.
 2021-12-30 03:12:04 +01:00
Vera Aguilera Puerto
e9c812c29c Use Timer.Spawn instead of TimerComp timers when disposing MIDI Renderers. 
- Fixes a bug where renderers are not disposed of correctly when the instrument entity is deleted.
 2021-12-18 00:30:29 +01:00
metalgearsloth
8af335097f More (IComponent) shenanigans and also some contaminated IoCManager.Resolve<IEntityManager>() very long yes calls 2021-12-07 22:22:34 +11:00
DrSmugleaf
af4eb3c7cd Fix more errors, client and server now build 2021-12-06 14:00:39 +01:00
DrSmugleaf
2a3b7d809d Fix 3000 errors 2021-12-05 18:09:01 +01:00
Vera Aguilera Puerto
f386b57148 Inline OwnerUid 2021-12-03 16:30:34 +01:00
Vera Aguilera Puerto
5cd42c9ad6 Inline UID 2021-12-03 15:53:09 +01:00
Vera Aguilera Puerto
ee4ff9cfe8 Inline Name 2021-12-03 15:25:51 +01:00
Vera Aguilera Puerto
69b270017b Inline TryGetComponent completely, for real 2021-12-03 14:17:01 +01:00
Leon Friedrich
7b59a205b8 check if instrument window is disposed before playing (#5655) 2021-12-02 11:51:30 +01:00
20kdc
b5c5871453 Fix a bunch of returns where they should not be (#5640) 2021-12-01 15:00:10 +01:00
Vera Aguilera Puerto
47a19f94d4 Make instruments ECS (#5516) 2021-11-28 01:47:36 +01:00
20kdc
efc200cbd8 More informative warning for if FluidSynth is not installed (#4971) 2021-10-29 12:20:49 +02:00
Visne
c67160ae19 Disable warnings that would be refactored anyway (#5047) 2021-10-27 18:10:40 +02:00
Vera Aguilera Puerto
0be5ff829b Gets rid of all ComponentManager usages. (#4707) 2021-09-28 13:35:29 +02:00
Visne
bf493c39b7 Replace most VBox/HBoxContainers with BoxContainers (#4274) 2021-07-18 18:39:31 +02:00
Vera Aguilera Puerto
d8bfb7c054 Instrument checks connection status before sending stop component message. 2021-07-11 11:07:16 +02:00
Acruid
15fb554c28 Engine Entity Anchoring Changes (#4195) 
* Converted all SnapGridPositionChangedEvent subscriptions to AnchorStateChangedEvent.

* Fixes power tests with new anchored requirements.

* Moved AnchorableComponent into construction.
AnchorableComponent now uses Transform.Anchored.

* Fixed bug with nodes, power works again.

* Adds lifetime stages to Component.

* Update Engine to v0.4.70.
 2021-06-19 19:41:26 -07:00
DrSmugleaf
f878f353e4 Move some files out of Content.Shared root because I forgot (#4182) 2021-06-13 22:52:40 +10:00
DrSmugleaf
ff1a2d97ea Re-organize all projects (#4166) 2021-06-09 22:19:39 +02:00
Acruid
3e7e44df29 Removed Control.Update, moved all update code to Control.FrameUpdate. UI controls have no business running code inside simulation Ticks. Because of how the update loop is ordered, this will actually make the UI elements more responsive to simulation changes. 
Fixed multiple bugs in the action UI where the Control.Update method was calling the base Control.FrameUpdate.
 2021-03-26 17:10:31 -07:00
Vera Aguilera Puerto
c30c60efc4 Fixes structure instruments not playing due to a nullability moment 2021-03-13 02:46:32 +01:00
DrSmugleaf
902aa128c2 Enable nullability in Content.Client (#3257) 
* Enable nullability in Content.Client

* Remove #nullable enable

* Merge fixes

* Remove Debug.Assert

* Merge fixes

* Fix build

* Fix build
 2021-03-10 14:48:29 +01:00