* Fix usages of TryIndex()
Most usages of TryIndex() were using it incorrectly. Checking whether prototype IDs specified in prototypes actually existed before using them. This is not appropriate as it's just hiding bugs that should be getting caught by the YAML linter and other tools. (#39115)
This then resulted in TryIndex() getting modified to log errors (94f98073b0), which is incorrect as it causes false-positive errors in proper uses of the API: external data validation. (#39098)
This commit goes through and checks every call site of TryIndex() to see whether they were correct. Most call sites were replaced with the new Resolve(), which is suitable for these "defensive programming" use cases.
Fixes#39115
Breaking change: while doing this I noticed IdCardComponent and related systems were erroneously using ProtoId<AccessLevelPrototype> for job prototypes. This has been corrected.
* fix tests
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* spectra
* documentation
* added into liquid anomaly
* Update TemporaryStealthComponent.cs
* Update TemporaryStealthComponent.cs
* integrated
* new system
* mark old status effect system as obsolete
* ForcedSleeping new status effect
* work with reagents
* networking???
* Revert "integrated"
This reverts commit bca02b82bae18ae131af593d7eb86e6de2745157.
* Revert "Update TemporaryStealthComponent.cs"
This reverts commit 4a5be8c4b704a0d1ff9544b2e245d8b2701ec580.
* Revert "Update TemporaryStealthComponent.cs"
This reverts commit a4875bcb41347638854bd723d96a51c3e6d38034.
* Revert "added into liquid anomaly"
This reverts commit df5086b14bb35f1467158a36807c0f2163a16d99.
* Revert "documentation"
This reverts commit 3629b9466758cbdfa4dd5e67ece122fa2f181138.
* Revert "spectra"
This reverts commit 2d03d88c16d16ad6831c19a7921b84600daeb284.
* drowsiness status effect remove
* reagents work
* polish, remove test changes
* first Fildrance review part
* Update misc.yml
* more fildrance review
* final part
* fix trailing spaces
* sleeping status effect
* drowsiness status effect
* Create ModifyStatusEffect.cs
* some tweak
* Yay!!! Manual networking
* minor nitpick
* oopsie
* refactor: xml-docs, notnullwhen attributes, whitespaces
* fildrance and emo review
* refactor: simplify check in SharedStatusEffectsSystem by using pattern matching, TryEffectsWithComp now returns set of Entity<T, StatusEffectComponent>
---------
Co-authored-by: pa.pecherskij <pa.pecherskij@interfax.ru>
* cloning refactor
* cleanup and fixes
* don't pick from 0
* give dwarves the correct species
* fix dna and bloodstream reagent data cloning
* don't copy helmets
* be less redundant
* Make UnrevivableComponent shared
- Move UnrevivableComponent to shared
- add reason messages and if the status shows up in a health analyzer
* Update Content.Shared/Traits/Assorted/UnrevivableComponent.cs
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
* Make UnrevivableComponent networked
* Update Content.Shared/Traits/Assorted/UnrevivableComponent.cs
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
---------
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Replaced uses of Dirty(Component) with Dirty(Uid, Component)
Modified some systems (notably pulling-related) to use uids.
* Missed a few
* Revert changes to pulling
* No
* Remove netsync
* Replace OnStartup with OnMapInit
* Dont remove component
* Remove component ensure
* Remove using
* Cancel all moving or stand events
* Fix description
* Revert "Replace OnStartup with OnMapInit"
This reverts commit 5b7470d0dfa7a7c127dec6a06534b339f140ffac.
* Remove stand events cancel
* Init commit
* move to shared and remove all from component
* maybe that
* Use SharedBuckleSystem
* Rename to WheelchairBound
* Move Carriage to prototype
* Update sprite to TG, add folded sprite, rename carriage to wheelchair
* Fix wheelchair rsi path
* Add stand & down for buckling
* Add wheelchair inhand sprites
* Move wheelchair down in file & fix fold sprite & add suffix Vehicle
* Use new wheelchair id
* Add standing & speed reset on component remove
* Split system to leg paralyzed and wheelchair bound
* Rename to LegsParalyzed
* Rename in prototype
* Move LegsParalyzed to shared
---------
Co-authored-by: Ray <vigersray@gmail.com>
* Fix dead mobs sneezing and coughing
* SneezeCough update
* Streamlined Event code, moved dead-check
* cleanup
* I can has merge?
* Shared event for SharedMobStateSystem
* start work
* blindness actually works now
* doc
* doc you too.
* i desire to sneeze my lungs out
* no punchie
* s
Co-authored-by: moonheart08 <moonheart08@users.noreply.github.com>
