tommy/tbd-station-14
2
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
34,017 Commits 3 Branches 5 Tags
c19cdad7871c3ebe64cb73e757be6cd9f7fd937f
Commit Graph

209 Commits

Author SHA1 Message Date
Errant
b692b6e33e Antag Rolebans (#35966) 
Co-authored-by: beck-thompson <beck314159@hotmail.com>
Co-authored-by: Hannah Giovanna Dawson <karakkaraz@gmail.com>
 2025-09-17 23:59:07 +02:00
Pieter-Jan Briers
0c97520276 Fix usages of TryIndex() (#39124) 
* Fix usages of TryIndex()

Most usages of TryIndex() were using it incorrectly. Checking whether prototype IDs specified in prototypes actually existed before using them. This is not appropriate as it's just hiding bugs that should be getting caught by the YAML linter and other tools. (#39115)

This then resulted in TryIndex() getting modified to log errors (94f98073b0), which is incorrect as it causes false-positive errors in proper uses of the API: external data validation. (#39098)

This commit goes through and checks every call site of TryIndex() to see whether they were correct. Most call sites were replaced with the new Resolve(), which is suitable for these "defensive programming" use cases.

Fixes #39115

Breaking change: while doing this I noticed IdCardComponent and related systems were erroneously using ProtoId<AccessLevelPrototype> for job prototypes. This has been corrected.

* fix tests

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
 2025-09-09 18:17:56 +02:00
slarticodefast
2743dcf67f Move mind role components to shared (#39606) 2025-08-13 12:51:46 +02:00
Kyle Tyo
d4c025567a Predict warp point location examines. (#39402) 
commit
 2025-08-05 20:26:41 +02:00
Kyle Tyo
83b3e9e15a Localize makesentient command. Move makesentient method to mind system. (#38565) 
* praying pjb doesn't smite me for this 🙏

* requested changes

* Update makesentient-command.ftl

* verin commith and verin taketh away
 2025-07-23 14:29:46 +02:00
Quantum-cross
989338cb08 Fix lingering ghost roles (and expand tests to catch it) (#38788) 
* Improve and expand `TakeRoleAndReturn` to fail on bug #38292

* fix #38292 and expanded test cases

* use validated EntProtoIds for tests

remove unusued using declarations

* use const strings that match the TestPrototypes
 2025-07-09 13:07:41 +02:00
Tayrtahn
f09bade8e7 Validate remaining ProtoId strings (#38747) 
Validate remaining ProtoId strings
 2025-07-04 22:55:45 +02:00
Tayrtahn
75db49f9c0 Clean up all missing EntitySystem proxy method uses (#38353) 2025-06-26 16:50:49 -07:00
keronshb
0a394d4af5 Wizard Teleport Scroll (Teleport Location ECS) (#36424) 2025-04-28 19:42:24 +02:00
Tayrtahn
6d88dd910d Modernize GhostComponent & Ghost API (#36858) 
* Move CanReturnToBody to system

* Move CanGhostInteract to system

* Cleanup redundant datafields and viewvariables

* Document datafields

* Document component

* Add SetTimeOfDeath Entity<T> overload, obsolete old version

* Document public methods

* Cleanup obsoleted method calls
 2025-04-23 20:28:10 +02:00
Milon
3fc9bcbbbe remove Session from MindComponent (#34753) 
* yummy

* fix tests
 2025-04-19 00:23:01 +02:00
J
22639a3cdf Ghost spring cleaning (#36194) 
* Ghost warnings cleanup

* Undo incorrect changes

* Removing whitespace
 2025-04-14 22:12:04 +02:00
J
af9526197a Extracts magic strings from Tag calls (#36305) 
* Extracts magic strings from Tag calls

When #36281 gets merged, the `TagSystem` methods will all give warnings. Let's fix those warnings before they even happen!

* Adds missing libraries

* Remove not yet implemented TagSystem changes

* Fix tag spelling error

Genuinely surprised there was only 1!

* Styling and proper type changes

* Styling

Co-authored-by: Tayrtahn <tayrtahn@gmail.com>

---------

Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
 2025-04-04 20:20:19 -04:00
slarticodefast
9ff43f344e Show paradox clones in deadchat (#35940) 
show clones in deadchat
 2025-03-26 16:30:14 +01:00
metalgearsloth
9292e3a43c Sloth's subfloor vismask adventure (#35347) 
* Add a subfloor vismask

Significantly cuts down on sent entity count.

* More optimisations

* Fix command

* Fixes

* namespace cleanup

* Review

* Vismasks

* Content update

* Bandaid

* awewa

* Revert these

* reh

* Update Content.Shared/SubFloor/TrayScannerComponent.cs

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
 2025-03-21 00:57:04 +11:00
Tayrtahn
86aa82f2b6 Cleanup: Remove redundant prototype name specifications (#35793) 
* Remove redundant prototype name specifications

* These can stay
 2025-03-19 19:30:31 +01:00
slarticodefast
531f5619be add forceghost admin command (#35518) 
* add forceghost admin command

* sweep linq under the rug

* braces

* ûse LocalizedEntityCommands
 2025-03-08 13:39:04 +11:00
Tayrtahn
6f925dd610 Fix prototypes so they pass analyzer checks (#35435) 2025-02-24 15:21:59 +11:00
keronshb
7bf33ffaa9 Wizard Fix - Summon Ghost Event no longer shows Admin Ghosts or Revenants (#34994) 
* Prevents admin ghosts from being shown with ghost event

* Changes summon ghost tooltip to permanently visible

* Adds AllowGhostShownByEvent tag, adds it to regular observers, removes ghost hands check & revenant check and replaces it with a tag check.
 2025-02-16 21:29:10 +01:00
SpaceManiac
4122310735 Fix 38 non-obsolete warnings (#33794) 2025-02-11 20:59:50 +11:00
Errant
46d58bf22a Role Types (#33420) 
* mindcomponent namespace

* wip MindRole stuff

* admin player tab

* mindroletype comment

* mindRolePrototype redesign

* broken param

* wip RoleType implementation

* basic role type switching for antags

* traitor fix

* fix AdminPanel update

* the renameningTM

* cleanup

* feature uncreeping

* roletypes on mind roles

* update MindComponent.RoleType when MindRoles change

* ghostrole configuration

* ghostrole config improvements

* live update of roleType on the character window

* logging stuff and notes

* remove thing no one asked for

* weh

* Mind Role Entities wip

* headrev count fix

* silicon stuff, cleanup

* exclusive antag config, cleanup

* jobroleadd overwerite

* logging stuff

* MindHasRole cleanup, admin log stuff

* last second cleanup

* ocd

* move roletypeprototype to its own file, minor note stuff

* remove Roletype.Created

* log stuff

* roletype setup for ghostroles and autotraitor reinforcements

* ghostrole type configs

* adjustable admin overlay

* cleanup

* fix this in its own PR

* silicon antagonist

* borg stuff

* mmi roletype handling

* spawnable borg roletype handling

* weh

* ghost role cleanup

* weh

* RoleEvent update

* polish

* log stuff

* admin overlay config

* ghostrolecomponent cleanup

* weh

* admin overlay code cleanup

* minor cleanup

* Obsolete MindRoleAddedEvent

* comment

* minor code cleanup

* MindOnDoGreeting fix

* Role update message

* fix duplicate job greeting for cyborgs

* fix emag job message dupe

* nicer-looking role type update

* crew aligned

* syndicate assault borg role fix

* fix test fail

* fix a merge mistake

* fix LoneOp role type

* Update Content.Client/Administration/AdminNameOverlay.cs

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Update Content.Shared/Roles/SharedRoleSystem.cs

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* comment formatting

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* change logging category

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* fix a space

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* use MindAddRoles

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* get MindComponent from TryGetMind

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* move var declaration outside loop

* remove TryComp

* take RoleEnum behind the barn

* don't use ensurecomp unnecessarily

* cvar comments

* toggleableghostrolecomponent documentation

* skrek

* use EntProtoId

* mindrole config

* merge baserolecomponent into basemindrolecomponent

* ai and borg silicon role tweaks

* formatting

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* I will end you (the color)

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* use LocId type for a locale id

* update RoleEvent documentation

* update RoleEvent documentation

* remove obsolete MindRoleAddedEvent

* refine MindRolesUpdate()

* use dependency

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* inject dependency

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* roleType.Name no longer required

* reformatted draw code logic

* GhostRoleMarkerRoleComponent comment

* minor SharedRoleSystem cleanup

* StartingMindRoleComponent, unhardcode roundstart silicon

* Update Content.Shared/Roles/SharedRoleSystem.cs

* remove a whitespace

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
 2025-01-11 22:17:26 +01:00
Tayrtahn
c6e4d19883 Let ghosts sometimes make certain devices say creepy things (#34368) 
* Add SpookySpeaker component/system

* Shuffle Boo action targets before trying to activate them

* Add SpookySpeaker to vending machines

* Fix chatcode eating messages starting with "..."

* Add SpookySpeaker to recycler

* Oops

* Decrease speak probability for vending machines

* Add spooky speaker to arcade machines
 2025-01-11 03:48:13 +01:00
Tayrtahn
fdc0853053 Add a popup message when ghost Boo action does nothing (#34369) 2025-01-10 23:57:46 +01:00
lzk
18322ec76f fix ghost command error string (#33838) 2024-12-12 11:18:53 -05:00
Token
061b1b8adb Fix makeghostroleraffle command where 4 arguments (#31836) 
Fix makeghostroleraffle command with 4 arguments
 2024-11-30 21:11:44 +01:00
DrSmugleaf
3ad227a904 Add admin log for ghost warping (#33636) 2024-11-29 10:46:24 +01:00
Schrödinger
f53e3ec3c1 [BUGFIX] "Ghost" in the lobby lets you see the whole chat (#33529) 
* fix bug, in ghost command lobby

* fix

* Fix build
 2024-11-25 10:20:31 +03:00
lzk
dc3a2f6d28 add StartDelay bool to actions (#33026) 
* add StartDelay bool to actions

* forgot summary
 2024-10-28 23:21:14 +01:00
Leon Friedrich
4e0018697f Add role prototype validation tests (#32801) 
* Add role prototype validation test

* Rejig GetPrototypesWithComponent

* More tests n stuff
 2024-10-14 14:05:25 +11:00
Errant
93c7bdc134 Mind Role Entities (#31318) 
* Mind Role Entities wip

* headrev count fix

* silicon stuff, cleanup

* exclusive antag config, cleanup

* jobroleadd overwerite

* logging stuff

* MindHasRole cleanup, admin log stuff

* last second cleanup

* ocd

* minor cleanup

* remove createdTime datafield

* now actually using the event replacement I made for role time tracking

* weh
 2024-10-10 10:48:56 +02:00
nikthechampiongr
a5840b925b Fix RA0032 (#32514) 2024-09-29 02:25:21 +02:00
poeMota
9a51d37d02 Add ERT time stats (#31629) 
* add jobs for ghost roles

* add job to ToggleableGhostRole

* typo

---------

Co-authored-by: Mota <belochuc@gmail.com>
 2024-09-02 10:32:49 +05:00
nikthechampiongr
99db9ea39d Fix suicide logs (#31661) 
Make suicide logs include the username, as well as the character(where possible)
 2024-08-31 18:26:52 +10:00
Winkarst
2d85b4e7e9 Move OnGhostAttempt to GhostSystem (#31445) 
* Move OnGhostAttempt to GhostSystem

* Remove unused dependencies and sort them
 2024-08-26 14:15:33 +02:00
Errant
40b9fd4ea3 Namespace cleanup around Mind Roles (#30965) 
* namespaces

* Comment does not need a semicolon

---------

Co-authored-by: Vasilis <vascreeper@yahoo.com>
 2024-08-15 20:26:57 +02:00
Errant
9de922adba development build ghostrole lottery changes (#30980) 
debug ghostrole lottery changes
 2024-08-14 11:57:09 +10:00
Plykiya
e6b67540e4 Update MoverController.cs to not use Component.Owner (#29965) 
* Update MoverController.cs

* Update a bunch of movement code to use Entity<T>

* Last errors

* wow, there were more errors

---------

Co-authored-by: plykiya <plykiya@protonmail.com>
 2024-08-02 11:32:32 +10:00
Scribbles0
7381df4335 Handless mobs can no longer wipe devices (#30149) 
add check for hands
 2024-07-23 10:47:07 -07:00
Plykiya
aded74a88a Syndicate Reinforcement Specializations: Medic, Spy, Thief (#29853) 
* Syndicate thief, spy, medic

* Fixes description for nukies

* update description for uplink

* Implement the radial menu

* forgot these were necessary to push lol

---------

Co-authored-by: plykiya <plykiya@protonmail.com>
 2024-07-21 20:32:25 +10:00
metalgearsloth
03f0257ae9 Revert "Picking a ghostrole as an admin will now deadmin you. (#29790)" (#29901) 
This reverts commit 1a50760e67.
 2024-07-11 17:04:10 +10:00
MFMessage
1a50760e67 Picking a ghostrole as an admin will now deadmin you. (#29790) 
* @forcibly deadmins you

* Added checks for AdminDeadminOnJoin
 2024-07-11 15:53:14 +10:00
lzk
58d46ddd46 Fix GhostCommand naming (#29671) 2024-07-03 10:01:17 +10:00
TsjipTsjip
949a837720 Ghostrole rule updates (#29249) 
* First batch of ghostrole rule updates

* Second pass

* Re-word free agent

* Apply review comments

Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com>

* You heard it here first folks

God rules are weird to write.

Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com>

* Honkbot -> Free Agent

Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com>

* Mimebot -> Free Agent

Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com>

* Jonkbot -> Free Agent

Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com>

* Softer blue

---------

Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com>
 2024-06-21 04:41:54 -05:00
Leon Friedrich
b632a65385 Add JobRequirementOverride prototypes (#28607) 
* Add JobRequirementOverride prototypes

* a

* invert if

* Add override that takes in prototypes directly
 2024-06-07 09:43:02 -07:00
Plykiya
41549db282 Remove obsolete VisibilitySystem functions (#28610) 
Remove obsolete visibility functions

Co-authored-by: plykiya <plykiya@protonmail.com>
 2024-06-05 17:04:31 +10:00
Leon Friedrich
6235fa1ac6 Content changes for entity categories PR (#27232) 
* Content changes for entity categories PR

* Poke tests

* Why are tests suddenly working?
 2024-06-02 14:08:15 +10:00
Tayrtahn
8995810ade Fix non-ghosts and admins counting toward most followed (#28120) 
* Fixed non-ghosts and admins counting toward most followed

* Redone to better leverage EntityQueryEnumerator

* Remember to test your code before you commit it, kids

* Review revisions

* Update Content.Shared/Follower/FollowerSystem.cs

Co-authored-by: ShadowCommander <shadowjjt@gmail.com>

* Update Content.Shared/Follower/FollowerSystem.cs

Co-authored-by: ShadowCommander <shadowjjt@gmail.com>

* Update Content.Shared/Follower/FollowerSystem.cs

* Clean up

---------

Co-authored-by: ShadowCommander <shadowjjt@gmail.com>
Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>
 2024-05-20 07:12:05 -07:00
Tayrtahn
fa06783986 Prevent ghosts from spawning on terminating maps/grids (#28099) 
* Extra checks to prevent ghosts spawning on terminating maps/grids

* Add test for grid deletion
 2024-05-20 06:52:49 -07:00
Kara
993eef1e7c Resolve 'EntitySystem.Get<T>()' is obsolete in content (#27936) 
* PROJECT 0 WARNINGS: Resolve `'EntitySystem.Get<T>()' is obsolete` in content

* pass entman

* dog ass test

* webeditor
 2024-05-12 20:34:52 -04:00
no
37099e481e Prevent admin-frozen players from ghosting or suiciding, add "Freeze And Mute" verb (#27813) 
* prevent admin-frozen players from ghosting or suiciding

* Add "Freeze and Mute" admin verb

* Allow "Freeze And Mute" admin verb when player is already frozen but not muted

* Remove redundant scream handler (scream action just emotes, duh)

* AdminFrozenSystem: clean imports

* Update Content.Server/Chat/Commands/SuicideCommand.cs

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>

* Update Ghost.cs

* retrigger ci (empty commit)

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
 2024-05-12 10:35:30 -04:00