Commit Graph

2716 Commits

Author SHA1 Message Date
20kdc
2a8486a384 Pullability partial ECS refactor, monkey-gibbing error fix (#4695)
* Migrate lots of pulling logic out of the components and clean it up

* It's buggy, but move more code out of the pullable component

* Pulling system now throws less errors than it did before the refactor

* Finally finish the big parts of refactoring pullability

* Pulling: Handle disconnect properly if the pull joint has been removed by physics shutdown

* Port 2b68449328 to this branch

* Changes as per PR reviews

* Port e801ffac45 (SharedJointSystem) and fix issues encountered during testing

SharedJointSystem.

Also, MinLength and Stiffness appear to have suddenly gained enough meaning that pulling is broken unless they're set.
2021-10-04 17:10:54 +02:00
20kdc
ecbf8621a7 Make radiation storms occur at least somewhat near the station (Revision 3: LocalBounds) (#4745)
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2021-10-03 18:26:45 -07:00
20kdc
2b67a22485 Stop casting AME energy into int because it underflows. (#4762) 2021-10-03 17:58:54 -07:00
metalgearsloth
c8193ef393 Fix master 2021-10-04 01:29:50 +11:00
Vera Aguilera Puerto
3e2a8738a9 PopupSystem now uses Filter methods for getting players from entities. (#4751) 2021-10-03 16:15:15 +02:00
Paul Ritter
6fdb364497 Admin overlay (#4728)
* adds admin overlay

* fixes things
2021-10-03 13:34:36 +02:00
20kdc
b114f4a523 Update UI when the AME node group is changed, fix AME connection issues (#4750)
* Update UI when the AME node group is changed (fixes core count indicator being wrong)

* Fix connection issues between AME controller and cores

* Fix #4365 by properly propagating and clearing AME core injection state

* Fixes #4364
2021-10-03 13:33:28 +02:00
Galactic Chimp
61f1c8a05c #3898 open sprite field for drink comp (#4235)
* temp

* #3898 some progress on DrinkCanVisualizer

* Fixed implementation

* Moved drink can sprite layer definition to abstract parent

* Added open drink can sprites

* #3898 - fixes for drink cans' sprite field after merge + moved UpdateAppeareance from DrinkComponent to DrinkSystem

* Update Content.Server/Nutrition/EntitySystems/DrinkSystem.cs

* #3898 removed obsolete comment

Co-authored-by: Javier Guardia Fernández <DrSmugleaf@users.noreply.github.com>
2021-10-03 15:56:29 +11:00
20kdc
bae033d6c3 Ghosts are now spawned specifically via map coordinates (#4747)
Ought to fix #3987 and ghost blackscreen
2021-10-03 15:51:23 +11:00
metalgearsloth
734bfb4fad Fix meteorswarm 2021-10-03 15:31:03 +11:00
Alex Evgrashin
e5df8dbee3 Moving PDA to ECS (#4538)
* Moved pen slot to separate component

* Moved it all to more generic item slot class

* Add sounds

* Item slots now supports many slots

* Some clean-up

* Refactored slots a bit

* Moving ID card out

* Moving pda to system

* Moving PDA owner to ECS

* Moved PDA flashlight to separate component

* Toggle lights work through events

* Fixing UI

* Moving uplink to separate component

* Continue moving uplink to separate component

* More cleaning

* Removing pda shared

* Nuked shared pda component

* Fixed flashlight

* Pen slot now showed in UI

* Light toggle now shows correctly in UI

* Small refactoring of item slots

* Added contained entity

* Fixed tests

* Finished with PDA

* Moving PDA uplink to separate window

* Adding-removing uplink should show new button

* Working on a better debug

* Debug command to add uplink

* Uplink send state to UI

* Almost working UI

* Uplink correcty updates when you buy-sell items

* Ups

* Moved localization to separate file

* Minor fixes

* Removed item slots methods events

* Removed PDA owner name

* Removed one uplink event

* Deleted all uplink events

* Removed flashlight events

* Update Content.Shared/Traitor/Uplink/UplinkVisuals.cs

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>

* Update Content.Server/Containers/ItemSlot/ItemSlotsSystem.cs

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>

* Update Content.Server/Containers/ItemSlot/ItemSlotsSystem.cs

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>

* Update Content.Server/GameTicking/Presets/PresetTraitorDeathMatch.cs

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>

* Item slots system review

* Flashlight review

* PDA to XAML

* Move UplinkMenu to seperate class, fix WeightedColors methods

* Move UI to XAML

* Moved events to entity id

* Address review

* Removed uplink extensions

* Minor fix

* Moved item slots to shared

* My bad Robust...

* Fixed pda sound

* Fixed pda tests

* Fixed pda test again

Co-authored-by: Alexander Evgrashin <evgrashin.adl@gmail.com>
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Co-authored-by: Visne <vincefvanwijk@gmail.com>
2021-10-03 15:05:52 +11:00
20kdc
eb82dd3dae Fix #4070, Visualizer Edition (#4730)
* Transform the Cloning Pod visualizer into a generic enum visualizer for simple cases like it

...I find it helpful at times like these to remind myself that our true enemy is
code. Code is what makes our programs run and generally is required for all of
these machinations to function in any way at all...

* Give the kitchen/meat spike a visualizer

* GenericEnumVisualizer: Byteify enums, switch to TryGetComponent for sprite
2021-10-02 16:43:47 -07:00
E F R
03e5c153da atmos: fix AtmosDeviceSystem failing to join (#4746) 2021-10-02 14:03:42 -07:00
20kdc
201b1bec89 Fix time management bugs in RadiationPulseSystem (#4743) 2021-10-02 10:53:09 -07:00
Alex Evgrashin
3b9146a11d Fix deployable barrier light toggle (#4739) 2021-10-02 16:53:20 +02:00
Vera Aguilera Puerto
b5a8e21f78 Clean up LockSystem very slightly. 2021-10-02 12:00:23 +02:00
Leon Friedrich
f80f252ff2 Make fuel tanks explodey again (#4670)
* make fuel tanks explodey again

* tanks now take damage from lit welders,
2021-10-02 11:42:46 +02:00
Vera Aguilera Puerto
2992bd74cd Fix ServerStorageComponent making bad assumptions about GetEntity/GetComponent.
It assumed they returned null instead of throwing, and had wrong/invalid logic as a result.
2021-10-02 11:26:53 +02:00
Vera Aguilera Puerto
48c9f0d646 Fix server lobby music exception.
Audio resources aren't shipped with the server, so the check is essentially useless.
2021-10-02 11:26:52 +02:00
Vera Aguilera Puerto
1aadd3e57d Activate now triggers UseDelay cooldown as well.
Fixes #4605
2021-10-02 11:02:02 +02:00
Vera Aguilera Puerto
665928cfcf Make GasTileOverlaySystem slightly more resistant against non-existing grid entities. 2021-10-02 10:53:11 +02:00
20kdc
77c5e7a5ed Migrate cuffing to an uncuff attempt event and allow self-uncuff again (#4725)
* Migrate cuffing to an uncuff attempt event and allow self-uncuff again

* Uncuff attempt event: Use more SubscribeLocalEvent and Dependency attributes
2021-10-02 00:17:36 +02:00
mirrorcult
402cd9b56b Many lighting tweaks (#4709) 2021-10-01 20:59:06 +00:00
DrSmugleaf
f07bd6b005 You can now recreate modern marketing with VV
Makes AdvertiseComponent wait fields editable through VV
2021-10-01 21:32:02 +02:00
Kara D
0825f66ca8 Fix aghosts not being able to interact with chess
Fixes #4719
2021-10-01 12:11:04 -07:00
Vera Aguilera Puerto
3b14c21396 Port all construction conditions to the new examine. 2021-10-01 15:27:42 +02:00
Vera Aguilera Puerto
f21c921c56 Fix being able to place cables on non-subfloor tiles
- Also performs an actionblocker check just in case.
2021-10-01 15:09:12 +02:00
Vera Aguilera Puerto
ac6bc743da Fix being able to uncuff yourself while incapacitated. 2021-10-01 14:47:19 +02:00
Vera Aguilera Puerto
883cbf40b2 Fix airlocks being opened by anything that bumps into them.
- Adds DoorBumpOpener component.
2021-10-01 13:47:38 +02:00
Vera Aguilera Puerto
36514f4bbd Fix hand examine showing virtual items. 2021-10-01 13:37:43 +02:00
Vera Aguilera Puerto
bbe79d91a7 Fix strippable showing virtual items. 2021-10-01 13:35:21 +02:00
Vera Aguilera Puerto
facb0358f5 Fix buckle component exception when Removed from entity. 2021-10-01 13:23:39 +02:00
Vera Aguilera Puerto
47107c6a42 Adds linting support to SoundCollectionPrototype, fix linter errors.
Closes #4580
2021-10-01 12:40:44 +02:00
Vera Aguilera Puerto
26808d2e9a Fixes bar sign not changing due to wrong conditional. 2021-10-01 12:28:52 +02:00
20kdc
9600c8e983 Fix various solution capability issues (syringes, drinks) (#4687)
* Fix syringe message stating you're attempting to draw from yourself when you aren't

* Fix various missing capabilities (syringes, beakers, drinks)

* And fix mug inject/dispense/etc, too!

* Injectors can now refill things, and switch over drinks and cups thereof to be refillable rather than injectable
2021-10-01 12:06:50 +02:00
Vera Aguilera Puerto
6451b339c2 Fix drinking glasses not fitting in reagent dispensers. 2021-09-30 14:21:56 +02:00
Vera Aguilera Puerto
fcb23627eb Fixes ghost pointing.
- Ensures VisibilityComponent on entities with GhostComponent, sets visibility layer correctly.
- Fixes wrong bitflag operation comparison
2021-09-30 13:57:29 +02:00
Vera Aguilera Puerto
e194df9747 Fix GameTicker and StartingGear performing bad string checks.
- This prevented people from spawning as clown, etc if they had set the skirt option.
- Adds some custom type serializers to StartingGear for YAML linter support.
2021-09-30 13:35:35 +02:00
Kara D
d3751ee706 whoops 2021-09-29 17:34:34 -07:00
metalgearsloth
8365e8d52c Event for PowerNetBattery CurrentSupply changing (#4570)
I re-used AmbientOnPowered but maybe that was lazy; I was doubtful anything would ever have ApcPowerReceiver and PowerNetBatteryComponent.
2021-09-29 17:09:16 -07:00
Vera Aguilera Puerto
accb83b344 Raise HolidaysRefreshedEvent when holidays are disabled. 2021-09-29 12:57:37 +02:00
Vera Aguilera Puerto
77c93a5648 Turns HolidayManager into an entity system, HolidaySystem. 2021-09-29 12:56:10 +02:00
metalgearsloth
ad783396f8 Update CloseTo to CloseToPercent (#4708) 2021-09-29 20:07:01 +10:00
metalgearsloth
fe4a415d3b Don't send chat to ghosts on other maps (#4698) 2021-09-29 11:02:27 +02:00
Vera Aguilera Puerto
0be5ff829b Gets rid of all ComponentManager usages. (#4707) 2021-09-28 13:35:29 +02:00
Vera Aguilera Puerto
4e6d602784 DoAfterSystem uses EntityUid internally, adds EntityUid constructor for DoAfterEventArgs. 2021-09-28 11:33:33 +02:00
Swept
95d6f924cc Fixes loc typo in Traitor preset 2021-09-26 23:10:24 -07:00
metalgearsloth
91665cf0e6 Optimise emergency lights a bit (#4567)
* Optimise emergency lights a bit

* Fixes

* Delete the failing test, sinple

* Revert "Delete the failing test, sinple"

This reverts commit 7d9e3a3bb6975c15add2987e39e0d3ba85d88be3.

* Start server and fix test

It just werks
2021-09-27 14:51:17 +10:00
metalgearsloth
c298a8dc8e Move remqueue to engine (#4700) 2021-09-27 14:38:53 +10:00
Vera Aguilera Puerto
0869d837d6 Replace ComponentManager with EntityManager in StackSystem.
Stacks are the most advanced piece of code in this codebase...
2021-09-26 15:43:38 +02:00