Commit Graph

2716 Commits

Author SHA1 Message Date
Vera Aguilera Puerto
182a52914a Fix construction pathfinding crash on machines when going the wrong way. 2021-11-01 16:56:33 +01:00
moonheart08
1b8b5b5d16 oh god it's BQL time (#5050)
Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com>
2021-10-31 21:14:44 +01:00
Saphire Lattice
eb567dc0bb DB QOL stuff, but not breaking the migrations now (#5086) 2021-10-31 15:18:01 +01:00
Paul Ritter
1240d320a2 refactors rougepointingarrow to ecs and stops it from targeting dead things (#5114)
Co-authored-by: Paul <ritter.paul1+git@googlemail.com>
2021-10-31 15:03:32 +01:00
Saphire Lattice
fdf67d8ee6 Fix containment fields finding one another (#5094) 2021-10-31 14:39:36 +01:00
ike709
0865409521 Adds support for unlimited stacks (#5084)
Co-authored-by: ike709 <ike709@github.com>
2021-10-31 14:27:11 +01:00
Paul
0bbc4d9afe fixes trashbag picking up things through walls
fixes #5098
2021-10-31 14:23:26 +01:00
Vera Aguilera Puerto
3cd88b8cf2 Sync UseTool nullable broadcast events 2021-10-30 19:27:06 +02:00
Saphire Lattice
1d136bf18b Make ban command properly give a ban message instead of a placeholder (#5087) 2021-10-29 20:54:14 +02:00
ike709
d9d101fae8 Fixes ghosts being able to use uplinks (#5085)
Co-authored-by: ike709 <ike709@github.com>
2021-10-29 18:37:34 +02:00
Pieter-Jan Briers
5c5534de9a Revert "A bit of DB model cleanup (#5016)"
This reverts commit 8a3cee9a10.
2021-10-29 16:10:58 +02:00
Saphire Lattice
8a3cee9a10 A bit of DB model cleanup (#5016) 2021-10-29 15:41:13 +02:00
20kdc
44f5f15790 Power-reading multitool (#5046)
* AMEPartComponent: Switch to ToolSystem.HasQuality because this bugs me.

* Multitool can read power when you examine a cable with the multitool held.

* Multitool power reading: Condense storage information

* power-sensing multitool: Fix ToolSystem ref.

* Power-reading multitools: Fix misuse of GetComponent
2021-10-29 14:42:18 +02:00
Ygg01
b2aca94586 Refactor Solution from Shared -> Server (#5078)
* Move entity solution entity systems to shared

* Move SolutionComponents to Server

* Fix namespaces

* Remove Networked Component.

* Fixes

* Add components to ignore list
2021-10-29 23:40:15 +11:00
20kdc
bddce95e37 Switch from drainallbatteries to a drain/fill-specific-battery command for saner eventing (#5077)
* drain all batteries / drain battery command for saner eventing

* Reverts the part of the previous commit where drainallbatteries skips items, despite my better judgement

* setbatterypercent now takes the place of battery drainage commands

A more forall-oriented approach
2021-10-29 11:49:52 +02:00
Alex Evgrashin
4002aa5852 Uplink UI icons and withdraw button (#4929)
* Uplink menu has icons now

* Add item icons

* Add few descriptions

* Better withdraw window

* Finished with withdraw window

* Refactored withdraw ui and fix some bugs

* Basic withdraw

* Quick fixes

* Removed uplink listing for TCs

* Move slider to separate control

* Final touches

* A bit more

* Not again...

* Fixed names

* Address review

* Fixed robust

* Non necessary check
2021-10-29 11:40:47 +02:00
Flipp Syder
c7c651e3de Refactors TemperatureComponent and AtmosExposed to ECS (#4927)
Co-authored-by: Vera Aguilera Puerto <6766154+Zumorica@users.noreply.github.com>
2021-10-29 10:18:43 +02:00
20kdc
7cdb9dcf86 Disposals fixed under station rotation (#5067)
* Some sanity checks on disposals movement, fix the interpolator

* Technically fix disposal routing, but I'm not done here yet

* Remove disposals reliance on implicit direction sensing entirely.
2021-10-29 19:07:32 +11:00
Flipp Syder
91b4ce6f24 Adds generic damage visualizer to the game (#4893) 2021-10-29 10:04:24 +02:00
metalgearsloth
87701b50c6 Remove naughty IEntity.Dirty calls (#5069)
Really this thing should probably be internal because you should never be calling it.
2021-10-28 22:40:05 -07:00
Kara D
78005f8e9e Fix windoors not autoclosing
Fixes #4902
2021-10-28 22:38:36 -07:00
Leon Friedrich
5dd73ff6e0 Fix emitter lock toggle (#5066) 2021-10-28 13:29:19 +02:00
Visne
94579d1877 Fix a bunch of warnings (#5058) 2021-10-28 13:19:38 +02:00
Vera Aguilera Puerto
0bca9befca Fix being able to electrocute pulled mobs when completely insulated. 2021-10-28 11:50:31 +02:00
Vera Aguilera Puerto
335c461442 Fix sync UseTool not calling ToolFinishUse when there's a DoAfter.
Fixes #5060
2021-10-28 11:21:55 +02:00
Vera Aguilera Puerto
f12cec3f98 Fix construction DoAfter results not setting current edge index.
Fixes #5061
2021-10-28 11:21:55 +02:00
Vera Aguilera Puerto
f840db0458 Fix bug which allowed you to build machines for free by taking the board out and putting it in again. 2021-10-28 11:07:33 +02:00
Saphire Lattice
1e7a3ff191 Fix morgue picking up pipes (#5045) 2021-10-27 23:09:10 -07:00
Leon Friedrich
49296e33a0 Refactor Context Menus and make them use XAML & stylesheets (#4768)
* XAML verb menu

* fix ghost FOV

* spacing

* rename missed "ContextMenu"->"EntityMenu" instances

* move visibility checks to verb system

* update comment

* Remove CanSeeContainerCheck

* use ScrollContainer measure option

* MaxWidth / texxt line wrapping

* verb category default

Now when you click on a verb category, it should default to running the first member of that category.

This makes it much more convenient to eject/insert when there is only a single option

* only apply style to first verb category entry

* Use new visibility flags

* FoV -> Fov

* Revert "only apply style to first verb category entry"

This reverts commit 9a6a17dba600e3ae0421caed59fcab145c260c99.

* make all entity menu visibility checks clientside

* Fix empty unbuckle category

* fix merge
2021-10-27 22:21:19 -07:00
Alex Evgrashin
2cb35fab3c Fix light replacer and move it to ECS (#5053)
* Fixed broken replacer prototype

* Light replacer ECS
2021-10-28 13:36:09 +11:00
Visne
c67160ae19 Disable warnings that would be refactored anyway (#5047) 2021-10-27 18:10:40 +02:00
metalgearsloth
a12eb29464 Convert sus events to eventbus (#5044) 2021-10-27 10:53:10 +02:00
metalgearsloth
3b508b041b Remove some unused fields again-ing 2021-10-27 19:43:57 +11:00
metalgearsloth
f320c6dd8f Fix storage closing bounds on rotated grids (#5033) 2021-10-27 10:27:25 +02:00
Ygg01
14b401f9b3 Puddle refactor 2: Spillastic boogaloo (#4784)
* Refactor PuddleComponent

* Move puddle effects into separate RSIs

Basically egg/tomato/powder puddle will be moved into separate
/Textures/Fluids RSIs

* Fix YAML for puddles

* Fix issues sloth pointed out.

* Ensure Puddle Component are properly added when spawned

* Remove unnecessary method init puddle with starting maxVolume

* Addressed ElectroSr comments

* Add Resolves

* Try fix error in ensureSolution

* Puddle unanchoring

* Address some issues with puddles

* Fix continue -> return
2021-10-27 19:24:18 +11:00
Saphire Lattice
0da8a5b9d0 Fix trashbags picking up atmos entities that are anchored (#5035) 2021-10-27 18:12:36 +11:00
Alex Evgrashin
6e00104260 Powered light ECS (#5028)
* Brrrr ECS

* Create lit on powered system

* Light bulb ECS

* Finishing porting to ECS

* Minor touches

* Removed events

* Removed old comments

* Fixed test

* To popup system
2021-10-27 12:24:22 +11:00
20kdc
60b3ff59cf Fix morgue rotation by using more EntityCoordinates (#5041) 2021-10-27 12:23:44 +11:00
Vera Aguilera Puerto
d2ffabdfd4 Fix ChangeEntity collection modified exception. 2021-10-27 01:29:10 +02:00
Vera Aguilera Puerto
189a5c7847 ConstructionGL2 Part 1: ECSification, events and steps. (#5017)
- Completely rewrited the `ConstructionComponent` logic to be ECS, *without* looking too much at the original implementation.
    - The original implementation was dirty and unmaintainable, whereas this new implementation is much cleaner, well-organized and maintainable. I've made sure to leave many comments around, explaining what everything does.
- Construction now has a framework for handling events other than `InteractUsing`.
    - This means that you can now have CGL steps for things other than inserting items, using tools...
- Construction no longer uses `async` everywhere for `DoAfter`s. Instead it uses events.
- Construction event handling occurs in the `ConstructionSystem` update tick, instead of on event handlers.
    - This ensures we can delete/modify entities without worrying about "collection modified while enumerating" exceptions.
    - This also means the construction update tick is where all the fun happens, meaning it'll show up on our metrics and give us an idea of how expensive it is/how much tick time is spent in construction.
- `IGraphCondition` and `IGraphAction` have been refactored to take in `EntityUid`, `IEntityManager`, and to not be async.
- Removes nested steps, as they made maintainability significantly worse, and nothing used them yet.
- This fixes #4892 and fixes #4857

Please note, this leaves many things unchanged, as my idea is to split this into multiple PRs. Some unchanged things:
- Initial construction code is the same. In the future, it'll probably use dummy entities.
- Client-side guided steps are the same. In the future, the server will generate the guided steps and send them to clients as needed, caching these in both the server and client to save cycles and bandwidth.
- No new construction graph steps... Yet! 👀
2021-10-26 16:38:03 +02:00
metalgearsloth
9c3a603e7e Use ActionBlockerSystem as a dependency on CGSystem 2021-10-27 01:07:19 +11:00
Julian Giebel
d1a830cd74 Fix ApcPowerReceiverComponent deletion (#5031)
Co-authored-by: Julian Giebel <j.giebel@netrocks.info>
2021-10-25 21:55:00 +02:00
20kdc
c29b23eb64 Fix ChemMaster bottles not having contents (#5026) 2021-10-25 16:58:16 +02:00
ike709
ec92f4eef2 Adds stack splitting (#4981)
* Adds stack splitting

* Apply suggestions from code review

Co-authored-by: ike709 <ike709@github.com>
Co-authored-by: Vera Aguilera Puerto <6766154+Zumorica@users.noreply.github.com>
2021-10-25 16:36:04 +02:00
moonheart08
debd22e19c Add select (#5003) 2021-10-25 16:23:44 +02:00
Vera Aguilera Puerto
ed3bf94a3b Electrocution. (#4958)
Co-authored-by: Pieter-Jan Briers <pieterjan.briers@gmail.com>
2021-10-25 16:21:56 +02:00
Leon Friedrich
6e84e23ba1 Remove some functions from HandsComponent (#4937)
* remove wrapper functions

* Remove InteractionSystem wrapper functions

* remove two more functions

* add missing `using`

* clean diff
2021-10-25 18:06:12 +11:00
StStevens
e621a82e65 Fire extinguisher safety (#4912)
* Moved safety into FireExtinguisherComponent.

* Fix errant find and replace

* Address reviews

Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2021-10-25 18:04:24 +11:00
mirrorcult
c0ecdb09af Slipping tweaks + remove EffectBlocker (#4955)
* Slipping tweaks + remove EffectBlocker

* mfw failed merge conflict resolution

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
2021-10-25 17:43:49 +11:00
Leon Friedrich
e016fc9906 spray bottle fix (#5012)
* fix-spray

* move vapor rotation
2021-10-25 17:29:02 +11:00