Commit Graph

8759 Commits

Author SHA1 Message Date
Pieter-Jan Briers
0918e14827 Fix issues with .NET 5. 2020-11-11 00:46:13 +01:00
Víctor Aguilera Puerto
44ee2b7ab6 Fix async usage in InteractionSystem
Fixes #2524
2020-11-10 22:47:43 +01:00
Pieter-Jan Briers
f8f177f43a More comments and a fix. 2020-11-10 22:00:07 +01:00
Pieter-Jan Briers
736f9958cc Cleanup, code review, comments. 2020-11-10 21:30:20 +01:00
Pieter-Jan Briers
7bc93bd2a9 Missed these in the merge, whoops. 2020-11-10 17:06:20 +01:00
Pieter-Jan Briers
00774e90ed Merge remote-tracking branch 'upstream/master' into 20-10-30-admins 2020-11-10 16:59:17 +01:00
Pieter-Jan Briers
e39ddd4802 Permissions panel. 2020-11-10 16:50:28 +01:00
ShadowCommander
e567e9fec1 Fix signallink command not working (#2534)
The InteractionSystem always returns true, so this change runs the SignalLinkerSystem CommandBind before InteractionSystem
2020-11-10 00:30:19 -08:00
chairbender
5f788c3318 Alerts System and UI (#2529)
* #272 add bordered panel for effects bar

* #272 avoid mouse overlapping tooltip when near edges,
change tooltip colors to match mockups

* #272 WIP defining status effect states as YML and
sending them as encoded integers

* #272 refactor to use new alert system

* #272 refactor to use new alert system

* #272 fix various bugs with new alert system and update
alerts to have color

* #272 WIP

* #272 rename status effects to alerts

* #272 WIP reworking alert internals to avoid code dup
and eliminate enum

* #272 refactor alerts to use
categories and fix various bugs

* #272 more alert bugfixes

* #272 alert ordering

* #272 callback-based approach for alert clicks

* #272 add debug commands for alerts

* #272 utilize new GridContainer capabilities for sizing of alerts tab

* #272 scale alerts height based on
window size

* #272 fix tooltip flicker

* #272 transparent alert panel

* #272 adjust styles to match injazz mockups more, add cooldown info in tooltip

* #272 adjust styles to match injazz mockups more, add cooldown info in tooltip

* #272 alert prototype tests

* #272 alert manager tests

* #272 alert order tests

* #272 simple unit test for alerts component

* #272 integration test for alerts

* #272 rework alerts to use enums instead
of id / category

* #272 various cleanups for PR

* #272 use byte for more compact alert messages

* #272 rename StatusEffects folder to Alerts,
add missing NetSerializable
2020-11-10 15:22:19 +11:00
Exp
6e3cc9e78a PDA Pen Holder (#2519)
* -Adds pens to pdas
-Adds eject pen verb

* Reviews:
-Changed Container into ContainerSlot
-Starting prototypes are now nullable
-Removed double GetComp call

* EjectPen Button
2020-11-08 23:43:13 +11:00
Remie Richards
c580423f41 Fixes. Can no longer open while cooking. Can no longer cook while open. (#2521) 2020-11-08 01:10:55 +01:00
Víctor Aguilera Puerto
50f03a5b17 Fix firelock occlusion. 2020-11-07 23:58:33 +01:00
DrSmugleaf
bf5b9ad03b Change cvar usages to use CVarDef and define them in CCVars (#2250)
* Change cvar usages to use CVarDef and define them in CCVars

* Merge fixes

* Remove duplicate cvar registration
2020-11-07 11:15:56 +11:00
DrSmugleaf
b5d00a2cf6 Buckle improvements (#2508)
* Buckle improvements

* Update doc

* Remove redundant argument name

* Remove import
2020-11-07 01:15:02 +11:00
DrSmugleaf
560f89b297 Fix AI crash when an entity is moved to an invalid grid (#2507) 2020-11-07 01:04:13 +11:00
DrSmugleaf
9926ef298c Move rotate event subscription from NodeContainerComponent to NodeContainerSystem (#2506) 2020-11-06 12:52:01 +01:00
Víctor Aguilera Puerto
089422fa99 Use EntitySystem proxies to (un)subscribe to event in BuckleSystem. 2020-11-06 12:43:38 +01:00
Víctor Aguilera Puerto
bb3aee90b2 FloorTileItem station extension/new grid creation (#2500)
* FloorTileItemComponent can now extend the station, or create new grids.

* Fixes wrong interaction system EntityCoordinates check.
Needed for all this to work.
2020-11-06 22:38:41 +11:00
Víctor Aguilera Puerto
6a469508ca Fix every BuckleComponent subscribing to EventBus when buckled (#2504) 2020-11-06 12:38:24 +01:00
Víctor Aguilera Puerto
60dd0de96f Fix crash when invalid construction prototype is passed.
Fixes #2501
2020-11-06 10:56:14 +01:00
metalgearsloth
864fa0a57c Minor device network changes (#2499)
* Device network changes

* Update too

* Update Content.Server/GameObjects/EntitySystems/DeviceNetworkSystem.cs

Co-authored-by: Metal Gear Sloth <metalgearsloth@gmail.com>
Co-authored-by: Víctor Aguilera Puerto <6766154+Zumorica@users.noreply.github.com>
2020-11-05 18:04:21 +01:00
metalgearsloth
e62df15ef9 Add cvar for events (#2478)
There's also the existing events command as well that's separate. I think there's value in having both? (Where mods can turn it on and off but not change the default?)

Co-authored-by: Metal Gear Sloth <metalgearsloth@gmail.com>
2020-11-05 18:04:07 +01:00
metalgearsloth
51d8d5dd9d Disable climbing when buckled (#2488)
Co-authored-by: Metal Gear Sloth <metalgearsloth@gmail.com>
2020-11-06 01:08:24 +11:00
ShadowCommander
8fa6f2c3de Add feedback to the signallink command (#2482) 2020-11-05 22:57:49 +11:00
Víctor Aguilera Puerto
5cac4c5917 RotatableComponent QOL improvements.
- Rotatable verbs only show if the entity can be rotated.
- Adds parameter to rotate anchored entities.
- Office chairs can now be rotated regardless of anchoring.
2020-11-04 11:21:01 +01:00
zionnBE
2faff4963a Fix block game causing server crash (#2477)
* Fix block game crashing server

* fffff i just noticed

* THIS is the correct property

* Ignore unpause if game has not started

* Init _currentPiece by BlockGame constructor
2020-11-04 18:08:47 +11:00
DrSmugleaf
3970e8b179 Add unoccluded check for pointing arrows (#2253)
* Make pointing check for occlusions

* Make pointing ignore the pointer in case you are hella occluding

* Merge branch 'master' of https://github.com/space-wizards/space-station-14 into unoccluded-pointing
2020-11-03 21:25:31 +11:00
zionnBE
9f03fc8880 Add access restrictions to vending machines (#2471)
* Add vending machine access restrictions

* oops

* Handle null

* Flick deny upon access denied

Co-authored-by: zionnBE <zionn@tfwno.gf>
2020-11-02 22:33:12 +11:00
DrSmugleaf
1817a4a816 Change events command to give better instructions on how to use it (#2456) 2020-11-02 11:41:07 +01:00
DrSmugleaf
6b4a39006e Make mechanism behaviors properly update, fix eating and drinking (#2472)
* Make mechanisms properly update and fix eating and drinking

* Remove outdated component ignores

* Fix nullable error

* Fix mechanism behavior events

* Remove unnecessary code
2020-11-02 11:37:37 +01:00
Markek1
b5d48e4db0 Fixed crematorium creating ash out of nothing and being allowed to cremate while open (#2473) 2020-11-02 11:31:27 +01:00
Pieter-Jan Briers
c9236d88ac Merge remote-tracking branch 'upstream/master' into 20-10-30-admins 2020-11-02 00:24:15 +01:00
Pieter-Jan Briers
6980ff84b0 Fix include calls for the admin DB stuff. 2020-11-02 00:23:34 +01:00
Pieter-Jan Briers
0e419ad321 Fix include calls for the admin DB stuff. 2020-11-02 00:22:53 +01:00
Pieter-Jan Briers
0618cde2b7 Announce logins/logouts. 2020-11-02 00:04:58 +01:00
Pieter-Jan Briers
6f78851647 Send messages on admin/deadmin. 2020-11-01 23:56:35 +01:00
metalgearsloth
2e65b1e5fa Optimise flashlights (#2468)
Flashlights were calling dirty EVERY TICK so this just means they only call it when absoluetely necessary which saves a lot.

Co-authored-by: Metal Gear Sloth <metalgearsloth@gmail.com>
2020-10-31 21:56:46 +01:00
Víctor Aguilera Puerto
87cb22838b Fix bug where built computers would spawn with an extra board. 2020-10-31 14:17:33 +01:00
Paul Ritter
172b964de4 zumo too quick (#2463)
Co-authored-by: Paul <ritter.paul1+git@googlemail.com>
2020-10-30 19:58:17 +01:00
Paul Ritter
f36cba8e21 Refactors machine linking to use generics (#2462)
Co-authored-by: Paul <ritter.paul1+git@googlemail.com>
2020-10-30 19:46:19 +01:00
Pieter-Jan Briers
711166f43a Merge remote-tracking branch 'upstream/master' into 20-10-30-admins 2020-10-30 16:23:21 +01:00
Pieter-Jan Briers
ad58a056d7 ConGroups are gone. Long live admin flags in content. 2020-10-30 16:06:48 +01:00
Paul Ritter
d8f5bffaa0 Arcade polish (#2333)
Co-authored-by: Pieter-Jan Briers <pieterjan.briers@gmail.com>
2020-10-30 11:25:26 +01:00
Víctor Aguilera Puerto
e9df8794da Instrument State now syncs more instrument values.
For adminbus purposes, mostly.
2020-10-30 10:34:22 +01:00
DrSmugleaf
37e97ca89f Change components to use timer component (#2426)
* Change components to use timer component

* Fix old usages of tokens
2020-10-30 15:02:49 +11:00
DrSmugleaf
57729063b7 Add a test for the weightless status (#2437)
* Add wip test for weightless status

* Expand and fix weightless test
2020-10-30 02:38:21 +01:00
Julian Giebel
45b610f933 Disposal mailing (#2194)
* Implement device networking

* Implement device configuration menu

* Fix device network

* Implement disposal mailing unit

* Implement base network connection
Implement wired and wireless network connection
Implement device network metadata

* Fix dereference null error

* Fix wired network null checks

* Change BaseNetworks enum to NetworkUtils class
Add PingResponse function to NetworkUtils
Change device network file structure

* Add doc comments

* Apply suggestions from code review

Co-authored-by: DrSmugleaf <DrSmugleaf@users.noreply.github.com>

* Add tag validation to disposal mailing unit

* Add tag validation to the mailing unit component

* Address reviews
Change WiredNetwork can connect check
Change device networking string literals to constants

* Address reviews
Revert changes to PowerProvider and PowerReceiver
Add new NodeGroup
WELP

* Fix recursive access to Owner property

* Integrate suggested changes

* Fix TryGetWireNet acting on NullPowerProvider
Fix network connections not checking if their owner has been deleted

* Close device network connection when the owning entity got deleted
Fix mailing unit not closing the device network connection on remove

* Remove GetWireNet from NullPowerProvider

Co-authored-by: Julian Giebel <j.giebel@netrocks.info>
Co-authored-by: DrSmugleaf <DrSmugleaf@users.noreply.github.com>
2020-10-30 01:16:26 +01:00
DrSmugleaf
ac3e9bc566 Fix weightlessness status effect appearing only after something checks if an entity is weightless (#2434)
* Revert "Add weightlessness status effect. (#2384)"

This reverts commit 9b751fc079.

* Bring back the icon and status

* Make weightless status track gravity and parent
2020-10-30 01:07:51 +01:00
ShadowCommander
23ae73d429 Fix throwing knockback when weightless (#2369)
* Fix throwing an item not moving the player when weightless

* Remove unnecessary code from ThrownItemComponent

* Fix velocity not stopping when hitting a wall after slipping when weightless

* Fix CanMove check being reversed
2020-10-30 01:06:51 +01:00
Git-Nivrak
e4261f4e57 Make dead bodies disposable (#2375)
* Make dead bodies disposable

* Formatting Fixes

* Fixed Returning False in any case

* Revert "Fixed Returning False in any case"

This reverts commit fb1e40ca44f208078816e119976779280922b4c8.

* Fixed Returning False in any case

* Update Submodule
2020-10-30 01:06:20 +01:00