Pieter-Jan Briers
0c97520276
Fix usages of TryIndex() ( #39124 )
...
* Fix usages of TryIndex()
Most usages of TryIndex() were using it incorrectly. Checking whether prototype IDs specified in prototypes actually existed before using them. This is not appropriate as it's just hiding bugs that should be getting caught by the YAML linter and other tools. (#39115 )
This then resulted in TryIndex() getting modified to log errors (94f98073b0#39098 )
This commit goes through and checks every call site of TryIndex() to see whether they were correct. Most call sites were replaced with the new Resolve(), which is suitable for these "defensive programming" use cases.
Fixes #39115
Breaking change: while doing this I noticed IdCardComponent and related systems were erroneously using ProtoId<AccessLevelPrototype> for job prototypes. This has been corrected.
* fix tests
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com >
2025-09-09 18:17:56 +02:00
psykana
c59f7a5363
Fix ninja spawning with jetpack internals ( #35067 )
...
Remove redundant StartingGearEquippedEvent
2025-08-17 17:25:26 -07:00
Ed
1c33073af4
Multiple items in loadouts ( #33193 )
...
* loadouts update
* Update loadout_groups.yml
* darts to candles
* Update Resources/Prototypes/Loadouts/dummy_entities.yml
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com >
2024-12-24 01:24:19 +01:00
Errant
9522dbc655
Vox nukies and ninjafix ( #29783 )
...
* Nukie species gear
* antagselectionsystem autointernals
* nukie vox
* skrek
* Remove duplicate code
* skrek
* EVA tank loadouts, vox ninja update
* fix prototype duplication
* skrek
* fix summary
* fixed empty startinggear error
* enable vox ninjas
* Comments
* removed comment because startinggearprototype should not be used on antagselection aaaanyway
* squish that if
* Update Content.Shared/Clothing/LoadoutSystem.cs
---------
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com >
2024-08-06 20:58:28 +10:00
metalgearsloth
9a8620d9d8
De-duplicate loadout gear ( #30341 )
...
* De-duplicate loadout gear
Needs supporting code, probably with an interface with StartingGearPrototype which would also use it, but I regexed the yaml.
* Code updates
* Remaining yaml
* Fix automatic naming
* raiseEvent
* Don't code when tired kids
2024-08-05 00:42:25 -04:00
Tayrtahn
3009687326
Fix internals not auto-activating for entities spawned in space ( #29213 )
...
* Add organs before trying to breathe
* Add tests for auto-internals
* EntMan to the rescue
2024-06-25 16:28:48 +10:00
metalgearsloth
8f12e90b90
Don't use invalid defaults for loadouts ( #28740 )
...
* Don't use invalid defaults for loadouts
At the time it made more sense but now with species specific stuff it's better to have nothing.
* Loadout SetDefault only applies valid loadouts
2024-06-15 16:53:42 +10:00
Ed
e522bbf90d
New event: Approaching unknown shuttle ( #24490 )
...
* setup codebase
* Add first shuttle
* tak
* sync striker
* sync 2
* pipipi
* Preloaded roundstart shuttles!
* Make it abstract "PreloaderGrid" not "PreloaderShuttle"
* to do
* added china cuisin shuttle
* fixes
* add disaster evacpod
* remove enemy
* final shuttles
* weight 5 -> 10
* move data to component
* remove autotrailer touching
* doc, respath
* fix frozen positioning
* fixes + cvar
* finally
* fix evacpod
* remove blacklistrules
* remove `UnknownShuttleSpawnRule`, refactor `LoadMapRule` to support preloaded grids
* use tryload
* cleanup
* fixes
* use preloadedgrid for loneops
* weight unknown shuttles differently (preliminal)
* leftover
* cleanup and raffling
* partial review
* singleton gridpreloader no station coupling
* fix grid atmoses
* `roleLoadout` support for `LoadoutComponent`, fix missing gear
* weighting changes
* init logic fix
---------
Co-authored-by: Kara <lunarautomaton6@gmail.com >
2024-05-10 04:35:59 -07:00
metalgearsloth
12766fe6e3
Loadouts redux ( #25715 )
...
* Loadouts redux
* Loadout window mockup
* More workout
* rent
* validation
* Developments
* bcs
* More cleanup
* Rebuild working
* Fix model and loading
* obsession
* efcore
* We got a stew goin
* Cleanup
* Optional + SeniorEngineering fix
* Fixes
* Update science.yml
* add
add
* Automatic naming
* Update nukeops
* Coming together
* Right now
* stargate
* rejig the UI
* weh
* Loadouts tweaks
* Merge conflicts + ordering fix
* yerba mate
* chocolat
* More updates
* Add multi-selection support
* test
h
* fikss
* a
* add tech assistant and hazard suit
* huh
* Latest changes
* add medical loadouts
* and science
* finish security loadouts
* cargo
* service done
* added wildcards
* add command
* Move restrictions
* Finalising
* Fix existing work
* Localise next batch
* clothing fix
* Fix storage names
* review
* the scooping room
* Test fixes
* Xamlify
* Xamlify this too
* Update Resources/Prototypes/Loadouts/Jobs/Medical/paramedic.yml
Co-authored-by: Mr. 27 <45323883+Dutch-VanDerLinde@users.noreply.github.com >
* Update Resources/Prototypes/Loadouts/loadout_groups.yml
Co-authored-by: Mr. 27 <45323883+Dutch-VanDerLinde@users.noreply.github.com >
* Update Resources/Prototypes/Loadouts/Jobs/Civilian/clown.yml
Co-authored-by: Mr. 27 <45323883+Dutch-VanDerLinde@users.noreply.github.com >
* Update Resources/Prototypes/Loadouts/Jobs/Civilian/clown.yml
Co-authored-by: Mr. 27 <45323883+Dutch-VanDerLinde@users.noreply.github.com >
* Update Resources/Prototypes/Loadouts/loadout_groups.yml
Co-authored-by: Mr. 27 <45323883+Dutch-VanDerLinde@users.noreply.github.com >
* Update Resources/Prototypes/Loadouts/Jobs/Security/detective.yml
Co-authored-by: Mr. 27 <45323883+Dutch-VanDerLinde@users.noreply.github.com >
* Update Resources/Prototypes/Loadouts/loadout_groups.yml
Co-authored-by: Mr. 27 <45323883+Dutch-VanDerLinde@users.noreply.github.com >
* ben
* Margins
---------
Co-authored-by: Firewatch <54725557+musicmanvr@users.noreply.github.com >
Co-authored-by: Mr. 27 <koolthunder019@gmail.com >
Co-authored-by: Mr. 27 <45323883+Dutch-VanDerLinde@users.noreply.github.com >
2024-04-16 22:57:43 +10:00
metalgearsloth
ead47c541d
Fix humanoid appearances for placement manager ( #18291 )
2023-08-05 14:25:47 +10:00
