* Fix usages of TryIndex()
Most usages of TryIndex() were using it incorrectly. Checking whether prototype IDs specified in prototypes actually existed before using them. This is not appropriate as it's just hiding bugs that should be getting caught by the YAML linter and other tools. (#39115)
This then resulted in TryIndex() getting modified to log errors (94f98073b0), which is incorrect as it causes false-positive errors in proper uses of the API: external data validation. (#39098)
This commit goes through and checks every call site of TryIndex() to see whether they were correct. Most call sites were replaced with the new Resolve(), which is suitable for these "defensive programming" use cases.
Fixes#39115
Breaking change: while doing this I noticed IdCardComponent and related systems were erroneously using ProtoId<AccessLevelPrototype> for job prototypes. This has been corrected.
* fix tests
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Add new fields to DeliveryComponent for #36636
* Setting the baseSpesoPenalty for currently available deliveries
* Small fixes
* Basic delivery penalization
* Penalty and reward multiplier calculation in place
Also fixes an issue in SharedCargoSystem when opening a delivery in dev server due to trying to allocate cargo twice.
* Calling penalty no longer happens on opening
* Extract multiplier getting
* Removing unused include
* Changing method description. \n\n Not actually sure what I meant by the first one
* Localising default delivery messages
* Unused include removal
* minor tweaks
* slarti changes
* forgot
* stuffs
* yippee
* Locn't
* doc
* Apply suggestions from code review
---------
Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>
Co-authored-by: ScarKy0 <scarky0@onet.eu>
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
