Pieter-Jan Briers
0c97520276
Fix usages of TryIndex() ( #39124 )
...
* Fix usages of TryIndex()
Most usages of TryIndex() were using it incorrectly. Checking whether prototype IDs specified in prototypes actually existed before using them. This is not appropriate as it's just hiding bugs that should be getting caught by the YAML linter and other tools. (#39115 )
This then resulted in TryIndex() getting modified to log errors (94f98073b0#39098 )
This commit goes through and checks every call site of TryIndex() to see whether they were correct. Most call sites were replaced with the new Resolve(), which is suitable for these "defensive programming" use cases.
Fixes #39115
Breaking change: while doing this I noticed IdCardComponent and related systems were erroneously using ProtoId<AccessLevelPrototype> for job prototypes. This has been corrected.
* fix tests
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com >
2025-09-09 18:17:56 +02:00
Tayrtahn
1d04194767
Cleanup warnings in VendingMachineSystem ( #37454 )
...
Cleanup warnings in VendingMachineSystem
2025-05-14 22:18:36 +02:00
Tayrtahn
2ff9c8dfb9
Fix vending machine manager wire error ( #37100 )
...
Skip updating amounts for removed entries
2025-05-02 02:21:59 +02:00
metalgearsloth
a8ebcac5c9
Predict vending machine UI ( #33412 )
2025-03-02 13:47:52 +11:00
metalgearsloth
634c4a7780
Fix window positions not saving ( #35055 )
...
Co-authored-by: Kevin Zheng <kevinz5000@gmail.com >
2025-02-23 23:57:57 +11:00
scrivoy
b3c61530bf
Enhance Vending Machine UI: Adjust Minimum Height for better User Experience ( #32851 )
...
set FancyWindow MinHeight to 210
2024-10-16 23:34:31 -05:00
metalgearsloth
dd7884ed40
Predict vending machine BUI ( #32376 )
2024-09-23 12:10:22 +10:00
Plykiya
dba10a1c80
Reduce vertical margin on vending machine UI ( #32074 )
...
Smaller vending machine UI
2024-09-11 16:45:52 +02:00
Pieter-Jan Briers
528fb4ad55
Quick warning fixes ( #31694 )
2024-09-01 04:54:39 +02:00
Pieter-Jan Briers
d15869f600
Fix ChemVend jugs again ( #31398 )
...
This re-introduces the dummy entity naming code, originally introduced in #29178 and randomly removed by #30064 with no technical justification given.
Fixes #31373
2024-08-25 12:02:33 +10:00
Winkarst
588661465a
Make vending machine use EntityPrototypeView ( #30064 )
...
* Make vendor machines use EntityPrototypeView
* Update
* 1
* Kill me
* For the love of god!!!
2024-08-22 10:40:39 -04:00
metalgearsloth
edb05e36bb
Reapply "Remove some BUI boilerplate" ( #30214 ) ( #30219 )
...
* Reapply "Remove some BUI boilerplate" (#30214 )
This reverts commit cb0ba66be3
2024-07-21 14:48:13 +10:00
Nemanja
cb0ba66be3
Revert "Remove some BUI boilerplate" ( #30214 )
...
Revert "Remove some BUI boilerplate (#28399 )"
This reverts commit cbf329a82d
2024-07-20 20:42:27 -04:00
metalgearsloth
cbf329a82d
Remove some BUI boilerplate ( #28399 )
...
* Remove some BUI boilerplate
- The disposals overrides got removed due to the helper method handling it.
- Replace window creation with CreateWindow helper.
- Fixed some stinky code which would cause exceptions.
* More
* moar
* weh
* done
* More BUIs
* More updates
* weh
* moar
* look who it is
* weh
* merge
* weh
* fixes
2024-07-20 15:40:16 +10:00
Cojoke
b57174007c
Remove all Assigned Values that are Never Used ( #30110 )
...
Remove all Assigned Values that are never used
2024-07-18 20:22:23 -04:00
Tayrtahn
ac1bdd2c84
Fix unlabeled jugs in ChemVend ( #29178 )
...
* Spawn dummy entities on client for vending machine UI
* Asked sloth, and we kinda need this pr
---------
Co-authored-by: Vasilis <vasilis@pikachu.systems >
2024-06-23 19:31:34 +02:00
James Simonson
99aa72e30d
Vending UI facelift ( #25377 )
...
* Convert to fancy window + added footer + add list spacing
* margin add
2024-02-19 15:18:26 -07:00
Kara
e212b10ca2
Open some windows non-centered to avoid covering the player ( #24767 )
2024-02-01 23:49:48 +11:00
themias
cf6eb200be
Remove need to toggle vending machine button ( #21543 )
2023-11-08 18:42:07 -07:00
Nemanja
0253270a9a
fix searching on vending machines ( #21233 )
2023-10-26 00:01:16 +11:00
ike709
3ee729f3fd
Adds a search bar to vending machines ( #20326 )
...
* Adds a search bar to vending machines
* fix indentation
* whitespace again
---------
Co-authored-by: ike709 <ike709@github.com >
2023-09-20 15:40:41 -04:00
metalgearsloth
99b77bc2d3
Remove lights compref ( #19531 )
2023-09-11 19:18:06 +10:00
TemporalOroboros
3ac4cf85db
Cleaner BoundUserInterfaces ( #17736 )
2023-07-09 02:02:17 +10:00
metalgearsloth
68480af109
Update content vectors to numerics ( #17759 )
2023-07-08 14:08:32 +10:00
Nemanja
faca40b8d5
more component ref removal + combining server/client comps ( #13178 )
...
Co-authored-by: DrSmugleaf <DrSmugleaf@users.noreply.github.com >
2022-12-25 05:28:21 +01:00
AJCM-git
c7ec03d2fb
TryGetData() Generics support content changes ( #13053 )
2022-12-20 14:24:55 -08:00
Mervill
69dd3a0454
Vending machines properly show their current state after an animation ( #12201 )
2022-10-30 17:12:05 +11:00
metalgearsloth
600c0e3255
Fix a few warnings ( #11576 )
2022-10-04 14:24:19 +11:00
Andreas Kämper
42f3155c85
Clean up vending machines and port their visualizer ( #10465 )
2022-08-31 05:12:09 -07:00
Leon Friedrich
921e2ee57d
BUI changes required for Engine PR ( #10608 )
2022-08-21 03:38:30 +10:00
Visne
58769634c7
Fix a bunch of compiler warnings ( #10518 )
2022-08-13 22:28:34 -07:00
metalgearsloth
45bd1edd5b
Revert "Update submodule to 0.34.0.0 ( #10356 )" ( #10359 )
2022-08-06 16:48:21 +10:00
Leon Friedrich
e06ea56eb2
Content BUI changes for engine PR ( #10308 )
2022-08-06 14:59:02 +10:00
Leon Friedrich
5449e7875e
Vending visualizer update ( #9962 )
2022-07-26 10:35:36 +10:00
Flipp Syder
8f223586d4
Vending machine changes ( #8060 )
...
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com >
2022-05-10 12:22:58 +10:00
mirrorcult
ec4d4688c7
Seal/abstract/virtual everything ( #6739 )
2022-02-16 18:23:23 +11:00
Fishfish458
b837b186a5
Attempted Small Vending Machine Refactor ( #6157 )
...
Co-authored-by: fishfish458 <fishfish458>
2022-01-31 15:16:41 +11:00
wrexbe
cea1b21832
Fixing some warnings ( #6250 )
...
Co-authored-by: Paul Ritter <ritter.paul1@googlemail.com >
2022-01-21 10:38:35 +01:00
wrexbe
5ceb2372bf
Clean up some warnings ( #6088 )
...
* Clean up some warnings
* Remove nullable enable
Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com >
Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com >
2022-01-09 22:10:36 -06:00
Vera Aguilera Puerto
2699540526
Remove useless resolves from a buncha tests.
2021-12-08 12:46:30 +01:00
DrSmugleaf
2a3b7d809d
Fix 3000 errors
2021-12-05 18:09:01 +01:00
Vera Aguilera Puerto
5cd42c9ad6
Inline UID
2021-12-03 15:53:09 +01:00
Vera Aguilera Puerto
ee4ff9cfe8
Inline Name
2021-12-03 15:25:51 +01:00
Vera Aguilera Puerto
69b270017b
Inline TryGetComponent completely, for real
2021-12-03 14:17:01 +01:00
Vera Aguilera Puerto
0feebbff00
Inline HasComponent entirely
2021-12-03 12:23:18 +01:00
Vera Aguilera Puerto
b835bea086
Inline GetComponent
2021-12-03 11:55:25 +01:00
Vera Aguilera Puerto
f64df117be
Inline AddComponent
2021-12-03 11:33:40 +01:00
Swept
8e802b4305
Refactors Vending Menu to XAML-UI ( #4614 )
...
* Initial
* Some web-edit reviews
* Keep VV
* Applied Reviews
2021-09-19 17:21:05 +00:00
DrSmugleaf
ff1a2d97ea
Re-organize all projects ( #4166 )
2021-06-09 22:19:39 +02:00
Swept
fd2a081539
Slims down disposal unit ui and fixes thrown collisions ( #4122 )
...
* Cleans up disposal unit yaml and fixes inability to throw things in them.
* Comments out mailing units because they are beyond broken and need a refactor.
* Makes Disposal UI look better
* Localized the disposal unit
* Removes title line
* Removes changes to VendingMachineMenu, mistakenly committed.
* Applies code reviews
* Now uses BaseMachinePowered
2021-06-03 17:26:08 -07:00
