Commit Graph

24634 Commits

Author SHA1 Message Date
metalgearsloth
bb0776c496 Revert "Cleanup ExecutionSystem (#24382)" (#25555)
* Revert "Cleanup ExecutionSystem (#24382)"

This reverts commit bcbe2ec1af.

* Revert "Executions (#24150)"

This reverts commit 2e83f5a0ec.

# Conflicts:
#	Content.Shared/Weapons/Melee/SharedMeleeWeaponSystem.cs
2024-02-25 22:36:17 +11:00
nikthechampiongr
bcbe2ec1af Cleanup ExecutionSystem (#24382)
* Creat Execution Component and add to sharp items

* Kill Server ExecutionSystem. Create ExecutionSystem in shared. Create ActiveExecution Component.
Transferred the Execution system into shared. Heavily re-wrote the system in order to reduce duplication,
and remove gun code from the system.
The melee weapon modifier which was dependant on swing rate was removed.

The ActiveExecutionComponent was created in order to apply the damage modifier to the shot from a gun execution.
It is added just before the gun fires and removed after an attempt is made.

* Fix bugs

The execution completed text will now only show up if the gun fires.

The client also no longer crashes because I forgot to network the component.

* Remove clumsy text

* Make BaseSword abstract

* Add ExecutionComponent to every weapon

* Fix bug

* Remove execution comp from battery weapons

Currently the gun system does not have a way to alter hitscan damage like it does with projectiles.

* Cleanup

* Revert "Remove clumsy text"

This reverts commit a46da6448d5d179a4e936f9213d5622bedb58a16.

* Actually fix the ExecutionSystem

Everything about the shot goes through the gun system now.
The Damage multiplier is only applied when a projectile impacts the target so people that get in the way don't get hit
with 9 times damage for no reason.

In order to make suicides work I needed to create fake EntityCoordinates because the gun system and the projectile
system do not play well with a projectile that has the same start and end position.

* Make launchers able to execute

* Fix prediction bug

The OnAmmoShotEvent is only raised on the server.

* Readd ability for clowns to accidentally shoot themselves while executing

* Cleanup

* Reset melee cooldown to initial value

* Address reviews fix bug

Addressed reviews on overriding messages.
Now I actually mark doafters as handled.
Return normal cooldown to some meleeweapons I forgot on the previous commit.

* Address Reviews

Remove duplication

* Exorcise codebase

Remove evil null coercion that I was sure I removed a while ago

* Address reviews again

* Remove melee weapon attack logic and rely on the system. Remove gun and
melee checks.

* Make system functional again and cleanup

* Remove code I forgot to remove

* Cleanup

* stalled

* Selectively revert gun penetration

The collision layer check doesn't work and I don't have time to fix it.

* Fixes

---------

Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2024-02-25 22:07:10 +11:00
metalgearsloth
ec5edc3626 Selectively revert gun penetration (#25551)
The collision layer check doesn't work and I don't have time to fix it.
2024-02-25 21:58:08 +11:00
PJBot
e52ebe0ebd Automatic changelog update 2024-02-25 07:37:28 +00:00
Flesh
aa4e7c0619 Made ordering multiple crates at cargo order multiple crates (#25518)
* please tell me this is empty

* it wasn't empty, fixing that

* This should fix it

* fix for the fix

* address changes

* fix

* Added some comments, hoping that failed test was a fluke.
2024-02-25 18:36:22 +11:00
Ubaser
9a4c10cc89 pAI map button sprite change (#25384)
* add

* ya

* add
2024-02-25 15:41:13 +11:00
Ubaser
531d722c13 Increase contrast with hand select for Ashen UI theme (#25517)
add
2024-02-24 22:29:20 -06:00
metalgearsloth
34a6f12ce6 Update submodule to 211.0.2 (#25536) 2024-02-25 14:33:07 +11:00
Debug
e1cce9d842 Prevent clients from setting their species to whatever they want (#25535)
Prevent epic hack
2024-02-24 22:00:28 -05:00
PJBot
c52820a4b6 Automatic changelog update 2024-02-25 02:41:54 +00:00
ArchPigeon
5806401502 Remove the ability for command or any antag-safe role from being initial infected in zombie mode (#25529)
Remove the ability for command to be initial infected in zombie mode
2024-02-24 21:40:49 -05:00
PJBot
51caf3b519 Automatic changelog update 2024-02-25 02:30:22 +00:00
beck-thompson
84fff930c2 Fixed Fire Extinguisher safety range (#25534) 2024-02-25 13:29:16 +11:00
github-actions[bot]
431f0bd640 Update Credits (#25532)
Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com>
2024-02-24 20:28:11 -05:00
PJBot
786ecd961a Automatic changelog update 2024-02-24 01:46:08 +00:00
Eris
39a2ff5c0a Fix a single grammar error (#25512)
Update food-component.ftl

why was I the only one that noticed it
2024-02-23 19:45:02 -06:00
lapatison
2a5eb86e22 Minor cookie fortune fix (#25503)
minor locale fix
2024-02-23 18:51:03 +03:00
lzk
7a37d4a013 Make cargo order unanchored thruster and gyroscope (#25497) 2024-02-23 16:49:27 +03:00
PJBot
2ad32433d8 Automatic changelog update 2024-02-23 13:20:58 +00:00
Vasilis
237d89cbfe Fix centcom and other jobs with setPreference set to false showing up anyway (#25496)
* God dammit pjb

* Smol cleanup
2024-02-23 14:19:52 +01:00
Ed
af7e8025ad Fix attribution (#25495)
Update attributions.yml
2024-02-23 14:49:47 +03:00
metalgearsloth
d8e5f5c24b Optimise DecalOverlay (#25266)
ChunkSize is still 32 so doesn't cut down on heaps of decals atm though we avoid passing many decals to drawing with the coordinates bounds check now.
2024-02-23 18:12:23 +11:00
metalgearsloth
033f232a87 Update submodule to 211.0.0 (#25489) 2024-02-23 18:12:12 +11:00
PJBot
b75ff77b49 Automatic changelog update 2024-02-23 06:54:44 +00:00
liltenhead
4ea1d21b5e Buff emergency welder (#25483)
fuel count
2024-02-23 17:53:38 +11:00
PJBot
945c8dbe2f Automatic changelog update 2024-02-23 04:05:50 +00:00
Pieter-Jan Briers
715794dd41 Make department / job list sorting consistent. (#25486)
* Make department / job list sorting consistent.

This makes late join, crew manifest and character profile all apply consistent sorting for jobs and departments.

We use the already-defined weights for departments (so command, then sec, then station specific, then just sort by prototype ID). Jobs also use weight (so heads are always at the top) then prototype ID, then character name (for manifest).

Removed the crewmanifest.ordering CVar as doing it via prototype weight is just easier, and that CVar was already a mess anyways.

* Fix jittery job icons in lists.

They were set to KeepCentered in TextureRect. This has issues because the allocated space is actually an odd number of pixels, so it tries to position the draw at a half pixel offset.

Now, yes, fixing this in TextureRect would make much more sense, but get off my back. (Ok seriously we need better helper functions for doing that in the engine. Don't wanna deal with that right now and I already have this patch made.)

Instead I'm just gonna fix the issue by using VerticalAlignment in all these places instead which ends up doing exactly the same thing YIPPEE.

Also gave a margin next to the icon on the crew manifest. Margins people!
2024-02-23 15:04:44 +11:00
Pieter-Jan Briers
b1de6dd601 Switch project files to C# 12. (#25487)
Just unlocks new language features like primary constructors.
2024-02-23 15:02:59 +11:00
MACMAN2003
2458c87b62 Add Ratvar (#24958)
* Create ratvar.yml

* restore balance to the universe

* scale issues

mfw nar-sie is smaller

* spawner + spawn anim

a shitty spawn anim is better than no spawn anim

* undenseify

no longer as dense as a dying neutron star
2024-02-23 04:42:00 +03:00
Tayrtahn
381bb9020a Add prediction to Openable (#25477)
* Fix formatting problem with FullOpened

* Moved to Shared and networked

* Revert "Fix formatting problem with FullOpened"

This reverts commit f8353403da830a4402bdd457bcf24a2432a5f566.
2024-02-23 12:09:43 +11:00
PJBot
84d9f7a6a9 Automatic changelog update 2024-02-23 01:06:17 +00:00
lzk
65687375ee Make galoshes obtainable and slowing you (#25484)
* make galoshes obtainable and slowing you

* Update specific.yml
2024-02-23 12:05:11 +11:00
Tayrtahn
146c7b272d Fix examine text bug for Openable Drinkables (#25478)
Break up Opened/Closed and fill level onto separate lines
2024-02-23 12:04:23 +11:00
Nemanja
ce0a51fc29 Predict doors and airlocks (#25419)
* predict doors and airlocks

* prying, too

* ack

* eek
2024-02-23 10:01:31 +11:00
I.K
b7747596f1 Give "DO NOT MAP" suffix to handheld crew monitor (#25473)
don'
2024-02-22 16:40:46 -05:00
PJBot
e6605a774b Automatic changelog update 2024-02-22 12:19:51 +00:00
Whisper
f38a961a1b fix reagent slime role description being friendly (#25466) 2024-02-22 15:18:46 +03:00
PJBot
2b34970445 Automatic changelog update 2024-02-22 12:00:47 +00:00
Ps3Moira
83cd1089fe Add Large Wood Floors (#25462)
Large Wood Floors
2024-02-22 14:59:41 +03:00
PJBot
7ac3a2a47d Automatic changelog update 2024-02-22 11:29:09 +00:00
lzk
35723ad22f Make even more items good looking in inventory + size changing (#25461)
* Make even more items good looking in inventory

* holoprojecrots
2024-02-22 22:28:03 +11:00
HoofedEar
487dd113b0 Add RequiresGrid component (#23394)
* saving working code

* add checks for deletion
2024-02-22 22:26:02 +11:00
PJBot
22c76bb625 Automatic changelog update 2024-02-22 11:16:16 +00:00
liltenhead
85ae40e0a4 Red flashlight color for assault borg (#25465)
assaultborglight
2024-02-22 22:15:10 +11:00
PJBot
3c25e6353d Automatic changelog update 2024-02-22 11:04:50 +00:00
J. Brown
b26e9a9a32 Fix #22933 - Job-specific Uplink items leaking to non-job minds (#23179)
Fix for 22933 - SharedMindSystem now checks for VisitingMindComponent too.
2024-02-22 22:03:44 +11:00
PJBot
c27d0c143c Automatic changelog update 2024-02-22 11:01:41 +00:00
metalgearsloth
d0df5ed5fa Revert "Remove handheld crew monitor (#24761)" (#25439)
* Revert "Remove handheld crew monitor (#24761)"

This reverts commit bbc6d29d21.

# Conflicts:
#	Resources/Prototypes/Catalog/Fills/Boxes/syndicate.yml
#	Resources/Prototypes/Entities/Structures/Machines/lathe.yml
#	Resources/Prototypes/Research/biochemical.yml
#	Resources/migration.yml

* changes

* zeweh

* dergs
2024-02-22 22:00:35 +11:00
metalgearsloth
7c7bca1d32 Remove obs kit (#24768)
Syndi handheld crew monitor got removed. Give them their own content instead of reskinning NT stuff.
2024-02-22 22:00:25 +11:00
PJBot
423b75f22c Automatic changelog update 2024-02-22 07:33:49 +00:00