Commit Graph

48 Commits

Author SHA1 Message Date
ArtisticRoomba
f874459092 Pressure Relief Valve (#36708)
* initial system (this math is probably WRONG)

* General code cleanup and OnExamined support
(holy moly this code sucks)

* UICode and related events foundation
TODO:
- Actually write the XAML UI and the underlying system
- Un-shitcode the entire thing
- Actually test everything...

* Working UI code
TODO: Make predicted, as this certainly isn't predicted. Even though I said it was. It isn't.

* Remove one TODO for unshitcoding the examine code

* Add reminder
yea

* Make predicted (defenitely isn't)
(also defenitely isn't a copypaste from pressure pump code)

* It's predicted!
TODO:
- Give it snazzy predicted visuals!
- Have a different field for pressure entry, lest it gets bulldozed every UI update.

* Improve gas pressure relief valve UI
TODO: Reminder to reduce amount of dirties using deltafields

* Implement DirtyField prediction

* Entity<T> cleanup
A lot of Entity<T> conversions and lukewarm cleanup.

Also got caught copy pasting code in 4K UHD but it's not like you couldn't tell.

* More cleanup and comments

* Remove TODO comment on bulldozing window title

* """refactoring"""
- Move appearance out of shared and finally fix it. Pointless to predict appearance in this instance.
- More Entity<T> conversions because I like them.
- Move UI creation handling over entirely to the ActivatableUI system.
- Fix a hardcoded locale string (why????).

* Add visuals

* Revert debugging variable replacememt
yea

* Revert skissue

* Remove unused using directives and remove TODO

* Localize, cleanup, document

* Fix adminlogging discrepancy

* Add ability to construct, add guidebook entry

* Clear up comment

* Add guidebook tooltip to valve

* Convert GasPressureReliefValveBoundUserInterface declaration into primary constructor

* Adds more input handling and adds autofill on open

* Un-deepfry input validator shitcode
Genuinely what was I smoking

* improve visuals logic

* Refactor again
- Update math to the correct implementation
- Moved code that could be re-used in the future into a helper method under AtmosphereSystem.Gases.cs

* I'm sorry but I hate warnings

* Remove unused using directive in AtmosphereSystem.Gases.cs

* Review and cleanup

* Lukewarm UI glossup

* Maintainer for the upstream project btw

* Remove redundant state sets and messy logic

* Unduplicate valve updater code

* Redo UI (im sorry Slarti)

* run tests

* Test refactored UI messaging

* Second round of UI improvements
- God please find a way to improve this system. Feels bad.

* Update loop implementation

* Further predict UI

* Clear up SetToCurrentThreshold

* cleanup

* Update to master + pipe layers and bug fixes
want to run tests

* fixes

* Deploy rename pipebomb

* Documentation and requested changes

* Rename the method that wiggled away

* Undo rounding changes

* Fix comment

* Rename and cleanup

* Apply suggestions from code review

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2025-07-03 18:00:34 +02:00
chromiumboy
45012cbe1d Layering for atmospheric pipes (#36124)
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
Co-authored-by: Kevin Zheng <kevinz5000@gmail.com>
2025-06-01 22:01:43 -07:00
Wolfkey-SomeoneElseTookMyUsername
e72e25aba1 Add disposal signalers (#37535)
* Add disposal signalers

* Sprite changes

* Some requested changes

* Requested changes + change spelling to be with two l's to be consistent with the remote signaller
2025-05-21 22:18:57 -04:00
K-Dynamic
ae6f96fa87 Four-way pipe junction, swapping junction construction fix (#37092)
* pipe x-junction assets, yml, construction

* remove duplicate asset

* attribution

* x junction instead of junctioncross for utilities.yml
2025-05-07 13:37:59 +02:00
Nemanja
4509821f0e [HOTFIX] Revert "Updated air scrubber and air vent sprites." (#36992)
Revert "Updated air scrubber and air vent sprites. (#34223)"

This reverts commit 3957bbb97d.
2025-04-28 11:45:19 +02:00
ScarKy0
3957bbb97d Updated air scrubber and air vent sprites. (#34223)
* vents

* slower animation

* formatting fix

* scrubber
2025-04-18 19:34:59 -04:00
Deerstop
ac0a8d1f60 Manual Valves Resprite (#34378)
* resprited manual valves to be colourblind friendly

* Update Resources/Textures/Structures/Piping/Atmospherics/pump.rsi/meta.json

Co-authored-by: Errant <35878406+Errant-4@users.noreply.github.com>

---------

Co-authored-by: Errant <35878406+Errant-4@users.noreply.github.com>
2025-01-13 08:07:29 +01:00
justdie12
ad0d790f1f Fix disposal signal routers sprites (#34139)
* Fix disposal signal routers sprites

* Remove old shitcode
2024-12-31 08:25:06 -05:00
chromiumboy
403528cbf3 Gas pipe sensors (#33128)
* Initial commit

* Monitored pipe node is now referenced by name

* Review changes

* Simplified construction

* Tweaked deconstruction to match other binary atmos devices

* Helper function removal

* Updated attribution
2024-11-21 21:46:10 -06:00
Moomoobeef
93728e4b8e fixed broken pipe sprites (#31773) 2024-09-03 17:33:46 +10:00
SlamBamActionman
6972bc26a7 Directional Fans (#27772)
* Initial commit

* Description update

* Updated texture
2024-07-20 13:18:34 +10:00
slarticodefast
cd2968d849 Add sprite for vent under-pressure lock-out (#29527) 2024-06-28 22:02:48 -07:00
slarticodefast
418fc79698 Give passive vents the correct sprite (#29536)
give passive vents the correct sprite
2024-06-28 08:33:03 -04:00
deathride58
bd3508d803 Colorblind friendly thermomachine LED colors (#29397)
Colorblind friendly thermomachines
2024-06-24 15:40:19 -07:00
Pieter-Jan Briers
67cc089dd0 Fix terrible portable scrubber unlit layers (#29232)
Jesus fucking christ man
2024-06-19 18:14:47 -04:00
Alzore
4d991d1554 Atmos pipes now deal blunt damage (#27673)
* pipe

* weak

* inhand

* IT WORKS

* inventory
2024-05-08 23:00:47 -07:00
Menshin
9884351101 Add space heaters (#25250) 2024-02-28 10:27:29 -08:00
Nemanja
a78e9a854e Hellfire Thermomachines (#23543)
* hellfire thermomachines

* slight nerf? idk

* ilya review

* Improve clarity

* Update Content.Server/Atmos/Piping/Unary/EntitySystems/GasThermoMachineSystem.cs

Co-authored-by: Kevin Zheng <kevinz5000@gmail.com>

---------

Co-authored-by: Kevin Zheng <kevinz5000@gmail.com>
2024-01-07 08:55:22 -05:00
Nemanja
d008488664 Disposals resprite [take 2] (#23418)
Disposals resprite
2024-01-02 22:33:54 -07:00
Nemanja
f538a2e34a Add reagent sources to the guidebook (#22627)
* source in my guidebook

* finish it!

* sir yes sir oorah

* network that bitch, baby
2023-12-30 23:34:59 -08:00
Alekshhh
b1c3158e01 Disposal Unit Tweak (#23067)
* trash

* fix

* yellow

* tweaks

* blue light fix
2023-12-30 12:14:20 -05:00
Nemanja
0917a9d380 Gas Condensers (#22436)
Co-authored-by: Kevin Zheng <kevinz5000@gmail.com>
2023-12-13 19:35:44 -08:00
Kevin Zheng
6444f7b7c5 Make pipes leak when destroyed (#20928)
This plugs a meta where atmos techs were fireaxing pipes to remove them without leaking their contents.
2023-12-10 23:51:45 -08:00
deltanedas
efc9d93c2f signal router (#20802)
* add signal router sprite

* DisposalSignalRouter logic

* add disposal signal router

* add disposal signal router

* how did it work without this

* death

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2023-11-14 16:30:43 -07:00
daerSeebaer
dd6b7b337f Fix sprite alignment (#20975) 2023-10-13 14:07:23 -08:00
daerSeebaer
0bb8c222bd Added blocked visuals to volumetric pump (#20610) 2023-09-29 19:35:23 -08:00
Kevin Zheng
db5dee6db3 Add radiators (#18728)
* Add radiators

* Limit heat transfer to fluid heat capacity

* Adjust datafield names

* Fix material arbitrage

* This code has been debugged, and so there are no more bugs. Debugging code is therefore unnecessary

* Adjust radiator layer subfloor visibility

* Cache CVars

* No default

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>

* Like and unsubscribe

* Fix CVar caching

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
2023-08-06 02:21:05 -06:00
Julian Giebel
48518e502f Revert "Mail resprite (#15832)" (#16861)
This reverts commit 1195c6443a.
2023-05-27 12:31:10 -05:00
Nim
1195c6443a Mail resprite (#15832) 2023-04-29 21:47:10 +10:00
Menshin
fd973be10c Thermomachines code cleaning + some QoL (#14772) 2023-04-23 13:05:32 +10:00
deltanedas
3cd30c408b add signal valve (#14830)
Co-authored-by: deltanedas <@deltanedas:kde.org>
2023-03-25 16:16:27 -07:00
Menshin
b76547e6df Fixes atmos trinary devices connectors sprites (#14248) 2023-03-06 20:08:03 -04:00
metalgearsloth
b1b3f765fa Fix the remaining invalid RSIs (#13113) 2022-12-20 11:49:18 -06:00
Pieter-Jan Briers
b707b788ac Remove trailing commas from RSIs. (#12865) 2022-12-04 22:47:23 +01:00
Julian Giebel
b2436c22a7 Adds disposal mailing units (again) (#7630) 2022-08-13 22:57:25 -07:00
Kevin Zheng
9cb7e0f6c4 Make atmos Turing-complete (#10520)
* Add pneumatic valves

Pneumatic valves permit bidirectional flow between the inlet and outlet
if the pressure at the control port is high enough.

* Add construction recipe
2022-08-11 16:19:31 -05:00
Rane
188934a748 Portable scrubbers (#9417) 2022-07-15 05:46:30 -07:00
Leon Friedrich
65408f63d4 Injector sprite fix (#9011) 2022-07-09 02:59:39 -07:00
Rane
723004a300 Tiny fans for freezers/shuttles (#9451) 2022-07-05 14:54:27 -05:00
Leon Friedrich
229627a934 Gas injector visuals & balance (#8963) 2022-06-20 19:04:55 -07:00
Vera Aguilera Puerto
cba573616b Fix some atmos pipe machinery having wrong sprites.
Removes the pipe on the sprites itself, as these device sprites are meant to be layered on top of a pipe sprite in code.
2022-03-05 11:34:52 +01:00
Leon Friedrich
3ba55d0798 Fix rotated pipe connection visuals (#6756) 2022-02-17 14:31:11 -07:00
wrexbe
94207a42e9 Make manual valves work (#6121)
* Make manual valves work

* Change some GasValveSystem lookups
2022-01-15 05:18:45 -08:00
mirrorcult
d67f89e00e Flipped mixers/filters + proper mixer sprite (#5277)
* bart simpson

* fixes + jank

* figsed
2021-11-11 20:46:40 -07:00
Julian Giebel
5b74811f28 Add high pressure machine frame rsi (#4950)
Implement Disposal machine construction graph and recepie
Restore eris disposal unit

Co-authored-by: Julian Giebel <j.giebel@netrocks.info>
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2021-10-27 21:54:12 +11:00
Swept
e34888373a Respriting the codebase (#4820)
* Walls

* Airlocks mostly ported

* Disposal Unit

* Tiles

* Lighting

* Catwalk

* Windows

* Some vending machine work

* More Vending Machines

* Rest of vending machine sprites ported

* Fixes to vending machines

* Tables (This took a lot of work)

* Fixes low walls being required for window smoothing
- Also replaces window damage visualization

* Plasma Window

* APC

* SMES + Reorganized parts.yml

* Furniture and Organization and Removed Shelf

* Renamed seats.yml to chairs.yml

* Dispensers

* Lazy-fixed the glass airlocks

* Don't need this no more

* Tilez

* blue circuit my fucking beloved

* Switches lights to cev one

* Conveyors and Switch

* Reorients lights

* !ALERT! MAP CHANGES !ALERT!

Co-authored-by: Vera Aguilera Puerto <gradientvera@outlook.com>
2021-10-15 11:58:40 +02:00
Vera Aguilera Puerto
331604cc66 GasFilter appearance, EnabledAtmosDeviceVisualizer improvements. 2021-08-02 13:20:31 +02:00
Swept
5f9ba812ca Reorganizes Resources/Constructible (#4252) 2021-07-15 18:30:50 +00:00