Make the client validate character information (#3563)

Co-authored-by: Metal Gear Sloth <metalgearsloth@gmail.com>
2021-03-08 03:07:53 +01:00
parent c60547990e
commit f682833c8d
6 changed files with 127 additions and 95 deletions
--- a/Content.Server/Preferences/ServerPreferencesManager.cs
+++ b/Content.Server/Preferences/ServerPreferencesManager.cs
@@ -48,7 +48,6 @@ namespace Content.Server.Preferences
                HandleDeleteCharacterMessage);
        }

-
        private async void HandleSelectCharacterMessage(MsgSelectCharacter message)
        {
            var index = message.SelectedCharacterIndex;
@@ -107,9 +106,11 @@ namespace Content.Server.Preferences

            var curPrefs = prefsData.Prefs!;

+            profile.EnsureValid();
+
            var profiles = new Dictionary<int, ICharacterProfile>(curPrefs.Characters)
            {
-                [slot] = HumanoidCharacterProfile.EnsureValid((HumanoidCharacterProfile) profile, _protos)
+                [slot] = profile
            };

            prefsData.Prefs = new PlayerPreferences(profiles, slot, curPrefs.AdminOOCColor);