Self-attack nerfs (#17845)

Content.Client/Weapons/Melee/MeleeWeaponSystem.cs

@@ -103,7 +103,7 @@ public sealed partial class MeleeWeaponSystem : SharedMeleeWeaponSystem
             }
 
             // If it's an unarmed attack then do a disarm
-            if (weaponUid == entity)
+            if (weapon.AltDisarm && weaponUid == entity)
             {
                 EntityUid? target = null;
 
@@ -128,7 +128,7 @@ public sealed partial class MeleeWeaponSystem : SharedMeleeWeaponSystem
                 return;
             }
 
-            // Otherwise do heavy attack if it's a weapon.
+            // Otherwise do heavy attack.
 
             // Start a windup
             if (weapon.WindUpStart == null)

Content.Shared/Weapons/Melee/MeleeWeaponComponent.cs

@@ -15,6 +15,14 @@ namespace Content.Shared.Weapons.Melee;
 [RegisterComponent, NetworkedComponent]
 public sealed class MeleeWeaponComponent : Component
 {
+    // TODO: This is becoming bloated as shit.
+    // This should just be its own component for alt attacks.
+    /// <summary>
+    /// Does this entity do a disarm on alt attack.
+    /// </summary>
+    [DataField("altDisarm"), ViewVariables(VVAccess.ReadWrite)]
+    public bool AltDisarm = true;
+
     /// <summary>
     /// Should the melee weapon's damage stats be examinable.
     /// </summary>

Content.Shared/Weapons/Melee/SharedMeleeWeaponSystem.cs

@@ -460,6 +460,11 @@ public abstract class SharedMeleeWeaponSystem : EntitySystem
             case LightAttackEvent light:
                 if (!Blocker.CanAttack(user, light.Target))
                     return false;
+
+                // Can't self-attack if you're the weapon
+                if (weaponUid == light.Target)
+                    return false;
+
                 break;
             case DisarmAttackEvent disarm:
                 if (!Blocker.CanAttack(user, disarm.Target))

Resources/Prototypes/Entities/Mobs/NPCs/carp.yml

@@ -56,6 +56,7 @@
         - id: FoodMeatFish
           amount: 2
     - type: MeleeWeapon
+      altDisarm: false
       hidden: true
       angle: 0
       animation: WeaponArcBite

Resources/Prototypes/Entities/Mobs/NPCs/xeno.yml

@@ -64,6 +64,7 @@
   - type: Bloodstream
     bloodReagent: FluorosulfuricAcid
   - type: MeleeWeapon
+    altDisarm: false
     hidden: true
     angle: 0
     soundHit:

Resources/Prototypes/Entities/Mobs/Player/dragon.yml

@@ -97,6 +97,7 @@
       path: /Audio/Animals/space_dragon_roar.ogg
     soundPerceivedByOthers: false # A 75% chance for a loud roar would get old fast.
   - type: MeleeWeapon
+    altDisarm: false
     hidden: true
     soundHit:
       path: /Audio/Weapons/Xeno/alien_claw_flesh3.ogg