Fix all ignored recipes in material arbitrage (#41134)

* lights

* drink glasses

* vial chem bottle

* plates n stuff

* boards

* airtank

---------

Co-authored-by: iaada <iaada@users.noreply.github.com>

Content.IntegrationTests/Tests/MaterialArbitrageTest.cs

@@ -28,20 +28,10 @@ namespace Content.IntegrationTests.Tests;
 [TestFixture]
 public sealed class MaterialArbitrageTest
 {
-    // These recipes are currently broken and need fixing. You should not be adding to these sets.
+    // These sets are for selectively excluding recipes from arbitrage.
-    private readonly HashSet<string> _destructionArbitrageIgnore =
+    // You should NOT be adding to these. They exist here for downstreams and potential future issues.
-    [
+    private readonly HashSet<string> _destructionArbitrageIgnore = [];
-        "BaseChemistryEmptyVial", "DrinkShotGlass", "SodiumLightTube", "DrinkGlassCoupeShaped",
+    private readonly HashSet<string> _compositionArbitrageIgnore = [];
-        "LedLightBulb", "ExteriorLightTube", "LightTube", "DrinkGlass", "DimLightBulb", "LightBulb", "LedLightTube",
-        "ChemistryEmptyBottle01", "WarmLightBulb",
-    ];
-
-    private readonly HashSet<string> _compositionArbitrageIgnore =
-    [
-        "FoodPlateSmall", "AirTank", "FoodPlateTin", "FoodPlateMuffinTin", "WeaponCapacitorRechargerCircuitboard",
-        "WeaponCapacitorRechargerCircuitboard", "BorgChargerCircuitboard", "BorgChargerCircuitboard", "FoodPlate",
-        "CellRechargerCircuitboard", "CellRechargerCircuitboard",
-    ];
 
     [Test]
     public async Task NoMaterialArbitrage()

Resources/Prototypes/Entities/Objects/Consumable/Food/Containers/plate.yml

@@ -57,7 +57,7 @@
     - Trash
   - type: PhysicalComposition
     materialComposition:
-      Glass: 60
+      Glass: 50
   - type: SpaceGarbage
 
 - type: entity
@@ -117,7 +117,7 @@
         acts: [ "Destruction" ]
   - type: PhysicalComposition
     materialComposition:
-      Glass: 30
+      Glass: 25
 
 - type: entity
   parent: FoodPlateTrash
@@ -196,7 +196,7 @@
     - Trash
   - type: PhysicalComposition
     materialComposition:
-      Steel: 60
+      Steel: 50
   - type: SpaceGarbage
 
 # Muffin Tin
@@ -220,5 +220,5 @@
     - Trash
   - type: PhysicalComposition
     materialComposition:
-      Steel: 30
+      Steel: 25
   - type: SpaceGarbage

Resources/Prototypes/Entities/Objects/Devices/Circuitboards/Machine/production.yml

@@ -663,8 +663,8 @@
         Cable: 5
     - type: PhysicalComposition
       materialComposition:
-        Steel: 30
+        Steel: 25
-        Plastic: 30
+        Plastic: 25
     - type: StaticPrice
       price: 15
 
@@ -706,8 +706,8 @@
         Cable: 5
     - type: PhysicalComposition
       materialComposition:
-        Steel: 30
+        Steel: 25
-        Plastic: 30
+        Plastic: 25
     - type: StaticPrice
       price: 15
 
@@ -727,8 +727,8 @@
         CableMV: 5
     - type: PhysicalComposition
       materialComposition:
-        Steel: 30
+        Steel: 25
-        Plastic: 30
+        Plastic: 25
     - type: StaticPrice
       price: 15
 

Resources/Prototypes/Recipes/Lathes/chemistry.yml

@@ -77,7 +77,7 @@
   result: ChemistryEmptyBottle01
   completetime: 2
   materials:
-    Glass: 50
+    Glass: 100
 
 - type: latheRecipe
   id: Vape
@@ -95,7 +95,7 @@
   result: BaseChemistryEmptyVial
   completetime: 2
   materials:
-    Glass: 50
+    Glass: 100
     Wood: 20
 
 - type: latheRecipe

Resources/Prototypes/Recipes/Lathes/cooking.yml

@@ -19,7 +19,7 @@
   id: BaseGlasswareRecipe
   completetime: 0.8
   materials:
-    Glass: 100
+    Glass: 200
 
 - type: latheRecipe
   parent: BaseGlasswareRecipe

Resources/Prototypes/Recipes/Lathes/misc.yml

@@ -8,7 +8,7 @@
   completetime: 2
   materials:
     Steel: 50
-    Glass: 50
+    Glass: 200
 
 # Recipes
 
@@ -120,7 +120,7 @@
   result: AirTank
   completetime: 4
   materials:
-    Steel: 300
+    Steel: 400
 
 - type: latheRecipe
   id: DoubleEmergencyOxygenTank