Refactor how jobs are handed out (#5422)

* Completely refactor how job spawning works * Remove remains of old system. * Squash the final bug, cleanup. * Attempt to fix tests * Adjusts packed's round-start crew roster, re-enables a bunch of old roles. Also adds the Central Command Official as a proper role. * pretty up ui * refactor StationSystem into the correct folder & namespace. * remove a log, make sure the lobby gets updated if a new map is spontaneously added. * re-add accidentally removed log * We do a little logging * we do a little resolving * we do a little documenting * Renamed OverflowJob to FallbackOverflowJob Allows stations to configure their own roundstart overflow job list. * narrator: it did not compile * oops * support having no overflow jobs * filescope for consistency * small fixes * Bumps a few role counts for Packed, namely engis * log moment * E * Update Resources/Prototypes/Entities/Objects/Misc/identification_cards.yml Co-authored-by: Leon Friedrich <60421075+ElectroJr@users.noreply.github.com> * Update Content.Server/Maps/GameMapPrototype.cs Co-authored-by: Leon Friedrich <60421075+ElectroJr@users.noreply.github.com> * factored job logic, cleanup. * e * Address reviews * Remove the concept of a "default" grid. It has no future in our new multi-station world * why was clickable using that in the first place * fix bad evil bug that almost slipped through also adds chemist * rms obsolete things from chemist * Adds a sanity fallback * address reviews * adds ability to set name * fuck * cleanup joingame
2021-11-26 03:02:46 -06:00
parent dfb329d5db
commit ec68226e99
53 changed files with 1148 additions and 705 deletions
--- a/Content.Server/Maps/IGameMapManager.cs
+++ b/Content.Server/Maps/IGameMapManager.cs
@@ -1,68 +1,67 @@
 using System.Collections.Generic;

-namespace Content.Server.Maps
+namespace Content.Server.Maps;
+
+/// <summary>
+/// Manages which station map will be used for the next round.
+/// </summary>
+public interface IGameMapManager
 {
+    void Initialize();
+
    /// <summary>
-    /// Manages which station map will be used for the next round.
+    /// Returns all maps eligible to be played right now.
    /// </summary>
-    public interface IGameMapManager
-    {
-        void Initialize();
+    /// <returns>enumerator of map prototypes</returns>
+    IEnumerable<GameMapPrototype> CurrentlyEligibleMaps();

-        /// <summary>
-        /// Returns all maps eligible to be played right now.
-        /// </summary>
-        /// <returns>enumerator of map prototypes</returns>
-        IEnumerable<GameMapPrototype> CurrentlyEligibleMaps();
+    /// <summary>
+    /// Returns all maps that can be voted for.
+    /// </summary>
+    /// <returns>enumerator of map prototypes</returns>
+    IEnumerable<GameMapPrototype> AllVotableMaps();

-        /// <summary>
-        /// Returns all maps that can be voted for.
-        /// </summary>
-        /// <returns>enumerator of map prototypes</returns>
-        IEnumerable<GameMapPrototype> AllVotableMaps();
+    /// <summary>
+    /// Returns all maps.
+    /// </summary>
+    /// <returns>enumerator of map prototypes</returns>
+    IEnumerable<GameMapPrototype> AllMaps();

-        /// <summary>
-        /// Returns all maps.
-        /// </summary>
-        /// <returns>enumerator of map prototypes</returns>
-        IEnumerable<GameMapPrototype> AllMaps();
+    /// <summary>
+    /// Attempts to select the given map.
+    /// </summary>
+    /// <param name="gameMap">map prototype</param>
+    /// <returns>success or failure</returns>
+    bool TrySelectMap(string gameMap);

-        /// <summary>
-        /// Attempts to select the given map.
-        /// </summary>
-        /// <param name="gameMap">map prototype</param>
-        /// <returns>success or failure</returns>
-        bool TrySelectMap(string gameMap);
+    /// <summary>
+    /// Forces the given map, making sure the game map manager won't reselect if conditions are no longer met at round restart.
+    /// </summary>
+    /// <param name="gameMap">map prototype</param>
+    /// <returns>success or failure</returns>
+    void ForceSelectMap(string gameMap);

-        /// <summary>
-        /// Forces the given map, making sure the game map manager won't reselect if conditions are no longer met at round restart.
-        /// </summary>
-        /// <param name="gameMap">map prototype</param>
-        /// <returns>success or failure</returns>
-        void ForceSelectMap(string gameMap);
+    /// <summary>
+    /// Selects a random map.
+    /// </summary>
+    void SelectRandomMap();

-        /// <summary>
-        /// Selects a random map.
-        /// </summary>
-        void SelectRandomMap();
+    /// <summary>
+    /// Gets the currently selected map, without double-checking if it can be used.
+    /// </summary>
+    /// <returns>selected map</returns>
+    GameMapPrototype GetSelectedMap();

-        /// <summary>
-        /// Gets the currently selected map, without double-checking if it can be used.
-        /// </summary>
-        /// <returns>selected map</returns>
-        GameMapPrototype GetSelectedMap();
+    /// <summary>
+    /// Gets the currently selected map, double-checking if it can be used.
+    /// </summary>
+    /// <returns>selected map</returns>
+    GameMapPrototype GetSelectedMapChecked(bool loud = false);

-        /// <summary>
-        /// Gets the currently selected map, double-checking if it can be used.
-        /// </summary>
-        /// <returns>selected map</returns>
-        GameMapPrototype GetSelectedMapChecked(bool loud = false);
-
-        /// <summary>
-        /// Checks if the given map exists
-        /// </summary>
-        /// <param name="gameMap">name of the map</param>
-        /// <returns>existence</returns>
-        bool CheckMapExists(string gameMap);
-    }
-}
+    /// <summary>
+    /// Checks if the given map exists
+    /// </summary>
+    /// <param name="gameMap">name of the map</param>
+    /// <returns>existence</returns>
+    bool CheckMapExists(string gameMap);
+}