tommy/tbd-station-14
2
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix cartesian explosion in pref loading (#32434)

Browse Source 
Lol .AsSingleQuery().

Some people's preferences wouldn't load on Lizard. Turns out the entire preferences set is loaded with a morbillion joins in a single query and one person had 240,000 (!!!) rows returned for their preferences query. Yeah.
This commit is contained in:
Pieter-Jan Briers
2024-09-24 22:43:02 +02:00
committed by GitHub
parent 4bca634ff6
commit e36d735064
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Content.Server/Database/ServerDbBase.cs
View File

@@ -52,7 +52,7 @@ namespace Content.Server.Database
.ThenInclude(h => h.Loadouts) .ThenInclude(h => h.Loadouts)
.ThenInclude(l => l.Groups) .ThenInclude(l => l.Groups)
.ThenInclude(group => group.Loadouts) .ThenInclude(group => group.Loadouts)
.AsSingleQuery() .AsSplitQuery()
.SingleOrDefaultAsync(p => p.UserId == userId.UserId, cancel); .SingleOrDefaultAsync(p => p.UserId == userId.UserId, cancel);
if (prefs is null) if (prefs is null)