Revise ShowAccessReadersCommand as LocalizedEntityCommands (#37991)

* revise ShowAccessReadersCommand

* don't believe this is needed anymore? hopefully servers world wide don't explode.

Content.Client/Access/Commands/ShowAccessReadersCommand.cs

@@ -4,39 +4,20 @@ using Robust.Shared.Console;
 
 namespace Content.Client.Access.Commands;
 
-public sealed class ShowAccessReadersCommand : IConsoleCommand
+public sealed class ShowAccessReadersCommand : LocalizedEntityCommands
 {
-    public string Command => "showaccessreaders";
+    [Dependency] private readonly IOverlayManager _overlay = default!;
+    [Dependency] private readonly IResourceCache _cache = default!;
+    [Dependency] private readonly SharedTransformSystem _xform = default!;
 
-    public string Description => "Toggles showing access reader permissions on the map";
+    public override string Command => "showaccessreaders";
-    public string Help => """
+
-        Overlay Info:
+    public override void Execute(IConsoleShell shell, string argStr, string[] args)
-        -Disabled | The access reader is disabled
-        +Unrestricted | The access reader has no restrictions
-        +Set [Index]: [Tag Name]| A tag in an access set (accessor needs all tags in the set to be allowed by the set)
-        +Key [StationUid]: [StationRecordKeyId] | A StationRecordKey that is allowed
-        -Tag [Tag Name] | A tag that is not allowed (takes priority over other allows)
-        """;
-    public void Execute(IConsoleShell shell, string argStr, string[] args)
     {
-        var collection = IoCManager.Instance;
+        var existing = _overlay.RemoveOverlay<AccessOverlay>();
+        if (!existing)
+            _overlay.AddOverlay(new AccessOverlay(EntityManager, _cache, _xform));
 
-        if (collection == null)
+        shell.WriteLine(Loc.GetString($"cmd-showaccessreaders-status", ("status", !existing)));
-            return;
-
-        var overlay = collection.Resolve<IOverlayManager>();
-
-        if (overlay.RemoveOverlay<AccessOverlay>())
-        {
-            shell.WriteLine($"Set access reader debug overlay to false");
-            return;
-        }
-
-        var entManager = collection.Resolve<IEntityManager>();
-        var cache = collection.Resolve<IResourceCache>();
-        var xform = entManager.System<SharedTransformSystem>();
-
-        overlay.AddOverlay(new AccessOverlay(entManager, cache, xform));
-        shell.WriteLine($"Set access reader debug overlay to true");
     }
 }

Resources/Locale/en-US/commands/show-access-readers-command.ftl

@@ -0,0 +1,9 @@
+cmd-showaccessreaders-desc = Toggles showing access reader permissions on the map
+cmd-showaccessreaders-help =
+    Overlay Info:
+    -Disabled | The access reader is disabled
+    +Unrestricted | The access reader has no restrictions
+    +Set [Index]: [Tag Name]| A tag in an access set (accessor needs all tags in the set to be allowed by the set)
+    +Key [StationUid]: [StationRecordKeyId] | A StationRecordKey that is allowed
+    -Tag [Tag Name] | A tag that is not allowed (takes priority over other allows)
+cmd-showaccessreaders-status = Set access reader debug overlay to {$status}.