Fix layers displaying in cable stacks (#4028)

* Fix layers displaying in cable stacks

Fixed stackVisualizer to use another round method

* Fix ShadowCommander review

* Change to expected Result
This commit is contained in:
Ygg01
2021-05-23 06:05:55 +02:00
committed by GitHub
parent ce70e8a38d
commit d97021d3a0
3 changed files with 94 additions and 11 deletions

View File

@@ -55,7 +55,7 @@ namespace Content.Tests.Shared.Utility
(3, 5, 2, 1),
(4, 5, 2, 2),
(5, 5, 2, 2),
// Testing even counts
(0, 6, 5, 0),
(1, 6, 5, 1),
@@ -64,7 +64,7 @@ namespace Content.Tests.Shared.Utility
(4, 6, 5, 3),
(5, 6, 5, 4),
(6, 6, 5, 5),
// Testing transparency disable use case
(0, 6, 6, 0),
(1, 6, 6, 1),
@@ -97,5 +97,54 @@ namespace Content.Tests.Shared.Utility
(double val, double max, int size, int expected) = data;
Assert.That(ContentHelpers.RoundToNearestLevels(val, max, size), Is.EqualTo(expected));
}
[Parallelizable]
[Test]
// Testing odd max on even levels
[TestCase(0, 5, 2, ExpectedResult = 0)]
[TestCase(1, 5, 2, ExpectedResult = 0)]
[TestCase(2, 5, 2, ExpectedResult = 0)]
[TestCase(3, 5, 2, ExpectedResult = 1)]
[TestCase(4, 5, 2, ExpectedResult = 1)]
[TestCase(5, 5, 2, ExpectedResult = 1)]
// Testing even max on odd levels
[TestCase(0, 6, 3, ExpectedResult = 0)]
[TestCase(1, 6, 3, ExpectedResult = 0)]
[TestCase(2, 6, 3, ExpectedResult = 1)]
[TestCase(3, 6, 3, ExpectedResult = 1)]
[TestCase(4, 6, 3, ExpectedResult = 2)]
[TestCase(5, 6, 3, ExpectedResult = 2)]
[TestCase(6, 6, 3, ExpectedResult = 2)]
// Testing even max on even levels
[TestCase(0, 4, 2, ExpectedResult = 0)]
[TestCase(1, 4, 2, ExpectedResult = 0)]
[TestCase(2, 4, 2, ExpectedResult = 1)]
[TestCase(3, 4, 2, ExpectedResult = 1)]
[TestCase(4, 4, 2, ExpectedResult = 1)]
// Testing odd max on odd levels
[TestCase(0, 5, 3, ExpectedResult = 0)]
[TestCase(1, 5, 3, ExpectedResult = 0)]
[TestCase(2, 5, 3, ExpectedResult = 1)]
[TestCase(3, 5, 3, ExpectedResult = 1)]
[TestCase(4, 5, 3, ExpectedResult = 2)]
// Larger odd max on odd levels
[TestCase(0, 7, 3, ExpectedResult = 0)]
[TestCase(1, 7, 3, ExpectedResult = 0)]
[TestCase(2, 7, 3, ExpectedResult = 0)]
[TestCase(3, 7, 3, ExpectedResult = 1)]
[TestCase(4, 7, 3, ExpectedResult = 1)]
[TestCase(5, 7, 3, ExpectedResult = 2)]
[TestCase(6, 7, 3, ExpectedResult = 2)]
[TestCase(7, 7, 3, ExpectedResult = 2)]
// Testing edge cases
[TestCase(0.1, 6, 5, ExpectedResult = 0)]
[TestCase(-32, 6, 5, ExpectedResult = 0)]
[TestCase(2.4, 6, 5, ExpectedResult = 1)]
[TestCase(2.5, 6, 5, ExpectedResult = 2)]
[TestCase(320, 6, 5, ExpectedResult = 4)]
public int TestEqual(double val, double max, int size)
{
return ContentHelpers.RoundToEqualLevels(val, max, size);
}
}
}