From d957cdb144ff0fe0147bc8a3c46ad3c93f50dfe6 Mon Sep 17 00:00:00 2001 From: Tayrtahn Date: Tue, 13 May 2025 21:57:01 -0400 Subject: [PATCH] Cleanup warnings in `AirlockSystem` (#37434) Cleanup warnings in AirlockSystem --- Content.Client/Doors/AirlockSystem.cs | 40 ++++++++++++++------------- 1 file changed, 21 insertions(+), 19 deletions(-) diff --git a/Content.Client/Doors/AirlockSystem.cs b/Content.Client/Doors/AirlockSystem.cs index 712bdd1bec..7be15bd88f 100644 --- a/Content.Client/Doors/AirlockSystem.cs +++ b/Content.Client/Doors/AirlockSystem.cs @@ -10,6 +10,7 @@ namespace Content.Client.Doors; public sealed class AirlockSystem : SharedAirlockSystem { [Dependency] private readonly AppearanceSystem _appearanceSystem = default!; + [Dependency] private readonly SpriteSystem _sprite = default!; public override void Initialize() { @@ -21,7 +22,7 @@ public sealed class AirlockSystem : SharedAirlockSystem private void OnComponentStartup(EntityUid uid, AirlockComponent comp, ComponentStartup args) { // Has to be on component startup because we don't know what order components initialize in and running this before DoorComponent inits _will_ crash. - if(!TryComp(uid, out var door)) + if (!TryComp(uid, out var door)) return; if (comp.OpenUnlitVisible) // Otherwise there are flashes of the fallback sprite between clicking on the door and the door closing animation starting. @@ -31,17 +32,17 @@ public sealed class AirlockSystem : SharedAirlockSystem } ((Animation)door.OpeningAnimation).AnimationTracks.Add(new AnimationTrackSpriteFlick() - { - LayerKey = DoorVisualLayers.BaseUnlit, - KeyFrames = { new AnimationTrackSpriteFlick.KeyFrame(comp.OpeningSpriteState, 0f) }, - } + { + LayerKey = DoorVisualLayers.BaseUnlit, + KeyFrames = { new AnimationTrackSpriteFlick.KeyFrame(comp.OpeningSpriteState, 0f) }, + } ); ((Animation)door.ClosingAnimation).AnimationTracks.Add(new AnimationTrackSpriteFlick() - { - LayerKey = DoorVisualLayers.BaseUnlit, - KeyFrames = { new AnimationTrackSpriteFlick.KeyFrame(comp.ClosingSpriteState, 0f) }, - } + { + LayerKey = DoorVisualLayers.BaseUnlit, + KeyFrames = { new AnimationTrackSpriteFlick.KeyFrame(comp.ClosingSpriteState, 0f) }, + } ); door.DenyingAnimation = new Animation() @@ -57,19 +58,19 @@ public sealed class AirlockSystem : SharedAirlockSystem } }; - if(!comp.AnimatePanel) + if (!comp.AnimatePanel) return; ((Animation)door.OpeningAnimation).AnimationTracks.Add(new AnimationTrackSpriteFlick() { LayerKey = WiresVisualLayers.MaintenancePanel, - KeyFrames = {new AnimationTrackSpriteFlick.KeyFrame(comp.OpeningPanelSpriteState, 0f)}, + KeyFrames = { new AnimationTrackSpriteFlick.KeyFrame(comp.OpeningPanelSpriteState, 0f) }, }); ((Animation)door.ClosingAnimation).AnimationTracks.Add(new AnimationTrackSpriteFlick { LayerKey = WiresVisualLayers.MaintenancePanel, - KeyFrames = {new AnimationTrackSpriteFlick.KeyFrame(comp.ClosingPanelSpriteState, 0f)}, + KeyFrames = { new AnimationTrackSpriteFlick.KeyFrame(comp.ClosingPanelSpriteState, 0f) }, }); } @@ -101,11 +102,12 @@ public sealed class AirlockSystem : SharedAirlockSystem && !boltedVisible && !emergencyLightsVisible; } - args.Sprite.LayerSetVisible(DoorVisualLayers.BaseUnlit, unlitVisible); - args.Sprite.LayerSetVisible(DoorVisualLayers.BaseBolted, boltedVisible); + _sprite.LayerSetVisible((uid, args.Sprite), DoorVisualLayers.BaseUnlit, unlitVisible); + _sprite.LayerSetVisible((uid, args.Sprite), DoorVisualLayers.BaseBolted, boltedVisible); if (comp.EmergencyAccessLayer) { - args.Sprite.LayerSetVisible( + _sprite.LayerSetVisible( + (uid, args.Sprite), DoorVisualLayers.BaseEmergencyAccess, emergencyLightsVisible && state != DoorState.Open @@ -118,12 +120,12 @@ public sealed class AirlockSystem : SharedAirlockSystem switch (state) { case DoorState.Open: - args.Sprite.LayerSetState(DoorVisualLayers.BaseUnlit, comp.ClosingSpriteState); - args.Sprite.LayerSetAnimationTime(DoorVisualLayers.BaseUnlit, 0); + _sprite.LayerSetRsiState((uid, args.Sprite), DoorVisualLayers.BaseUnlit, comp.ClosingSpriteState); + _sprite.LayerSetAnimationTime((uid, args.Sprite), DoorVisualLayers.BaseUnlit, 0); break; case DoorState.Closed: - args.Sprite.LayerSetState(DoorVisualLayers.BaseUnlit, comp.OpeningSpriteState); - args.Sprite.LayerSetAnimationTime(DoorVisualLayers.BaseUnlit, 0); + _sprite.LayerSetRsiState((uid, args.Sprite), DoorVisualLayers.BaseUnlit, comp.OpeningSpriteState); + _sprite.LayerSetAnimationTime((uid, args.Sprite), DoorVisualLayers.BaseUnlit, 0); break; } }