tommy/tbd-station-14
2
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix GasOverlayData equals (#3834)

Browse Source 
Was never returning true.
This commit is contained in:
metalgearsloth
2021-04-12 23:01:17 +10:00
committed by GitHub
parent ef863fe471
commit d71cae470a
1 changed files with 3 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
Content.Shared/GameObjects/EntitySystems/Atmos/SharedGasTileOverlaySystem.cs
View File

@@ -76,22 +76,9 @@ namespace Content.Shared.GameObjects.EntitySystems.Atmos
public bool Equals(GasOverlayData other) public bool Equals(GasOverlayData other)
{ {
// If you revert this then you need to make sure the hash comparison between
if (HashCode != other.HashCode) return false; // our Gas[] and the other.Gas[] works.
if (Gas.Length != other.Gas.Length) return false; return HashCode == other.HashCode;
if (FireState != other.FireState) return false;
if (MathHelper.CloseTo(FireTemperature, FireTemperature)) return false;
if (Gas.GetHashCode() != other.Gas.GetHashCode()) return false;
for (var i = 0; i < Gas.Length; i++)
{
var gas = Gas[i];
var otherGas = other.Gas[i];
if (!gas.Equals(otherGas))
return false;
}
return true;
} }
} }