tommy/tbd-station-14
2
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't create new JsonSerializerOptions for every discord webhook (#31240)

Browse Source 
*sigh*
This commit is contained in:
Pieter-Jan Briers
2024-08-20 23:32:11 +02:00
committed by GitHub
parent df95be1ce5
commit d63115d1f7
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
Content.Server/Discord/DiscordWebhook.cs
View File

@@ -8,6 +8,9 @@ namespace Content.Server.Discord;
public sealed class DiscordWebhook : IPostInjectInit public sealed class DiscordWebhook : IPostInjectInit
{ {
private static readonly JsonSerializerOptions JsonOptions = new JsonSerializerOptions
{ DefaultIgnoreCondition = JsonIgnoreCondition.WhenWritingNull };
[Dependency] private readonly ILogManager _log = default!; [Dependency] private readonly ILogManager _log = default!;
private const string BaseUrl = "https://discord.com/api/v10/webhooks"; private const string BaseUrl = "https://discord.com/api/v10/webhooks";
@@ -68,7 +71,7 @@ public sealed class DiscordWebhook : IPostInjectInit
public async Task<HttpResponseMessage> CreateMessage(WebhookIdentifier identifier, WebhookPayload payload) public async Task<HttpResponseMessage> CreateMessage(WebhookIdentifier identifier, WebhookPayload payload)
{ {
var url = $"{GetUrl(identifier)}?wait=true"; var url = $"{GetUrl(identifier)}?wait=true";
var response = await _http.PostAsJsonAsync(url, payload, new JsonSerializerOptions { DefaultIgnoreCondition = JsonIgnoreCondition.WhenWritingNull }); var response = await _http.PostAsJsonAsync(url, payload, JsonOptions);
LogResponse(response, "Create"); LogResponse(response, "Create");
@@ -101,7 +104,7 @@ public sealed class DiscordWebhook : IPostInjectInit
public async Task<HttpResponseMessage> EditMessage(WebhookIdentifier identifier, ulong messageId, WebhookPayload payload) public async Task<HttpResponseMessage> EditMessage(WebhookIdentifier identifier, ulong messageId, WebhookPayload payload)
{ {
var url = $"{GetUrl(identifier)}/messages/{messageId}"; var url = $"{GetUrl(identifier)}/messages/{messageId}";
var response = await _http.PatchAsJsonAsync(url, payload, new JsonSerializerOptions { DefaultIgnoreCondition = JsonIgnoreCondition.WhenWritingNull }); var response = await _http.PatchAsJsonAsync(url, payload, JsonOptions);
LogResponse(response, "Edit"); LogResponse(response, "Edit");