tommy/tbd-station-14
2
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve CreateDeleteCreateTest failure messages (#40996)

Browse Source 
* Improve CreateDeleteCreateTest failure messages

* nameof
This commit is contained in:
Leon Friedrich
2025-11-02 13:10:52 +13:00
committed by GitHub
parent 6f253bcf04
commit d5a46b9824
1 changed files with 101 additions and 93 deletions
Download Patch File Download Diff File Expand all files Collapse all files

194
Content.IntegrationTests/Tests/Lobby/CharacterCreationTest.cs
View File

@@ -1,114 +1,122 @@
using Content.Client.Lobby;
using Content.Server.Preferences.Managers;
using Content.Shared.Humanoid;
using Content.Shared.Preferences;
using Robust.Client.State;
using Robust.Shared.Network;
namespace Content.IntegrationTests.Tests.Lobby
namespace Content.IntegrationTests.Tests.Lobby;
[TestFixture]
[TestOf(typeof(ClientPreferencesManager))]
[TestOf(typeof(ServerPreferencesManager))]
public sealed class CharacterCreationTest
{
[TestFixture]
[TestOf(typeof(ClientPreferencesManager))]
[TestOf(typeof(ServerPreferencesManager))]
public sealed class CharacterCreationTest
[Test]
public async Task CreateDeleteCreateTest()
{
[Test]
public async Task CreateDeleteCreateTest()
await using var pair = await PoolManager.GetServerClient(new PoolSettings { InLobby = true });
var server = pair.Server;
var client = pair.Client;
var user = pair.Client.User!.Value;
var clientPrefManager = client.Resolve<IClientPreferencesManager>();
var serverPrefManager = server.Resolve<IServerPreferencesManager>();
Assert.That(client.Resolve<IStateManager>().CurrentState, Is.TypeOf<LobbyState>());
await client.WaitPost(() => clientPrefManager.SelectCharacter(0));
await pair.RunTicksSync(5);
var clientCharacters = clientPrefManager.Preferences?.Characters;
Assert.That(clientCharacters, Is.Not.Null);
Assert.That(clientCharacters, Has.Count.EqualTo(1));
HumanoidCharacterProfile profile = null;
await client.WaitPost(() =>
{
await using var pair = await PoolManager.GetServerClient(new PoolSettings { InLobby = true });
var server = pair.Server;
var client = pair.Client;
profile = HumanoidCharacterProfile.Random();
clientPrefManager.CreateCharacter(profile);
});
await pair.RunTicksSync(5);
var clientNetManager = client.ResolveDependency<IClientNetManager>();
var clientStateManager = client.ResolveDependency<IStateManager>();
var clientPrefManager = client.ResolveDependency<IClientPreferencesManager>();
clientCharacters = clientPrefManager.Preferences?.Characters;
Assert.That(clientCharacters, Is.Not.Null);
Assert.That(clientCharacters, Has.Count.EqualTo(2));
AssertEqual(clientCharacters[1], profile);
var serverPrefManager = server.ResolveDependency<IServerPreferencesManager>();
await PoolManager.WaitUntil(server, () => serverPrefManager.GetPreferences(user).Characters.Count == 2, maxTicks: 60);
var serverCharacters = serverPrefManager.GetPreferences(user).Characters;
Assert.That(serverCharacters, Has.Count.EqualTo(2));
AssertEqual(serverCharacters[1], profile);
// Need to run them in sync to receive the messages.
await pair.RunTicksSync(1);
await client.WaitAssertion(() => clientPrefManager.DeleteCharacter(1));
await pair.RunTicksSync(5);
Assert.That(clientPrefManager.Preferences?.Characters.Count, Is.EqualTo(1));
await PoolManager.WaitUntil(server, () => serverPrefManager.GetPreferences(user).Characters.Count == 1, maxTicks: 60);
Assert.That(serverPrefManager.GetPreferences(user).Characters.Count, Is.EqualTo(1));
await PoolManager.WaitUntil(client, () => clientStateManager.CurrentState is LobbyState, 600);
await client.WaitIdleAsync();
Assert.That(clientNetManager.ServerChannel, Is.Not.Null);
await client.WaitAssertion(() =>
{
profile = HumanoidCharacterProfile.Random();
clientPrefManager.CreateCharacter(profile);
});
await pair.RunTicksSync(5);
var clientNetId = clientNetManager.ServerChannel.UserId;
HumanoidCharacterProfile profile = null;
clientCharacters = clientPrefManager.Preferences?.Characters;
Assert.That(clientCharacters, Is.Not.Null);
Assert.That(clientCharacters, Has.Count.EqualTo(2));
AssertEqual(clientCharacters[1], profile);
await client.WaitAssertion(() =>
{
clientPrefManager.SelectCharacter(0);
await PoolManager.WaitUntil(server, () => serverPrefManager.GetPreferences(user).Characters.Count == 2, maxTicks: 60);
serverCharacters = serverPrefManager.GetPreferences(user).Characters;
Assert.That(serverCharacters, Has.Count.EqualTo(2));
AssertEqual(serverCharacters[1], profile);
await pair.CleanReturnAsync();
}
var clientCharacters = clientPrefManager.Preferences?.Characters;
Assert.That(clientCharacters, Is.Not.Null);
Assert.Multiple(() =>
{
Assert.That(clientCharacters, Has.Count.EqualTo(1));
private void AssertEqual(ICharacterProfile clientCharacter, HumanoidCharacterProfile b)
{
if (clientCharacter.MemberwiseEquals(b))
return;
Assert.That(clientStateManager.CurrentState, Is.TypeOf<LobbyState>());
});
profile = HumanoidCharacterProfile.Random();
clientPrefManager.CreateCharacter(profile);
clientCharacters = clientPrefManager.Preferences?.Characters;
Assert.That(clientCharacters, Is.Not.Null);
Assert.That(clientCharacters, Has.Count.EqualTo(2));
Assert.That(clientCharacters[1].MemberwiseEquals(profile));
});
await PoolManager.WaitUntil(server, () => serverPrefManager.GetPreferences(clientNetId).Characters.Count == 2, maxTicks: 60);
await server.WaitAssertion(() =>
{
var serverCharacters = serverPrefManager.GetPreferences(clientNetId).Characters;
Assert.That(serverCharacters, Has.Count.EqualTo(2));
Assert.That(serverCharacters[1].MemberwiseEquals(profile));
});
await client.WaitAssertion(() =>
{
clientPrefManager.DeleteCharacter(1);
var clientCharacters = clientPrefManager.Preferences?.Characters.Count;
Assert.That(clientCharacters, Is.EqualTo(1));
});
await PoolManager.WaitUntil(server, () => serverPrefManager.GetPreferences(clientNetId).Characters.Count == 1, maxTicks: 60);
await server.WaitAssertion(() =>
{
var serverCharacters = serverPrefManager.GetPreferences(clientNetId).Characters.Count;
Assert.That(serverCharacters, Is.EqualTo(1));
});
await client.WaitIdleAsync();
await client.WaitAssertion(() =>
{
profile = HumanoidCharacterProfile.Random();
clientPrefManager.CreateCharacter(profile);
var clientCharacters = clientPrefManager.Preferences?.Characters;
Assert.That(clientCharacters, Is.Not.Null);
Assert.That(clientCharacters, Has.Count.EqualTo(2));
Assert.That(clientCharacters[1].MemberwiseEquals(profile));
});
await PoolManager.WaitUntil(server, () => serverPrefManager.GetPreferences(clientNetId).Characters.Count == 2, maxTicks: 60);
await server.WaitAssertion(() =>
{
var serverCharacters = serverPrefManager.GetPreferences(clientNetId).Characters;
Assert.That(serverCharacters, Has.Count.EqualTo(2));
Assert.That(serverCharacters[1].MemberwiseEquals(profile));
});
await pair.CleanReturnAsync();
if (clientCharacter is not HumanoidCharacterProfile a)
{
Assert.Fail($"Not a {nameof(HumanoidCharacterProfile)}");
return;
}
Assert.Multiple(() =>
{
Assert.That(a.Name, Is.EqualTo(b.Name));
Assert.That(a.Age, Is.EqualTo(b.Age));
Assert.That(a.Sex, Is.EqualTo(b.Sex));
Assert.That(a.Gender, Is.EqualTo(b.Gender));
Assert.That(a.Species, Is.EqualTo(b.Species));
Assert.That(a.PreferenceUnavailable, Is.EqualTo(b.PreferenceUnavailable));
Assert.That(a.SpawnPriority, Is.EqualTo(b.SpawnPriority));
Assert.That(a.FlavorText, Is.EqualTo(b.FlavorText));
Assert.That(a.JobPriorities, Is.EquivalentTo(b.JobPriorities));
Assert.That(a.AntagPreferences, Is.EquivalentTo(b.AntagPreferences));
Assert.That(a.TraitPreferences, Is.EquivalentTo(b.TraitPreferences));
Assert.That(a.Loadouts, Is.EquivalentTo(b.Loadouts));
AssertEqual(a.Appearance, b.Appearance);
Assert.Fail("Profile not equal");
});
}
private void AssertEqual(HumanoidCharacterAppearance a, HumanoidCharacterAppearance b)
{
if (a.MemberwiseEquals(b))
return;
Assert.That(a.HairStyleId, Is.EqualTo(b.HairStyleId));
Assert.That(a.HairColor, Is.EqualTo(b.HairColor));
Assert.That(a.FacialHairStyleId, Is.EqualTo(b.FacialHairStyleId));
Assert.That(a.FacialHairColor, Is.EqualTo(b.FacialHairColor));
Assert.That(a.EyeColor, Is.EqualTo(b.EyeColor));
Assert.That(a.SkinColor, Is.EqualTo(b.SkinColor));
Assert.That(a.Markings, Is.EquivalentTo(b.Markings));
Assert.Fail("Appearance not equal");
}
}