Fix item/clothing visual & networking bugs (#10116)

Content.Shared/Light/SharedHandheldLightSystem.cs

@@ -0,0 +1,79 @@
+using Content.Shared.Actions;
+using Content.Shared.Clothing.EntitySystems;
+using Content.Shared.Item;
+using Content.Shared.Toggleable;
+using Robust.Shared.Audio;
+using Robust.Shared.GameStates;
+using Robust.Shared.Player;
+using Robust.Shared.Utility;
+
+namespace Content.Shared.Light;
+
+public abstract class SharedHandheldLightSystem : EntitySystem
+{
+    [Dependency] private readonly SharedItemSystem _itemSys = default!;
+    [Dependency] private readonly ClothingSystem _clothingSys = default!;
+    [Dependency] private readonly SharedActionsSystem _actionSystem = default!;
+
+    public override void Initialize()
+    {
+        base.Initialize();
+        SubscribeLocalEvent<HandheldLightComponent, ComponentInit>(OnInit);
+        SubscribeLocalEvent<HandheldLightComponent, ComponentHandleState>(OnHandleState);
+    }
+
+    private void OnInit(EntityUid uid, HandheldLightComponent component, ComponentInit args)
+    {
+        UpdateVisuals(uid, component);
+
+        // Want to make sure client has latest data on level so battery displays properly.
+        Dirty(component);
+    }
+
+    private void OnHandleState(EntityUid uid, HandheldLightComponent component, ref ComponentHandleState args)
+    {
+        if (args.Current is not HandheldLightComponent.HandheldLightComponentState state)
+            return;
+
+        component.Level = state.Charge;
+        SetActivated(uid, state.Activated, component, false);
+    }
+
+    public void SetActivated(EntityUid uid, bool activated, HandheldLightComponent? component = null, bool makeNoise = true)
+    {
+        if (!Resolve(uid, ref component))
+            return;
+
+        if (component.Activated == activated)
+            return;
+
+        component.Activated = activated;
+
+        if (makeNoise)
+        {
+            var sound = component.Activated ? component.TurnOnSound : component.TurnOffSound;
+            SoundSystem.Play(sound.GetSound(), Filter.Pvs(component.Owner, entityManager: EntityManager), component.Owner);
+        }
+            
+        Dirty(component);
+        UpdateVisuals(uid, component);
+    }
+
+    public void UpdateVisuals(EntityUid uid, HandheldLightComponent? component = null, AppearanceComponent? appearance = null)
+    {
+        if (!Resolve(uid, ref component, ref appearance, false))
+            return;
+
+        if (component.AddPrefix)
+        {
+            var prefix = component.Activated ? "on" : "off";
+            _itemSys.SetHeldPrefix(uid, prefix);
+            _clothingSys.SetEquippedPrefix(uid, prefix);
+        }
+
+        if (component.ToggleAction != null)
+            _actionSystem.SetToggled(component.ToggleAction, component.Activated);
+
+        appearance.SetData(ToggleableLightVisuals.Enabled, component.Activated);
+    }
+}