Fix antag shitcurity (#5441)

* fix jobs

* Antagn't the heads and sec

* good to go, time to test my code

Content.Server/GameTicking/Presets/PresetTraitor.cs

@@ -8,6 +8,7 @@ using Content.Server.Items;
 using Content.Server.Objectives.Interfaces;
 using Content.Server.PDA;
 using Content.Server.Players;
+using Content.Server.Roles;
 using Content.Server.Traitor;
 using Content.Server.Traitor.Uplink;
 using Content.Server.Traitor.Uplink.Account;
@@ -72,7 +73,10 @@ namespace Content.Server.GameTicking.Presets
                 return false;
             }
 
-            var list = new List<IPlayerSession>(readyPlayers);
+            var list = new List<IPlayerSession>(readyPlayers).Where(x =>
+                x.Data.ContentData()?.Mind?.AllRoles.All(role => role is not Job {CanBeAntag: false}) ?? false
+            ).ToList();
+
             var prefList = new List<IPlayerSession>();
 
             foreach (var player in list)

Content.Server/Roles/Job.cs

@@ -14,10 +14,13 @@ namespace Content.Server.Roles
 
         public string? StartingGear => Prototype.StartingGear;
 
+        public bool CanBeAntag;
+
         public Job(Mind.Mind mind, JobPrototype jobPrototype) : base(mind)
         {
             Prototype = jobPrototype;
             Name = jobPrototype.Name;
+            CanBeAntag = jobPrototype.CanBeAntag;
         }
 
         public override void Greet()

Content.Shared/Roles/JobPrototype.cs

@@ -33,6 +33,9 @@ namespace Content.Shared.Roles
         [DataField("requireAdminNotify")]
         public bool RequireAdminNotify { get; } = false;
 
+        [DataField("canBeAntag")]
+        public bool CanBeAntag { get; } = true;
+
         /// <summary>
         ///     Whether this job is a head.
         ///     The job system will try to pick heads before other jobs on the same priority level.

Resources/Prototypes/Roles/Jobs/Command/captain.yml

@@ -10,6 +10,7 @@
   requireAdminNotify: true
   joinNotifyCrew: true
   supervisors: "Nanotrasen officials"
+  canBeAntag: false
   access:
   # All of em.
   # Could probably do with some kind of wildcard or whatever to automate this.

Resources/Prototypes/Roles/Jobs/Command/head_of_personnel.yml

@@ -9,6 +9,7 @@
   icon: "HeadOfPersonnel"
   requireAdminNotify: true
   supervisors: "the captain"
+  canBeAntag: false
   access:
   - Command
   - HeadOfPersonnel

Resources/Prototypes/Roles/Jobs/Engineering/chief_engineer.yml

@@ -10,6 +10,7 @@
   icon: "ChiefEngineer"
   requireAdminNotify: true
   supervisors: "the captain"
+  canBeAntag: false
   access:
   - Maintenance
   - Engineering

Resources/Prototypes/Roles/Jobs/Medical/chief_medical_officer.yml

@@ -12,6 +12,7 @@
   icon: "ChiefMedicalOfficer"
   requireAdminNotify: true
   supervisors: "the captain"
+  canBeAntag: false
   access:
   - Medical
   - Command

Resources/Prototypes/Roles/Jobs/Science/research_director.yml

@@ -10,6 +10,7 @@
   icon: "ResearchDirector"
   requireAdminNotify: true
   supervisors: "the captain"
+  canBeAntag: false
   access:
   - Research
   - Command

Resources/Prototypes/Roles/Jobs/Security/head_of_security.yml

@@ -10,6 +10,7 @@
   icon: "HeadOfSecurity"
   requireAdminNotify: true
   supervisors: "the captain"
+  canBeAntag: false
   access:
   - Command
   - Brig

Resources/Prototypes/Roles/Jobs/Security/security_officer.yml

@@ -8,6 +8,7 @@
   - Security
   icon: "SecurityOfficer"
   supervisors: "the head of security"
+  canBeAntag: false
   access:
   - Security
   - Maintenance