tommy/tbd-station-14
2
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove bogus C# finalizers (#28315)

Browse Source 
Begging people to learn how this programming language works before throwing random syntax into a file.

None of these finalizers ever worked. I also checked whether they were memory leaks and needed *proper* shutdown logic, but they're all instantiated-once UI controls that last for the entire lifetime of the program so it's probably fine.
This commit is contained in:
Pieter-Jan Briers
2024-05-27 23:52:23 +02:00
committed by GitHub
parent 224af2af0e
commit cf8fcb170a
3 changed files with 0 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Content.Client/Interaction/DragDropHelper.cs
View File

@@ -73,11 +73,6 @@ public sealed class DragDropHelper<T>
_cfg.OnValueChanged(CCVars.DragDropDeadZone, SetDeadZone, true); _cfg.OnValueChanged(CCVars.DragDropDeadZone, SetDeadZone, true);
} }
~DragDropHelper()
{
_cfg.UnsubValueChanged(CCVars.DragDropDeadZone, SetDeadZone);
}
/// <summary> /// <summary>
/// Tell the helper that the mouse button was pressed down on /// Tell the helper that the mouse button was pressed down on
/// a target, thus a drag has the possibility to begin for this target. /// a target, thus a drag has the possibility to begin for this target.

5
Content.Client/UserInterface/Systems/Actions/Controls/ActionButtonContainer.cs
View File

@@ -119,9 +119,4 @@ public class ActionButtonContainer : GridContainer
yield return button; yield return button;
} }
} }
~ActionButtonContainer()
{
UserInterfaceManager.GetUIController<ActionUIController>().RemoveActionContainer();
}
} }

5
Content.Client/UserInterface/Systems/Inventory/Controls/ItemSlotButtonContainer.cs
View File

@@ -22,9 +22,4 @@ public sealed class ItemSlotButtonContainer : ItemSlotUIContainer<SlotControl>
{ {
_inventoryController = UserInterfaceManager.GetUIController<InventoryUIController>(); _inventoryController = UserInterfaceManager.GetUIController<InventoryUIController>();
} }
~ItemSlotButtonContainer()
{
_inventoryController.RemoveSlotGroup(SlotGroup);
}
} }