Hotfix storage arbitrage (#10652)

Content.IntegrationTests/Tests/StorageTest.cs

@@ -1,14 +1,42 @@
 #nullable enable
 using System.Threading.Tasks;
 using Content.Server.Storage.Components;
+using Content.Shared.Item;
+using Content.Shared.Storage;
 using NUnit.Framework;
 using Robust.Shared.Prototypes;
 
 namespace Content.IntegrationTests.Tests
 {
     [TestFixture]
-    public sealed class StorageFillTest
+    public sealed class StorageTest
     {
+        /// <summary>
+        /// Can an item store more than itself weighs.
+        /// In an ideal world this test wouldn't need to exist because sizes would be recursive.
+        /// </summary>
+        [Test]
+        public async Task StorageSizeArbitrageTest()
+        {
+            await using var pairTracker = await PoolManager.GetServerClient(new PoolSettings{NoClient = true});
+            var server = pairTracker.Pair.Server;
+
+            var protoManager = server.ResolveDependency<IPrototypeManager>();
+
+            await server.WaitAssertion(() =>
+            {
+                foreach (var proto in protoManager.EnumeratePrototypes<EntityPrototype>())
+                {
+                    if (!proto.TryGetComponent<ServerStorageComponent>("Storage", out var storage) ||
+                        storage.Whitelist != null ||
+                        !proto.TryGetComponent<ItemComponent>("Item", out var item)) continue;
+
+                    Assert.That(storage.StorageCapacityMax, Is.LessThanOrEqualTo(item.Size), $"Found storage arbitrage on {proto.ID}");
+                }
+            });
+            await pairTracker.CleanReturnAsync();
+        }
+
         [Test]
         public async Task TestStorageFillPrototypes()
         {

Resources/Prototypes/Entities/Clothing/Back/backpacks.yml

@@ -191,4 +191,4 @@
   - type: Clothing
     equippedPrefix: holding
   - type: Storage
-    capacity: 10000
+    capacity: 9999

Resources/Prototypes/Entities/Clothing/Back/duffel.yml

@@ -157,4 +157,4 @@
     - state: icon-unlit
       shader: unshaded
   - type: Storage
-    capacity: 10000
+    capacity: 9999

Resources/Prototypes/Entities/Clothing/Back/satchel.yml

@@ -101,4 +101,4 @@
     - state: icon-unlit
       shader: unshaded
   - type: Storage
-    capacity: 10000
+    capacity: 9999

Resources/Prototypes/Entities/Clothing/Belt/belts.yml

@@ -391,6 +391,8 @@
     sprite: Clothing/Belt/bandolier.rsi
   - type: Clothing
     sprite: Clothing/Belt/bandolier.rsi
+  - type: Item
+    size: 60
   - type: Storage
     capacity: 60
     whitelist:
@@ -432,6 +434,8 @@
     sprite: Clothing/Belt/syndieholster.rsi
   - type: Clothing
     sprite: Clothing/Belt/syndieholster.rsi
+  - type: Item
+    size: 60
   - type: Storage
     capacity: 60
     whitelist:
@@ -473,6 +477,8 @@
     sprite: Clothing/Belt/militarywebbingmed.rsi
   - type: Clothing
     sprite: Clothing/Belt/militarywebbingmed.rsi
+  - type: Item
+    size: 60
   - type: Storage
     capacity: 60
 

Resources/Prototypes/Entities/Clothing/OuterClothing/base_clothingouter.yml

@@ -28,6 +28,8 @@
   parent: ClothingOuterBase
   id: ClothingOuterStorageBase
   components:
+  - type: Item
+    size: 10
   - type: Storage
     capacity: 10
   - type: ContainerContainer

Resources/Prototypes/Entities/Objects/Tools/matches.yml

@@ -62,6 +62,7 @@
   - type: Item
     sprite: Objects/Tools/matches.rsi
     heldPrefix: matchbox
+    size: 10
   - type: StorageFill
     contents:
       - id: Matchstick