tommy/tbd-station-14
2
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix: obsolete warnings in SharedAbsorbentSystem (#40885)

Browse Source 
* fix: formating warnings

* split GetAbsorbentReagents into string and protoid

* fix: changed SplitSolutionWhitout [obsolete] to use new method

* fix: missing using directive after merge

* Replaced methods with ProtoId variant
This commit is contained in:
kin98
2025-11-10 12:30:24 +01:00
committed by GitHub
parent 3dc0d0080d
commit ce226b0c16
5 changed files with 21 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
Content.Shared/Chemistry/EntitySystems/SharedSolutionContainerSystem.cs
View File

@@ -858,7 +858,7 @@ public abstract partial class SharedSolutionContainerSystem : EntitySystem
args.PushMarkup(Loc.GetString(entity.Comp.LocPhysicalQuality,
("color", colorHex),
("desc", primary.LocalizedPhysicalDescription),
("chemCount", solution.Contents.Count) ));
("chemCount", solution.Contents.Count)));
// Push the recognizable reagents
@@ -1048,7 +1048,7 @@ public abstract partial class SharedSolutionContainerSystem : EntitySystem
public bool EnsureSolution(
Entity<MetaDataComponent?> entity,
string name,
[NotNullWhen(true)]out Solution? solution,
[NotNullWhen(true)] out Solution? solution,
FixedPoint2 maxVol = default)
{
return EnsureSolution(entity, name, maxVol, null, out _, out solution);
@@ -1058,7 +1058,7 @@ public abstract partial class SharedSolutionContainerSystem : EntitySystem
Entity<MetaDataComponent?> entity,
string name,
out bool existed,
[NotNullWhen(true)]out Solution? solution,
[NotNullWhen(true)] out Solution? solution,
FixedPoint2 maxVol = default)
{
return EnsureSolution(entity, name, maxVol, null, out existed, out solution);
@@ -1240,13 +1240,13 @@ public abstract partial class SharedSolutionContainerSystem : EntitySystem
}
else
{
dissolvedSol.RemoveReagent(reagent,amtChange);
dissolvedSol.RemoveReagent(reagent, amtChange);
}
UpdateChemicals(dissolvedSolution);
}
public FixedPoint2 GetReagentQuantityFromConcentration(Entity<SolutionComponent> dissolvedSolution,
FixedPoint2 volume,float concentration)
FixedPoint2 volume, float concentration)
{
var dissolvedSol = dissolvedSolution.Comp.Solution;
if (volume == 0