Fix combat action prediction (#19152)

* Fix action predictions

* Add ActionsAddedTest

Content.IntegrationTests/Tests/Actions/ActionsAddedTest.cs

@@ -0,0 +1,64 @@
+using System.Linq;
+using Content.Shared.Actions;
+using Content.Shared.Actions.ActionTypes;
+using Content.Shared.CombatMode;
+using Robust.Server.Player;
+using Robust.Shared.GameObjects;
+
+namespace Content.IntegrationTests.Tests.Actions;
+
+/// <summary>
+/// This tests checks that actions properly get added to an entity's actions component..
+/// </summary>
+[TestFixture]
+public sealed class ActionsAddedTest
+{
+    // TODO add magboot test (inventory action)
+    // TODO add ghost toggle-fov test (client-side action)
+
+    [Test]
+    public async Task TestCombatActionsAdded()
+    {
+        await using var pair = await PoolManager.GetServerClient(new PoolSettings { Connected = true, DummyTicker = false});
+        var server = pair.Server;
+        var client = pair.Client;
+        var sEntMan = server.ResolveDependency<IEntityManager>();
+        var cEntMan = client.ResolveDependency<IEntityManager>();
+        var session = server.ResolveDependency<IPlayerManager>().ServerSessions.Single();
+
+        // Dummy ticker is disabled - client should be in control of a normal mob.
+        Assert.NotNull(session.AttachedEntity);
+        var ent = session.AttachedEntity!.Value;
+        Assert.That(sEntMan.EntityExists(ent));
+        Assert.That(cEntMan.EntityExists(ent));
+        Assert.That(sEntMan.HasComponent<ActionsComponent>(ent));
+        Assert.That(cEntMan.HasComponent<ActionsComponent>(ent));
+        Assert.That(sEntMan.HasComponent<CombatModeComponent>(ent));
+        Assert.That(cEntMan.HasComponent<CombatModeComponent>(ent));
+
+        var sComp = sEntMan.GetComponent<ActionsComponent>(ent);
+        var cComp = cEntMan.GetComponent<ActionsComponent>(ent);
+
+        // Mob should have a combat-mode action.
+        // This action should have a non-null event both on the server & client.
+        var evType = typeof(ToggleCombatActionEvent);
+
+        var sActions = sComp!.Actions.Where(
+            x => x is InstantAction act && act.Event?.GetType() == evType).ToArray();
+        var cActions = cComp!.Actions.Where(
+            x => x is InstantAction act && act.Event?.GetType() == evType).ToArray();
+
+        Assert.That(sActions.Length, Is.EqualTo(1));
+        Assert.That(cActions.Length, Is.EqualTo(1));
+
+        var sAct = (InstantAction) sActions[0];
+        var cAct = (InstantAction) cActions[0];
+
+        // Finally, these two actions are not the same object
+        // required, because integration tests do not respect the [NonSerialized] attribute and will simply events by reference.
+        Assert.That(ReferenceEquals(sAct, cAct), Is.False);
+        Assert.That(ReferenceEquals(sAct.Event, cAct.Event), Is.False);
+
+        await pair.CleanReturnAsync();
+    }
+}