From a88730fcfa75f926a044661c9ff950ea955e01c0 Mon Sep 17 00:00:00 2001
From: lzk <124214523+lzk228@users.noreply.github.com>
Date: Fri, 15 Dec 2023 21:46:56 +0100
Subject: [PATCH] cleanup PDA yaml (#22470)

* Update pda.yml

* Update pda.yml

* :trollface:
---
 .../Entities/Objects/Devices/pda.yml          | 71 +++++--------------
 1 file changed, 19 insertions(+), 52 deletions(-)

diff --git a/Resources/Prototypes/Entities/Objects/Devices/pda.yml b/Resources/Prototypes/Entities/Objects/Devices/pda.yml
index c2a977642e..76096f0396 100644
--- a/Resources/Prototypes/Entities/Objects/Devices/pda.yml
+++ b/Resources/Prototypes/Entities/Objects/Devices/pda.yml
@@ -100,6 +100,15 @@
     - DoorBumpOpener
   - type: Input
     context: "human"
+    
+- type: entity
+  parent: BasePDA
+  id: BaseMedicalPDA
+  components:
+  - type: HealthAnalyzer
+    scanDelay: 1
+    scanningEndSound:
+      path: "/Audio/Items/Medical/healthscanner.ogg"
 
 - type: entity
   parent: BasePDA
@@ -129,7 +138,7 @@
     state: pda-interntech
 
 - type: entity
-  parent: BasePDA
+  parent: BaseMedicalPDA
   id: MedicalInternPDA
   name: medical intern PDA
   description: Why isn't it white? Has a built-in health analyzer.
@@ -142,10 +151,6 @@
     accentVColor: "#447987"
   - type: Icon
     state: pda-internmed
-  - type: HealthAnalyzer
-    scanDelay: 1
-    scanningEndSound:
-      path: "/Audio/Items/Medical/healthscanner.ogg"
   - type: GuideHelp
     guides:
     - Medical Doctor
@@ -279,7 +284,7 @@
   - type: Pda
     id: MimeIDCard
     state: pda-mime
-    idSlot:
+    idSlot: #  rewrite without sound because mime
       name: ID Card
       whitelist:
         components:
@@ -476,7 +481,7 @@
     state: pda-engineer
 
 - type: entity
-  parent: BasePDA
+  parent: BaseMedicalPDA
   id: CMOPDA
   name: chief medical officer PDA
   description: Extraordinarily shiny and sterile. Has a built-in health analyzer.
@@ -490,13 +495,9 @@
     accentVColor: "#447987"
   - type: Icon
     state: pda-cmo
-  - type: HealthAnalyzer
-    scanDelay: 1
-    scanningEndSound:
-      path: "/Audio/Items/Medical/healthscanner.ogg"
 
 - type: entity
-  parent: BasePDA
+  parent: BaseMedicalPDA
   id: MedicalPDA
   name: medical PDA
   description: Shiny and sterile. Has a built-in health analyzer.
@@ -509,16 +510,12 @@
     accentVColor: "#447987"
   - type: Icon
     state: pda-medical
-  - type: HealthAnalyzer
-    scanDelay: 1
-    scanningEndSound:
-      path: "/Audio/Items/Medical/healthscanner.ogg"
   - type: GuideHelp
     guides:
     - Medical Doctor
 
 - type: entity
-  parent: BasePDA
+  parent: BaseMedicalPDA
   id: ParamedicPDA
   name: paramedic PDA
   description: Shiny and sterile. Has a built-in rapid health analyzer.
@@ -531,13 +528,9 @@
     accentVColor: "#2a4b5b"
   - type: Icon
     state: pda-paramedic
-  - type: HealthAnalyzer
-    scanDelay: 1
-    scanningEndSound:
-      path: "/Audio/Items/Medical/healthscanner.ogg"
-
+    
 - type: entity
-  parent: BasePDA
+  parent: BaseMedicalPDA
   id: ChemistryPDA
   name: chemistry PDA
   description: It has a few discolored blotches here and there.
@@ -550,10 +543,6 @@
     accentVColor: "#B34200"
   - type: Icon
     state: pda-chemistry
-  - type: HealthAnalyzer
-    scanDelay: 1
-    scanningEndSound:
-      path: "/Audio/Items/Medical/healthscanner.ogg"
 
 - type: entity
   parent: BasePDA
@@ -764,47 +753,38 @@
   components:
   - type: Pda
     id: ERTChaplainIDCard
-    state: pda-ert
 
 - type: entity
   parent: ERTLeaderPDA
   id: ERTEngineerPDA
-  name: ERT PDA
   suffix: Engineer
   components:
   - type: Pda
     id: ERTEngineerIDCard
-    state: pda-ert
 
 - type: entity
   parent: ERTLeaderPDA
   id: ERTJanitorPDA
-  name: ERT PDA
   suffix: Janitor
   components:
   - type: Pda
     id: ERTJanitorIDCard
-    state: pda-ert
 
 - type: entity
   parent: ERTLeaderPDA
   id: ERTMedicPDA
-  name: ERT PDA
   suffix: Medic
   components:
   - type: Pda
     id: ERTMedicIDCard
-    state: pda-ert
 
 - type: entity
   parent: ERTLeaderPDA
   id: ERTSecurityPDA
-  name: ERT PDA
   suffix: Security
   components:
   - type: Pda
     id: ERTSecurityIDCard
-    state: pda-ert
 
 - type: entity
   parent: ERTLeaderPDA
@@ -814,7 +794,6 @@
   components:
   - type: Pda
     id: CBURNIDcard
-    state: pda-ert
   - type: PdaBorderColor
     borderColor: "#A32D26"
     accentHColor: "#447987"
@@ -893,7 +872,7 @@
     state: pda-detective
 
 - type: entity
-  parent: BasePDA
+  parent: BaseMedicalPDA
   id: BrigmedicPDA
   name: brigmedic PDA
   description: I wonder whose pulse is on the screen? I hope he doesnt stop... PDA has a built-in health analyzer.
@@ -907,10 +886,6 @@
     accentVColor: "#d7d7d0"
   - type: Icon
     state: pda-brigmedic
-  - type: HealthAnalyzer
-    scanDelay: 1
-    scanningEndSound:
-      path: "/Audio/Items/Medical/healthscanner.ogg"
 
 - type: entity
   parent: ClownPDA
@@ -967,7 +942,7 @@
     state: pda-seniorresearcher
 
 - type: entity
-  parent: BasePDA
+  parent: BaseMedicalPDA
   id: SeniorPhysicianPDA
   name: senior physician PDA
   description: Smells faintly like iron and chemicals. Has a built-in health analyzer.
@@ -981,10 +956,6 @@
     accentVColor: "#B34200"
   - type: Icon
     state: pda-seniorphysician
-  - type: HealthAnalyzer
-    scanDelay: 1
-    scanningEndSound:
-      path: "/Audio/Items/Medical/healthscanner.ogg"
 
 - type: entity
   parent: BasePDA
@@ -1014,7 +985,7 @@
     state: pda-pirate
 
 - type: entity
-  parent: BasePDA
+  parent: BaseMedicalPDA
   id: SyndiAgentPDA
   name: syndicate agent PDA
   description: For those days when healing normal syndicates aren't enough, try healing nuclear operatives instead!
@@ -1038,7 +1009,3 @@
       whitelist:
         components:
           - Cartridge
-  - type: HealthAnalyzer 
-    scanDelay: 1
-    scanningEndSound:
-      path: "/Audio/Items/Medical/healthscanner.ogg"