Atmos pipe rework (#3833)
* Initial * Cleanup a bunch of things * some changes dunno * RequireAnchored * a * stuff * more work * Lots of progress * delete pipe visualizer * a * b * pipenet and pipenode cleanup * Fixes * Adds GasValve * Adds GasMiner * Fix stuff, maybe? * More fixes * Ignored components on the client * Adds thermomachine behavior, change a bunch of stuff * Remove Anchored * some work, but it's shitcode * significantly more ECS * ECS AtmosDevices * Cleanup * fix appearance * when the pipe direction is sus * Gas tanks and canisters * pipe anchoring and stuff * coding is my passion * Unsafe pipes take longer to unanchor * turns out we're no longer using eris canisters * Gas canister inserted tank appearance, improvements * Work on a bunch of appearances * Scrubber appearance * Reorganize AtmosphereSystem.Piping into a bunch of different systems * Appearance for vent/scrubber/pump turns off when leaving atmosphere * ThermoMachine appearance * Cleanup gas tanks * Remove passive gate unused imports * remove old canister UI functionality * PipeNode environment air, make everything use AssumeAir instead of merging manually * a * Reorganize atmos to follow new structure * ????? * Canister UI, restructure client * Restructure shared * Fix build tho * listen, at least the canister UI works entirely... * fix build : ) * Atmos device prototypes have names and descriptions * gas canister ui slider doesn't jitter * trinary prototypes * sprite for miners * ignore components * fix YAML * Fix port system doing useless thing * Fix build * fix thinking moment * fix build again because * canister direction * pipenode is a word * GasTank Air will throw on invalid states * fix build.... * Unhardcode volume pump thresholds * Volume pump and filter take time into account * Rename Join/Leave atmosphere events to AtmosDeviceEnabled/Disabled Event * Gas tank node volume is set by initial mixtuer * I love node container
This commit is contained in:
committed by
GitHub
parent
cfc3f2e7fc
commit
a2b737d945
@@ -72,11 +72,14 @@ namespace Content.Server.NodeContainer.NodeGroups
|
||||
newGroup.CombineGroup(this);
|
||||
return;
|
||||
}
|
||||
|
||||
OnGivingNodesForCombine(newGroup);
|
||||
|
||||
foreach (var node in Nodes)
|
||||
{
|
||||
node.NodeGroup = newGroup;
|
||||
}
|
||||
|
||||
Removed = true;
|
||||
}
|
||||
|
||||
@@ -90,7 +93,9 @@ namespace Content.Server.NodeContainer.NodeGroups
|
||||
{
|
||||
node.ClearNodeGroup();
|
||||
}
|
||||
var newGroups = new List<INodeGroup>();
|
||||
|
||||
var newGroups = new HashSet<INodeGroup>();
|
||||
|
||||
foreach (var node in Nodes)
|
||||
{
|
||||
if (node.TryAssignGroupIfNeeded())
|
||||
@@ -99,7 +104,9 @@ namespace Content.Server.NodeContainer.NodeGroups
|
||||
newGroups.Add(node.NodeGroup);
|
||||
}
|
||||
}
|
||||
|
||||
AfterRemake(newGroups);
|
||||
|
||||
Removed = true;
|
||||
}
|
||||
|
||||
@@ -111,7 +118,7 @@ namespace Content.Server.NodeContainer.NodeGroups
|
||||
|
||||
protected virtual void AfterRemake(IEnumerable<INodeGroup> newGroups) { }
|
||||
|
||||
private class NullNodeGroup : INodeGroup
|
||||
protected class NullNodeGroup : INodeGroup
|
||||
{
|
||||
public IReadOnlyList<Node> Nodes => _nodes;
|
||||
private readonly List<Node> _nodes = new();
|
||||
|
||||
Reference in New Issue
Block a user