tommy/tbd-station-14
2
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix preferences sent to client not being sanitized (#27789)

Browse Source 
Fucking whoops

In #27742 I made it so sanitization of character profiles was moved to be *after* database load. Except that means I moved it to be after the copy of all character profiles got sent to the client.

Move the sending to *also* be in that second load stage, and rename it. Fixes the issue.
This commit is contained in:
Pieter-Jan Briers
2024-05-08 04:24:54 +02:00
committed by GitHub
parent ab1a2de367
commit 9efe4dc701
3 changed files with 16 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Content.Server/Preferences/Managers/IServerPreferencesManager.cs
View File

@@ -12,7 +12,7 @@ namespace Content.Server.Preferences.Managers
void Init();
Task LoadData(ICommonSession session, CancellationToken cancel);
void SanitizeData(ICommonSession session);
void FinishLoad(ICommonSession session);
void OnClientDisconnected(ICommonSession session);
bool TryGetCachedPreferences(NetUserId userId, [NotNullWhen(true)] out PlayerPreferences? playerPreferences);