tommy/tbd-station-14
2
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve gas constants test (#37749)

Browse Source 
* improve gas constants test

* fix test fail

* review
This commit is contained in:
slarticodefast
2025-05-23 15:46:41 +02:00
committed by GitHub
parent 8565966b53
commit 95f1fae8c0
1 changed files with 39 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
Content.IntegrationTests/Tests/Atmos/ConstantsTest.cs
View File

@@ -1,20 +1,20 @@
using System.Linq; using System.Linq;
using Content.Server.Atmos.EntitySystems; using Content.Server.Atmos.EntitySystems;
using Content.Shared.Atmos; using Content.Shared.Atmos;
using Robust.Shared.GameObjects; using Content.Shared.Atmos.Prototypes;
namespace Content.IntegrationTests.Tests.Atmos namespace Content.IntegrationTests.Tests.Atmos;
[TestOf(typeof(Atmospherics))]
public sealed class ConstantsTest
{ {
[TestFixture]
[TestOf(typeof(Atmospherics))]
public sealed class ConstantsTest
{
[Test] [Test]
public async Task TotalGasesTest() public async Task TotalGasesTest()
{ {
await using var pair = await PoolManager.GetServerClient(); await using var pair = await PoolManager.GetServerClient();
var server = pair.Server; var server = pair.Server;
var entityManager = server.ResolveDependency<IEntityManager>(); var entityManager = server.EntMan;
var protoManager = server.ProtoMan;
await server.WaitPost(() => await server.WaitPost(() =>
{ {
@@ -22,11 +22,32 @@ namespace Content.IntegrationTests.Tests.Atmos
Assert.Multiple(() => Assert.Multiple(() =>
{ {
Assert.That(atmosSystem.Gases.Count(), Is.EqualTo(Atmospherics.TotalNumberOfGases)); // adding new gases needs a few changes in the code, so make sure this is done everywhere
Assert.That(Enum.GetValues(typeof(Gas)), Has.Length.EqualTo(Atmospherics.TotalNumberOfGases)); var gasProtos = protoManager.EnumeratePrototypes<GasPrototype>().ToList();
// number of gas prototypes
Assert.That(gasProtos, Has.Count.EqualTo(Atmospherics.TotalNumberOfGases),
$"Number of GasPrototypes is not equal to TotalNumberOfGases.");
// number of gas prototypes used in the atmos system
Assert.That(atmosSystem.Gases.Count(), Is.EqualTo(Atmospherics.TotalNumberOfGases),
$"AtmosSystem.Gases is not equal to TotalNumberOfGases.");
// enum mapping gases to their Id
Assert.That(Enum.GetValues<Gas>(), Has.Length.EqualTo(Atmospherics.TotalNumberOfGases),
$"Gas enum size is not equal to TotalNumberOfGases.");
// localized abbreviations for UI purposes
Assert.That(Atmospherics.GasAbbreviations, Has.Count.EqualTo(Atmospherics.TotalNumberOfGases),
$"GasAbbreviations size is not equal to TotalNumberOfGases.");
// the ID for each gas has to be a number from 0 to TotalNumberOfGases-1
foreach (var gas in gasProtos)
{
var validInteger = int.TryParse(gas.ID, out var number);
Assert.That(validInteger, Is.True, $"GasPrototype {gas.ID} has an invalid ID. It has to be an integer between 0 and TotalNumberOfGases - 1.");
Assert.That(number, Is.InRange(0, Atmospherics.TotalNumberOfGases - 1), $"GasPrototype {gas.ID} has an invalid ID. It has to be an integer between 0 and TotalNumberOfGases - 1.");
}
}); });
}); });
await pair.CleanReturnAsync(); await pair.CleanReturnAsync();
} }
}
} }