Misc changes from replay branch (#12581)

Content.Client/Eye/EyeLerpingSystem.cs

@@ -32,6 +32,7 @@ public sealed class EyeLerpingSystem : EntitySystem
         UpdatesAfter.Add(typeof(TransformSystem));
         UpdatesAfter.Add(typeof(PhysicsSystem));
         UpdatesBefore.Add(typeof(EyeUpdateSystem));
+        UpdatesOutsidePrediction = true;
     }
 
     private void OnEyeStartup(EntityUid uid, EyeComponent component, ComponentStartup args)

Content.Client/Instruments/InstrumentSystem.cs

@@ -265,7 +265,7 @@ public sealed class InstrumentSystem : SharedInstrumentSystem
             instrument.SequenceStartTick = midiEv.MidiEvent.Min(x => x.Tick) - 1;
         }
 
-        var sqrtLag = MathF.Sqrt(_netManager.ServerChannel!.Ping / 1000f);
+        var sqrtLag = MathF.Sqrt((_netManager.ServerChannel?.Ping ?? 0)/ 1000f);
         var delay = (uint) (renderer.SequencerTimeScale * (.2 + sqrtLag));
         var delta = delay - instrument.SequenceStartTick;
 

Content.Client/Light/RgbLightControllerSystem.cs

@@ -151,7 +151,7 @@ namespace Content.Client.Light
 
         private void ResetOriginalColors(EntityUid uid, RgbLightControllerComponent? rgb = null, PointLightComponent? light = null, SpriteComponent? sprite = null)
         {
-            if (!Resolve(uid, ref rgb, ref sprite, ref light))
+            if (!Resolve(uid, ref rgb, ref sprite, ref light, false))
                 return;
 
             light.Color = rgb.OriginalLightColor;

Content.Client/Outline/InteractionOutlineSystem.cs

@@ -110,7 +110,7 @@ public sealed class InteractionOutlineSystem : EntitySystem
         // Potentially change someday? who knows.
         var currentState = _stateManager.CurrentState;
 
-        if (currentState is not GameplayState screen) return;
+        if (currentState is not GameplayStateBase screen) return;
 
         EntityUid? entityToClick = null;
         var renderScale = 1;

Content.Client/UserInterface/Systems/Actions/ActionUIController.cs

@@ -311,11 +311,11 @@ public sealed class ActionUIController : UIController, IOnStateChanged<GameplayS
 
         if (_window != null)
         {
-            _window.OnOpen += OnWindowOpened;
-            _window.OnClose += OnWindowClosed;
-            _window.ClearButton.OnPressed += OnClearPressed;
-            _window.SearchBar.OnTextChanged += OnSearchChanged;
-            _window.FilterButton.OnItemSelected += OnFilterSelected;
+            _window.OnOpen -= OnWindowOpened;
+            _window.OnClose -= OnWindowClosed;
+            _window.ClearButton.OnPressed -= OnClearPressed;
+            _window.SearchBar.OnTextChanged -= OnSearchChanged;
+            _window.FilterButton.OnItemSelected -= OnFilterSelected;
 
             _window.Dispose();
             _window = null;

Content.Client/UserInterface/Systems/Character/CharacterUIController.cs

@@ -155,7 +155,7 @@ public sealed class CharacterUIController : UIController, IOnStateEntered<Gamepl
 
     private void CloseWindow()
     {
-        _window!.Close();
+        _window?.Close();
     }
 
     private void ToggleWindow()

Content.Server/UserInterface/ActivatableUIComponent.cs

@@ -40,18 +40,21 @@ namespace Content.Server.UserInterface
         ///     This should probably be true for most machines & computers, but there will still be UIs that represent a
         ///     more generic interaction / configuration that might not require hands.
         /// </remarks>
+        [ViewVariables(VVAccess.ReadWrite)]
         [DataField("requireHands")]
         public bool RequireHands = true;
 
         /// <summary>
         ///     Whether spectators (non-admin ghosts) should be allowed to view this UI.
         /// </summary>
+        [ViewVariables(VVAccess.ReadWrite)]
         [DataField("allowSpectator")]
         public bool AllowSpectator = true;
 
         /// <summary>
         ///     Whether the UI should close when the item is deselected due to a hand swap or drop
         /// </summary>
+        [ViewVariables(VVAccess.ReadWrite)]
         [DataField("closeOnHandDeselect")]
         public bool CloseOnHandDeselect = true;
 

Content.Shared/Administration/AdminFrozenSystem.cs

@@ -7,6 +7,7 @@ using Content.Shared.Physics.Pull;
 using Content.Shared.Pulling;
 using Content.Shared.Pulling.Components;
 using Content.Shared.Pulling.Events;
+using Content.Shared.Stunnable;
 using Content.Shared.Throwing;
 
 namespace Content.Shared.Administration;
@@ -29,6 +30,7 @@ public sealed class AdminFrozenSystem : EntitySystem
         SubscribeLocalEvent<AdminFrozenComponent, UpdateCanMoveEvent>(OnUpdateCanMove);
         SubscribeLocalEvent<AdminFrozenComponent, PullAttemptEvent>(OnPullAttempt);
         SubscribeLocalEvent<AdminFrozenComponent, AttackAttemptEvent>(OnAttempt);
+        SubscribeLocalEvent<AdminFrozenComponent, ChangeDirectionAttemptEvent>(OnAttempt);
     }
 
     private void OnAttempt(EntityUid uid, AdminFrozenComponent component, CancellableEntityEventArgs args)

Content.Shared/Interaction/RotateToFaceSystem.cs

@@ -80,8 +80,7 @@ namespace Content.Shared.Interaction
 
         public bool TryFaceAngle(EntityUid user, Angle diffAngle, TransformComponent? xform = null)
         {
-            // TODO: MobState should be handling CanChangeDirection's event
-            if (_actionBlockerSystem.CanChangeDirection(user) && !_mobState.IsIncapacitated(user))
+            if (_actionBlockerSystem.CanChangeDirection(user))
             {
                 if (!Resolve(user, ref xform))
                     return false;

Content.Shared/Interaction/SharedInteractionSystem.cs

@@ -227,7 +227,7 @@ namespace Content.Shared.Interaction
             if (target != null && Deleted(target.Value))
                 return;
 
-            if (TryComp(user, out SharedCombatModeComponent? combatMode) && combatMode.IsInCombatMode)
+            if (!altInteract && TryComp(user, out SharedCombatModeComponent? combatMode) && combatMode.IsInCombatMode)
             {
                 // Eat the input
                 return;

Content.Shared/Stunnable/SharedStunSystem.cs

@@ -58,6 +58,7 @@ namespace Content.Shared.Stunnable
             SubscribeLocalEvent<KnockedDownComponent, TileFrictionEvent>(OnKnockedTileFriction);
 
             // Attempt event subscriptions.
+            SubscribeLocalEvent<StunnedComponent, ChangeDirectionAttemptEvent>(OnAttempt);
             SubscribeLocalEvent<StunnedComponent, UpdateCanMoveEvent>(OnMoveAttempt);
             SubscribeLocalEvent<StunnedComponent, InteractionAttemptEvent>(OnAttempt);
             SubscribeLocalEvent<StunnedComponent, UseAttemptEvent>(OnAttempt);

Content.Shared/Verbs/SharedVerbSystem.cs

@@ -168,6 +168,9 @@ namespace Content.Shared.Verbs
                     RaiseLocalEvent(verb.ExecutionEventArgs);
             }
 
+            if (Deleted(user) || Deleted(target))
+                return;
+
             // Perform any contact interactions
             if (verb.DoContactInteraction ?? (verb.DefaultDoContactInteraction && _interactionSystem.InRangeUnobstructed(user, target)))
                 _interactionSystem.DoContactInteraction(user, target);