Decouple Lights from Toggleable Visuals (and headphone music notes bugfix) (#35341)
* - Combine enum keys `ToggleableLightVisuals` and `ToggleVisuals` into `ToggleableVisuals` - Rename `ToggleableLightVisualsComponent` to `ToggleableVisualsComponent` and `ToggleableLightVisualsSystem` to `ToggleableVisualsSystem` - (The `SpriteLayer` field on the component is now required because the old default of `light` doesn't make sense anymore) - Make it so that `ToggleableVisualsComponent` works even when there's not a light attached to the entity - (Amazingly this seems to have only applied to Headphones, but I can only imagine there are many other things people would like to do with simple toggleable visuals) - Explicitly make `ItemTogglePointLightComponent`'s purpose to make `ToggleVisualsComponent` apply to `PointLightComponent`s on the same entity. - Add field `ToggleableVisualsColorModulatesLights`, which makes the `Color` appearance value of `ToggleableVisuals` modulate the color of lights on the same entity - Lots of prototype updates to uptake the above * fix bad merge * unbork robust * blindly letting rider reformat stuff * I guess I never cleaned up these imports at all
This commit is contained in:
@@ -1,12 +1,18 @@
|
||||
using Content.Shared.Item.ItemToggle.Components;
|
||||
using Robust.Shared.GameStates;
|
||||
using Content.Shared.Toggleable;
|
||||
|
||||
namespace Content.Shared.Light.Components;
|
||||
|
||||
/// <summary>
|
||||
/// Toggles point light on an entity whenever ItemToggle hits.
|
||||
/// Makes <see cref="ItemToggledEvent"/> enable and disable point lights on this entity.
|
||||
/// </summary>
|
||||
[RegisterComponent, NetworkedComponent]
|
||||
public sealed partial class ItemTogglePointLightComponent : Component
|
||||
{
|
||||
|
||||
/// <summary>
|
||||
/// When true, causes the color specified in <see cref="ToggleableVisuals.Color"/>
|
||||
/// be used to modulate the color of lights on this entity.
|
||||
/// </summary>
|
||||
[DataField] public bool ToggleableVisualsColorModulatesLights = false;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user