Refactor Game Modes (#5819)

Content.Server/GameTicking/GameTicker.GameRule.cs

@@ -1,5 +1,5 @@
-using System;
 using System.Collections.Generic;
+using System.Linq;
 using Content.Server.GameTicking.Rules;
 using Robust.Shared.ViewVariables;
 
@@ -7,66 +7,68 @@ namespace Content.Server.GameTicking
 {
     public partial class GameTicker
     {
-        [ViewVariables] private readonly List<GameRule> _gameRules = new();
-        public IEnumerable<GameRule> ActiveGameRules => _gameRules;
+        // No duplicates.
+        [ViewVariables] private readonly HashSet<GameRulePrototype> _gameRules = new();
+        public IEnumerable<GameRulePrototype> ActiveGameRules => _gameRules;
 
-        public T AddGameRule<T>() where T : GameRule, new()
+        public bool AddGameRule(GameRulePrototype rule)
         {
-            var instance = _dynamicTypeFactory.CreateInstance<T>();
-
-            _gameRules.Add(instance);
-            instance.Added();
-
-            RaiseLocalEvent(new GameRuleAddedEvent(instance));
-
-            return instance;
-        }
-
-        public bool HasGameRule(string? name)
-        {
-            if (name == null)
+            if (!_gameRules.Add(rule))
                 return false;
 
-            foreach (var rule in _gameRules)
-            {
-                if (rule.GetType().Name == name)
-                {
-                    return true;
-                }
-            }
-
-            return false;
+            RaiseLocalEvent(new GameRuleAddedEvent(rule));
+            return true;
         }
 
-        public bool HasGameRule(Type? type)
+        public bool RemoveGameRule(GameRulePrototype rule)
         {
-            if (type == null || !typeof(GameRule).IsAssignableFrom(type))
+            if (!_gameRules.Remove(rule))
                 return false;
 
-            foreach (var rule in _gameRules)
+            RaiseLocalEvent(new GameRuleRemovedEvent(rule));
+            return true;
+        }
+
+        public bool HasGameRule(GameRulePrototype rule)
+        {
+            return _gameRules.Contains(rule);
+        }
+
+        public bool HasGameRule(string rule)
+        {
+            foreach (var ruleProto in _gameRules)
             {
-                if (rule.GetType().IsAssignableFrom(type))
+                if (ruleProto.ID.Equals(rule))
                     return true;
             }
 
             return false;
         }
 
-        public void RemoveGameRule(GameRule rule)
+        public void ClearGameRules()
         {
-            if (_gameRules.Contains(rule)) return;
-
-            rule.Removed();
-
-            _gameRules.Remove(rule);
+            foreach (var rule in _gameRules.ToArray())
+            {
+                RemoveGameRule(rule);
+            }
         }
     }
 
     public class GameRuleAddedEvent
     {
-        public GameRule Rule { get; }
+        public GameRulePrototype Rule { get; }
 
-        public GameRuleAddedEvent(GameRule rule)
+        public GameRuleAddedEvent(GameRulePrototype rule)
+        {
+            Rule = rule;
+        }
+    }
+
+    public class GameRuleRemovedEvent
+    {
+        public GameRulePrototype Rule { get; }
+
+        public GameRuleRemovedEvent(GameRulePrototype rule)
         {
             Rule = rule;
         }