tommy/tbd-station-14
2
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix Hands Crash (#122)

Browse Source 
* Fixed sprite issues with construction system (Thanks PJB!).

* Storage and Hands Systems now subscribe to Transform Parent changes, and will keep their containers in sync.

* Add check in Interaction System to prevent processing client-side entities on the server.
This commit is contained in:
Acruid
2018-11-11 11:32:05 -08:00
committed by Pieter-Jan Briers
parent 4720182cf4
commit 8038ebe37d
11 changed files with 108 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
Content.Server/GameObjects/EntitySystems/Click/InteractionSystem.cs
View File

@@ -139,7 +139,13 @@ namespace Content.Server.GameObjects.EntitySystems
// client sanitization
if(!coords.IsValidLocation())
{
Logger.InfoS("interaction", $"Invalid Coordinates: client={session}, coords={coords}");
Logger.InfoS("system.interaction", $"Invalid Coordinates: client={session}, coords={coords}");
return;
}
if (uid.IsClientSide())
{
Logger.WarningS("system.interaction", $"Client sent interaction with client-side entity. Session={session}, Uid={uid}");
return;
}
@@ -169,8 +175,8 @@ namespace Content.Server.GameObjects.EntitySystems
{
return;
}
var item = hands.GetActiveHand?.Owner;
var item = hands.GetActiveHand?.Owner;
if (!MobCanInteract(player))
return;