Deprecate IActionBlocker ChangeDirectionAttempt (#4851)

* Deprecate IActionBlocker ChangeDirectionAttempt

* Woops

Content.Shared/ActionBlocker/ActionBlockerSystem.cs

@@ -272,15 +272,6 @@ namespace Content.Shared.ActionBlocker
 
             RaiseLocalEvent(entity.Uid, ev);
 
-            foreach (var blocker in ev.Entity.GetAllComponents<IActionBlocker>())
-            {
-                if (!blocker.CanChangeDirection())
-                {
-                    ev.Cancel();
-                    break;
-                }
-            }
-
             return !ev.Cancelled;
         }
 

Content.Shared/ActionBlocker/IActionBlocker.cs

@@ -39,8 +39,5 @@ namespace Content.Shared.ActionBlocker
 
         [Obsolete("Use UnequipAttemptEvent instead")]
         bool CanUnequip() => true;
-
-        [Obsolete("Use ChangeDirectionAttemptEvent instead")]
-        bool CanChangeDirection() => true;
     }
 }

Content.Shared/Buckle/Components/SharedBuckleComponent.cs

@@ -1,5 +1,4 @@
 using System;
-using Content.Shared.ActionBlocker;
 using Content.Shared.DragDrop;
 using Content.Shared.EffectBlocker;
 using Content.Shared.Interaction;
@@ -12,7 +11,7 @@ using Robust.Shared.ViewVariables;
 namespace Content.Shared.Buckle.Components
 {
     [NetworkedComponent()]
-    public abstract class SharedBuckleComponent : Component, IActionBlocker, IEffectBlocker, IDraggable
+    public abstract class SharedBuckleComponent : Component, IEffectBlocker, IDraggable
     {
         public sealed override string Name => "Buckle";
 
@@ -36,11 +35,6 @@ namespace Content.Shared.Buckle.Components
 
         public abstract bool TryBuckle(IEntity? user, IEntity to);
 
-        bool IActionBlocker.CanChangeDirection()
-        {
-            return !Buckled;
-        }
-
         bool IEffectBlocker.CanFall() => !Buckled;
 
         bool IDraggable.CanDrop(CanDropEvent args)

Content.Shared/Buckle/SharedBuckleSystem.cs

@@ -1,4 +1,5 @@
 using Content.Shared.Buckle.Components;
+using Content.Shared.Interaction.Events;
 using Content.Shared.Movement;
 using Content.Shared.Standing;
 using Content.Shared.Throwing;
@@ -17,6 +18,13 @@ namespace Content.Shared.Buckle
             SubscribeLocalEvent<SharedBuckleComponent, StandAttemptEvent>(HandleStand);
             SubscribeLocalEvent<SharedBuckleComponent, ThrowPushbackAttemptEvent>(HandleThrowPushback);
             SubscribeLocalEvent<SharedBuckleComponent, MovementAttemptEvent>(HandleMove);
+            SubscribeLocalEvent<SharedBuckleComponent, ChangeDirectionAttemptEvent>(OnBuckleChangeDirectionAttempt);
+        }
+
+        private void OnBuckleChangeDirectionAttempt(EntityUid uid, SharedBuckleComponent component, ChangeDirectionAttemptEvent args)
+        {
+            if (component.Buckled)
+                args.Cancel();
         }
 
         private void HandleMove(EntityUid uid, SharedBuckleComponent component, MovementAttemptEvent args)

Content.Shared/MobState/Components/MobStateComponent.cs

@@ -368,11 +368,6 @@ namespace Content.Shared.MobState.Components
         {
             return CurrentState?.CanUnequip() ?? true;
         }
-
-        bool IActionBlocker.CanChangeDirection()
-        {
-            return CurrentState?.CanChangeDirection() ?? true;
-        }
     }
 
     [Serializable, NetSerializable]

Content.Shared/MobState/EntitySystems/MobStateSystem.cs

@@ -1,4 +1,5 @@
 using Content.Shared.Damage;
+using Content.Shared.Interaction.Events;
 using Content.Shared.MobState.Components;
 using Content.Shared.MobState.State;
 using Content.Shared.Movement;
@@ -14,6 +15,7 @@ namespace Content.Shared.MobState.EntitySystems
         {
             base.Initialize();
 
+            SubscribeLocalEvent<MobStateComponent, ChangeDirectionAttemptEvent>(OnChangeDirectionAttempt);
             SubscribeLocalEvent<MobStateComponent, StartPullAttemptEvent>(OnStartPullAttempt);
             SubscribeLocalEvent<MobStateComponent, DamageChangedEvent>(UpdateState);
             SubscribeLocalEvent<MobStateComponent, MovementAttemptEvent>(OnMoveAttempt);
@@ -21,6 +23,17 @@ namespace Content.Shared.MobState.EntitySystems
             // Note that there's no check for Down attempts because if a mob's in crit or dead, they can be downed...
         }
 
+        private void OnChangeDirectionAttempt(EntityUid uid, MobStateComponent component, ChangeDirectionAttemptEvent args)
+        {
+            switch (component.CurrentState)
+            {
+                case SharedDeadMobState:
+                case SharedCriticalMobState:
+                    args.Cancel();
+                    break;
+            }
+        }
+
         private void OnStartPullAttempt(EntityUid uid, MobStateComponent component, StartPullAttemptEvent args)
         {
             if(component.IsIncapacitated())

Content.Shared/MobState/State/BaseMobState.cs

@@ -83,10 +83,5 @@ namespace Content.Shared.MobState.State
         {
             return true;
         }
-
-        public virtual bool CanChangeDirection()
-        {
-            return true;
-        }
     }
 }

Content.Shared/MobState/State/SharedCriticalMobState.cs

@@ -85,10 +85,5 @@ namespace Content.Shared.MobState.State
         {
             return false;
         }
-
-        public override bool CanChangeDirection()
-        {
-            return false;
-        }
     }
 }

Content.Shared/MobState/State/SharedDeadMobState.cs

@@ -94,11 +94,6 @@ namespace Content.Shared.MobState.State
             return false;
         }
 
-        public override bool CanChangeDirection()
-        {
-            return false;
-        }
-
         public bool CanShiver()
         {
             return false;

Content.Shared/MobState/State/SharedNormalMobState.cs

@@ -71,10 +71,5 @@ namespace Content.Shared.MobState.State
         {
             return true;
         }
-
-        public override bool CanChangeDirection()
-        {
-            return true;
-        }
     }
 }