Add uplink command minor revision and cleanup (#38532)

* commit

* Update AddUplinkCommand.cs
This commit is contained in:
Kyle Tyo
2025-06-24 06:46:35 -04:00
committed by GitHub
parent 33a1e59211
commit 71eed923ae
2 changed files with 66 additions and 80 deletions

View File

@@ -1,104 +1,90 @@
using Content.Server.Administration; using Content.Server.Administration;
using Content.Shared.Administration; using Content.Shared.Administration;
using Content.Shared.CCVar;
using Content.Shared.FixedPoint;
using Robust.Server.Player; using Robust.Server.Player;
using Robust.Shared.Configuration;
using Robust.Shared.Console; using Robust.Shared.Console;
using Robust.Shared.Player; using Robust.Shared.Player;
namespace Content.Server.Traitor.Uplink.Commands namespace Content.Server.Traitor.Uplink.Commands;
[AdminCommand(AdminFlags.Admin)]
public sealed class AddUplinkCommand : LocalizedEntityCommands
{ {
[AdminCommand(AdminFlags.Admin)] [Dependency] private readonly UplinkSystem _uplinkSystem = default!;
public sealed class AddUplinkCommand : IConsoleCommand [Dependency] private readonly IPlayerManager _playerManager = default!;
public override string Command => "adduplink";
public override void Execute(IConsoleShell shell, string argStr, string[] args)
{ {
[Dependency] private readonly IEntityManager _entManager = default!; if (args.Length > 3)
[Dependency] private readonly IPlayerManager _playerManager = default!;
public string Command => "adduplink";
public string Description => Loc.GetString("add-uplink-command-description");
public string Help => Loc.GetString("add-uplink-command-help");
public CompletionResult GetCompletion(IConsoleShell shell, string[] args)
{ {
return args.Length switch shell.WriteError(Loc.GetString("shell-wrong-arguments-number"));
{ return;
1 => CompletionResult.FromHintOptions(CompletionHelper.SessionNames(), Loc.GetString("add-uplink-command-completion-1")),
2 => CompletionResult.FromHint(Loc.GetString("add-uplink-command-completion-2")),
3 => CompletionResult.FromHint(Loc.GetString("add-uplink-command-completion-3")),
_ => CompletionResult.Empty
};
} }
public void Execute(IConsoleShell shell, string argStr, string[] args) ICommonSession? session;
if (args.Length > 0)
{ {
if (args.Length > 3) // Get player entity
if (!_playerManager.TryGetSessionByUsername(args[0], out session))
{ {
shell.WriteError(Loc.GetString("shell-wrong-arguments-number")); shell.WriteLine(Loc.GetString("shell-target-player-does-not-exist"));
return;
}
}
else
session = shell.Player;
if (session?.AttachedEntity is not { } user)
{
shell.WriteLine(Loc.GetString("add-uplink-command-error-1"));
return;
}
// Get target item
EntityUid? uplinkEntity = null;
if (args.Length >= 2)
{
if (!int.TryParse(args[1], out var itemId))
{
shell.WriteLine(Loc.GetString("shell-entity-uid-must-be-number"));
return; return;
} }
ICommonSession? session; var eNet = new NetEntity(itemId);
if (args.Length > 0)
{
// Get player entity
if (!_playerManager.TryGetSessionByUsername(args[0], out session))
{
shell.WriteLine(Loc.GetString("shell-target-player-does-not-exist"));
return;
}
}
else
{
session = shell.Player;
}
if (session?.AttachedEntity is not { } user) if (!EntityManager.TryGetEntity(eNet, out var eUid))
{ {
shell.WriteLine(Loc.GetString("add-uplink-command-error-1")); shell.WriteLine(Loc.GetString("shell-invalid-entity-id"));
return; return;
} }
// Get target item uplinkEntity = eUid;
EntityUid? uplinkEntity = null; }
if (args.Length >= 2)
var isDiscounted = false;
if (args.Length >= 3)
{
if (!bool.TryParse(args[2], out isDiscounted))
{ {
if (!int.TryParse(args[1], out var itemID)) shell.WriteLine(Loc.GetString("shell-invalid-bool"));
{ return;
shell.WriteLine(Loc.GetString("shell-entity-uid-must-be-number"));
return;
}
var eNet = new NetEntity(itemID);
if (!_entManager.TryGetEntity(eNet, out var eUid))
{
shell.WriteLine(Loc.GetString("shell-invalid-entity-id"));
return;
}
uplinkEntity = eUid;
}
bool isDiscounted = false;
if (args.Length >= 3)
{
if (!bool.TryParse(args[2], out isDiscounted))
{
shell.WriteLine(Loc.GetString("shell-invalid-bool"));
return;
}
}
// Finally add uplink
var uplinkSys = _entManager.System<UplinkSystem>();
if (!uplinkSys.AddUplink(user, 20, uplinkEntity: uplinkEntity, giveDiscounts: isDiscounted))
{
shell.WriteLine(Loc.GetString("add-uplink-command-error-2"));
} }
} }
// Finally add uplink
if (!_uplinkSystem.AddUplink(user, 20, uplinkEntity: uplinkEntity, giveDiscounts: isDiscounted))
shell.WriteLine(Loc.GetString("add-uplink-command-error-2"));
}
public override CompletionResult GetCompletion(IConsoleShell shell, string[] args)
{
return args.Length switch
{
1 => CompletionResult.FromHintOptions(CompletionHelper.SessionNames(), Loc.GetString("add-uplink-command-completion-1")),
2 => CompletionResult.FromHint(Loc.GetString("add-uplink-command-completion-2")),
3 => CompletionResult.FromHint(Loc.GetString("add-uplink-command-completion-3")),
_ => CompletionResult.Empty,
};
} }
} }

View File

@@ -1,5 +1,5 @@
add-uplink-command-description = Creates uplink on selected item and link it to users account cmd-adduplink-desc = Creates uplink on selected item and link it to users account
add-uplink-command-help = Usage: adduplink [username] [item-id] cmd-adduplink-help = Usage: adduplink [username] [item-id] [discountEnabled]
add-uplink-command-completion-1 = Username (defaults to self) add-uplink-command-completion-1 = Username (defaults to self)
add-uplink-command-completion-2 = Uplink uid (default to PDA) add-uplink-command-completion-2 = Uplink uid (default to PDA)